diff options
| author | Todd Kjos <tkjos@android.com> | 2019-06-05 09:37:46 -0700 |
|---|---|---|
| committer | Todd Kjos <tkjos@google.com> | 2019-06-12 11:10:09 -0700 |
| commit | 8236fb88a8c1ff2dfd9ac538ac54f8fbba2ade63 (patch) | |
| tree | b57ec33ba21ec9693e220588fcf56664124ccbd8 /net/ipv4/tcp_input.c | |
| parent | f992814dacebaeea274ab30eec890ec20a809b1e (diff) | |
BACKPORT: binder: fix race between munmap() and direct reclaim
commit 5cec2d2e5839f9c0fec319c523a911e0a7fd299f upstream.
An munmap() on a binder device causes binder_vma_close() to be called
which clears the alloc->vma pointer.
If direct reclaim causes binder_alloc_free_page() to be called, there
is a race where alloc->vma is read into a local vma pointer and then
used later after the mm->mmap_sem is acquired. This can result in
calling zap_page_range() with an invalid vma which manifests as a
use-after-free in zap_page_range().
The fix is to check alloc->vma after acquiring the mmap_sem (which we
were acquiring anyway) and skip zap_page_range() if it has changed
to NULL.
Bug: 120025196
Change-Id: I2f3284d294326ec7736303374769640a1e028783
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Todd Kjos <tkjos@google.com>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Cc: stable <stable@vger.kernel.org> # 4.14
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/ipv4/tcp_input.c')
0 files changed, 0 insertions, 0 deletions
