summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHareesh Gundu <hareeshg@codeaurora.org>2016-03-23 23:58:11 +0530
committerJeevan Shriram <jshriram@codeaurora.org>2016-04-13 11:04:00 -0700
commit4a6f12c7a0ea94183f58ce728617c446116fb58c (patch)
tree898776929f1cdfded8f84efba89701f477dd6c9b
parent0e5fa912901a038d4180edbfe354c54b58b38e59 (diff)
msm: kgsl: Fix gpudev NULL dereference in adreno_remove
In adreno_remove() there is possibility of dereference of gpudev without NULL check. Fix this by getting gpudev after adreno_dev NULL check. CRs-Fixed: 993267 Change-Id: I17d8b4ba2c74a787a065dbdb0ac88d065605fcb1 Signed-off-by: Hareesh Gundu <hareeshg@codeaurora.org>
-rw-r--r--drivers/gpu/msm/adreno.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/msm/adreno.c b/drivers/gpu/msm/adreno.c
index 79e95ebb8363..32c83ab76f09 100644
--- a/drivers/gpu/msm/adreno.c
+++ b/drivers/gpu/msm/adreno.c
@@ -1012,13 +1012,14 @@ static void _adreno_free_memories(struct adreno_device *adreno_dev)
static int adreno_remove(struct platform_device *pdev)
{
struct adreno_device *adreno_dev = adreno_get_dev(pdev);
- struct adreno_gpudev *gpudev = ADRENO_GPU_DEVICE(adreno_dev);
+ struct adreno_gpudev *gpudev;
struct kgsl_device *device;
if (adreno_dev == NULL)
return 0;
device = KGSL_DEVICE(adreno_dev);
+ gpudev = ADRENO_GPU_DEVICE(adreno_dev);
if (gpudev->remove != NULL)
gpudev->remove(adreno_dev);