diff options
| author | Antoine Giraudmaillet <antoine-g@live.fr> | 2018-01-03 23:39:19 +0000 |
|---|---|---|
| committer | Cosme Domínguez Díaz <cosme.ddiaz@gmail.com> | 2018-07-29 17:04:08 +0200 |
| commit | b20baf8b00ae7cbacf831e4c83ec0e951eb82041 (patch) | |
| tree | 7bcd1cf1d3afcf89c75f906e0b92657b4836abc4 | |
| parent | ea3246e1d67ae0b8d2e54879c98f0e7df6761ce1 (diff) | |
msm8996: ipacm: Fix memory leaks
* Errors reported by CppCheck.
Change-Id: I700e4c8ef6a4cb7f551e1d9c69f72d218b124dde
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
| -rw-r--r-- | data-ipa-cfg-mgr/ipacm/src/IPACM_Lan.cpp | 1 | ||||
| -rw-r--r-- | data-ipa-cfg-mgr/ipacm/src/IPACM_Main.cpp | 9 | ||||
| -rw-r--r-- | data-ipa-cfg-mgr/ipacm/src/IPACM_Netlink.cpp | 1 |
3 files changed, 7 insertions, 4 deletions
diff --git a/data-ipa-cfg-mgr/ipacm/src/IPACM_Lan.cpp b/data-ipa-cfg-mgr/ipacm/src/IPACM_Lan.cpp index d51343e..8d68d32 100644 --- a/data-ipa-cfg-mgr/ipacm/src/IPACM_Lan.cpp +++ b/data-ipa-cfg-mgr/ipacm/src/IPACM_Lan.cpp @@ -5515,6 +5515,7 @@ int IPACM_Lan::add_l2tp_flt_rule(ipa_ip_type iptype, uint8_t *dst_mac, uint32_t if(m_routing.GetRoutingTable(&rt_tbl) == false) { IPACMERR("Failed to get routing table.\n"); + free(pFilteringTable); return IPACM_FAILURE; } diff --git a/data-ipa-cfg-mgr/ipacm/src/IPACM_Main.cpp b/data-ipa-cfg-mgr/ipacm/src/IPACM_Main.cpp index d93cef6..76f805c 100644 --- a/data-ipa-cfg-mgr/ipacm/src/IPACM_Main.cpp +++ b/data-ipa-cfg-mgr/ipacm/src/IPACM_Main.cpp @@ -405,11 +405,12 @@ void* ipa_driver_msg_notifier(void *param) } memcpy(event_ex, buffer + sizeof(struct ipa_msg_meta), length); data_ex = (ipacm_event_data_wlan_ex *)malloc(sizeof(ipacm_event_data_wlan_ex) + event_ex_o.num_of_attribs * sizeof(ipa_wlan_hdr_attrib_val)); - if (data_ex == NULL) - { + if (data_ex == NULL) + { IPACMERR("unable to allocate memory for event data\n"); - return NULL; - } + free(event_ex); + return NULL; + } data_ex->num_of_attribs = event_ex->num_of_attribs; memcpy(data_ex->attribs, diff --git a/data-ipa-cfg-mgr/ipacm/src/IPACM_Netlink.cpp b/data-ipa-cfg-mgr/ipacm/src/IPACM_Netlink.cpp index e2ecd50..4ddf4bf 100644 --- a/data-ipa-cfg-mgr/ipacm/src/IPACM_Netlink.cpp +++ b/data-ipa-cfg-mgr/ipacm/src/IPACM_Netlink.cpp @@ -708,6 +708,7 @@ static int ipa_nl_decode_nlmsg if(ret_val != IPACM_SUCCESS) { IPACMERR("Error while getting interface name\n"); + free(data_fid); return IPACM_FAILURE; } IPACMDBG("Got a usb link_up event (Interface %s, %d) \n", dev_name, msg_ptr->nl_link_info.metainfo.ifi_index); |