summaryrefslogtreecommitdiff
path: root/drivers/platform/goldfish (follow)
Commit message (Collapse)AuthorAge
* goldfish: pipe: ANDROID: address must be written as __pa(x), not xRoman Kiryanov2018-06-05
| | | | | | | | The previous change missed the __pa transformation applied to the address before passing it further. The value also has to be written from the high part first. Bug: 72717639 Change-Id: Id0756ca733f26ced1d74179764116db05ec47bea Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: add missing check for memory allocatedRoman Kiryanov2018-06-04
| | | | | | Bug: 72717639 Change-Id: I9bc8db41f2269c38a259d842ea52bdc0037f3bae Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: remove redundant blank linesRoman Kiryanov2018-06-04
| | | | | | Bug: 72717639 Change-Id: I951c34c7247c764ccd40a3e62680909b76403c4c Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: mark local functions staticRoman Kiryanov2018-05-11
| | | | | | | | | | goldfish_dma_ioctl_getoff and goldfish_dma_ioctl_create_region are not used outside of goldfish_pipe_v2.c - mark them static. Bug: 72717639 Bug: 66884503 Signed-off-by: Roman Kiryanov <rkir@google.com> Change-Id: Id4fe524cc4db9d36b0c794ad9f34356f396153b4
* Revert "goldfish: pipe: ANDROID: Allocate memory with GFP_KERNEL."Roman Kiryanov2018-05-11
| | | | | | | | | | This reverts commit ed11d8f2a0d07756acace1a2a295f29e41976358. Since get_free_pipe_id_locked runs with interrupts disabled, we don't want to make calls that could lead to sleep. Bug: 72717639 Bug: 66884503 Signed-off-by: Roman Kiryanov <rkir@google.com> Change-Id: I6c2eac97fd415bdbd5afa0a3a90559e0da3e1c86
* goldfish: pipe: ANDROID: Add DMA supportRoman Kiryanov2018-05-08
| | | | | | | | | | | This change improves the pipe performance by removing unnesessary memory copying. Bug: 72717639 Bug: 66884503 Change-Id: I0d279f682039e411faf4212713d82ec355c3e9ee Signed-off-by: Roman Kiryanov <rkir@google.com> Signed-off-by: Lingfeng Yang <lfy@google.com>
* Revert "goldfish: pipe: ANDROID: remove a redundant target"Greg Kroah-Hartman2018-05-03
| | | | | | | | This reverts commit d176c57751903809f81c9021f4d45eb9c907e605. Reason for revert: this is a regression as it reverts a previous build fix. Change-Id: I880b97e6fc16a39dbc7be9466e0d1b7b2d8f9e8d
* goldfish: pipe: ANDROID: Replace writel with gf_write_ptrRoman Kiryanov2018-05-02
| | | | | | | | | | We have a function around a pair of writel to simplify 64-bit support. Bug: 72717639 bug: 66884503 Change-Id: Id23d23f6998e7be348646bb4ea9884f165c1149b Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: Use dev_ logging instead of pr_Roman Kiryanov2018-05-02
| | | | | | | | | | | The dev_ functions are the same as the corresponding pr_ functions, but also print identifying information about the struct device. Bug: 72717639 bug: 66884503 Change-Id: I0b1147cf607eb5b0b07dd9753dcf2b60e9700afe Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: fix checkpatch warningsRoman Kiryanov2018-05-02
| | | | | | | Bug: 72717639 bug: 66884503 Change-Id: I83ddd1c2da24a2658d8fe1e43718aa6e9fc47d5d Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: Update module licenseRoman Kiryanov2018-05-02
| | | | | | | | | | Change MODULE_LICENSE() string to properly match the license for the driver (goldfish_pipe.h). Bug: 72717639 Bug: 66884503 Change-Id: I4d1ef778276b26b49c83c967c3c9314b2c0c5da7 Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: Allocate memory with GFP_KERNEL.Roman Kiryanov2018-05-02
| | | | | | | | | We use GFP_KERNEL in the outer context. Bug: 72717639 Bug: 66884503 Change-Id: I5e10dba5138818351936ec0f70cd01070eaf199f Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: Do not crashRoman Kiryanov2018-05-02
| | | | | | | | | Return an error instead of crashing in signalled_pipes_add_locked. Bug: 72717639 Bug: 66884503 Change-Id: I811ad1932f1600f8bbe4598cdaf206bd96ea921a Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: remove redundant castingRoman Kiryanov2018-05-01
| | | | | | | | | Casting twice is not required. Bug: 72717639 Bug: 66884503 Change-Id: I3420388683a9746f2d2110af51d9d25c12c7eea6 Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: Add 'pipe' to pipe functionsRoman Kiryanov2018-05-01
| | | | | | | | | | Replace the 'goldfish' prefix with 'goldfish_pipe' to say they are pipe functions. Bug: 72717639 Bug: 66884503 Change-Id: I5a5cf7ee38cf2ae193877b1ffac19eadb15a374a Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: fix whitespaceRoman Kiryanov2018-05-01
| | | | | | | | | Make checkpatch.pl happy. Bug: 72717639 Bug: 66884503 Change-Id: Ie8758cc91595eba57a0c9144cfba9309da62c966 Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: rename global variablesRoman Kiryanov2018-05-01
| | | | | | | | | | | We don't need an array of 1 for pipe_dev and use better names to distinguish between goldfish_pipe_dev and miscdevice. Bug: 72717639 Bug: 66884503 Change-Id: Iab040c158745f034ca8e9569fd49c84933b1c4ba Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: remove a redundant targetRoman Kiryanov2018-05-01
| | | | | | | Bug: 72717639 Bug: 66884503 Change-Id: Ie2fbf13bccd68e5091c5966b78cb5838840bc61e Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: add blank linesRoman Kiryanov2018-05-01
| | | | | | | | | | To separate variable declarations from executable code and to improve readability. Bug: 72717639 Bug: 66884503 Change-Id: I46fb70b13b8e3d061dfc2288f5720a379f1f39a9 Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: replace 'BUG_ON' with 'BUILD_BUG_ON'Roman Kiryanov2018-05-01
| | | | | | | Bug: 72717639 Bug: 66884503 Change-Id: I6afcf21c7ff0fd2f5fcca327813b8406798c4269 Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: use the 'BIT' macro for wakeup flagsRoman Kiryanov2018-05-01
| | | | | | | Bug: 72717639 Bug: 66884503 Change-Id: I977525f145d8b678d39867037c5fddcc35e0a52b Signed-off-by: Roman Kiryanov <rkir@google.com>
* goldfish: pipe: ANDROID: fix logging format stringsRoman Kiryanov2018-05-01
| | | | | | | | | | * remove '%p' to avoid exposing kernel addresses; * add missing '\n'. Bug: 72717639 Bug: 66884503 Change-Id: I81357841dc334df595a3244f232c2e6bb72e64a1 Signed-off-by: Roman Kiryanov <rkir@google.com>
* ANDROID: add missing include to pdev_busRoman Kiryanov2018-04-04
| | | | | | Bug: 72886167 Change-Id: I23a875ae5ca325c11942b1174e0eca9d676f4bc4 Signed-off-by: Roman Kiryanov <rkir@google.com>
* ANDROID: pdev_bus: replace writel with gf_write_ptrRoman Kiryanov2018-04-04
| | | | | | | | | We introduced a function that calls writel inside to simplify 64bit support. Bug: 72886167 Change-Id: I987891e0b331a0e205da4bbf4ee98c19edf087b7 Signed-off-by: Roman Kiryanov <rkir@google.com>
* ANDROID: Use standard logging functions in goldfish_pipeRoman Kiryanov2018-03-20
| | | | | | | Bug: 72717639 bug: 66884503 Change-Id: Ifb784f6ebc5a7ef8981a6dbd4d3f6065b9347db3 Signed-off-by: Roman Kiryanov <rkir@google.com>
* ANDROID: Fix whitespace in goldfishRoman Kiryanov2018-03-20
| | | | | | | Bug: 72717639 bug: 66884503 Change-Id: I91848191e436012324935f6b62a5077792f2fb58 Signed-off-by: Roman Kiryanov <rkir@google.com>
* ANDROID: Address checkpatch.pl warnings in goldfish_pipeRoman Kiryanov2018-03-16
| | | | | Change-Id: I324549dccaab6a931c4cf91e9d0d1cbd130c6a09 Signed-off-by: Roman Kiryanov <rkir@google.com>
* ANDROID: goldfish: Fix typo in goldfish_cmd_locked() callDmitry Shmidt2018-03-14
| | | | | | | | | Patch 2898d1ea41670fe3142c8a1c0c6b58b4c24a555b ANDROID: Address checkpatch.pl warnings in goldfish_pipe_v2 has typo in function call. Change-Id: I3355c4a71f1e4026b6095a34cfe7adefa52f7fb6 Signed-off-by: Dmitry Shmidt <dimitrysh@google.com>
* ANDROID: Address checkpatch.pl warnings in goldfish_pipe_v2Roman Kiryanov2018-03-13
| | | | | Change-Id: Icb89f2c163ea7ba463f7d8492458699d15331856 Signed-off-by: Roman Kiryanov <rkir@google.com>
* Merge branch 'upstream-linux-4.4.y' into android-4.4Todd Kjos2017-03-02
|\
| * goldfish: Sanitize the broken interrupt handlerThomas Gleixner2017-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | commit 6cf18e6927c0b224f972e3042fb85770d63cb9f8 upstream. This interrupt handler is broken in several ways: - It loops forever when the op code is not decodeable - It never returns IRQ_HANDLED because the only way to exit the loop returns IRQ_NONE unconditionally. The whole concept of this is broken. Creating devices in an interrupt handler is beyond any point of sanity. Make it at least behave halfways sane so accidental users do not have to deal with a hard to debug lockup. Fixes: e809c22b8fb028 ("goldfish: add the goldfish virtual bus") Reported-by: Gabriel C <nix.or.die@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* | ANDROID: goldfish_pipe: fix allmodconfig buildJin Qian2016-11-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tree: https://android.googlesource.com/kernel/common android-4.4 head: 6297c6ba0d217d5b0998738fbfaff2f04cad77e6 commit: bc43565e1ac5ba3f204886a2275726bb4c3d44e6 [18/20] ANDROID: goldfish_pipe: An implementation of more parallel pipe config: i386-randconfig-s1-201646 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout bc43565e1ac5ba3f204886a2275726bb4c3d44e6 # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "goldfish_pipe_device_deinit_v1" [drivers/platform/goldfish/goldfish_pipe_v2.ko] undefined! >> ERROR: "goldfish_pipe_device_init_v1" [drivers/platform/goldfish/goldfish_pipe_v2.ko] undefined! >> ERROR: "pipe_dev" [drivers/platform/goldfish/goldfish_pipe.ko] undefined! Change-Id: Ibd51441edf82e6bb6824acc05ea795570cc374e8
* | ANDROID: goldfish: goldfish_pipe: fix locking errorsGreg Hackmann2016-11-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the get_user_pages_fast() call in goldfish_pipe_read_write() failed, it would return while still holding pipe->lock. goldfish_pipe_read_write() later releases and tries to re-acquire pipe->lock. If the re-acquire call failed, goldfish_pipe_read_write() would try unlock pipe->lock on exit anyway. This fixes the smatch messages: drivers/platform/goldfish/goldfish_pipe.c:392 goldfish_pipe_read_write() error: double unlock 'mutex:&pipe->lock' drivers/platform/goldfish/goldfish_pipe.c:397 goldfish_pipe_read_write() warn: inconsistent returns 'mutex:&pipe->lock'. Change-Id: Ifd06a76b32027ca451a001704ade0c5440ed69c4 Signed-off-by: Greg Hackmann <ghackmann@google.com>
* | ANDROID: goldfish_pipe: fix call_kern.cocci warningsJulia Lawall2016-11-18
| | | | | | | | | | | | | | | | | | | | | | | | Function get_free_pipe_id_locked called on line 671 inside lock on line 669 but uses GFP_KERNEL. Replace with GFP_ATOMIC. Generated by: scripts/coccinelle/locks/call_kern.cocci CC: Yurii Zubrytskyi <zyy@google.com> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Guenter Roeck <groeck@chromium.org>
* | ANDROID: goldfish_pipe: An implementation of more parallel pipeYurii Zubrytskyi2016-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a driver code for a redesigned android pipe. Currently it works for x86 and x64 emulators with the following performance results: ADB push to /dev/null, Ubuntu, 400 MB file, times are for 1/10/100 parallel adb commands x86 adb push: (4.4s / 11.5s / 2m10s) -> (2.8s / 6s / 51s) x64 adb push: (7s / 15s / (too long, 6m+) -> (2.7s / 6.2s / 52s) ADB pull and push to /data/ have the same %% of speedup More importantly, I don't see any signs of slowdowns when run in parallel with Antutu benchmark, so it is definitely making much better job at multithreading. The code features dynamic host detection: old emulator gets the previous version of the pipe driver code. Combine follow patch from android-goldfish-3.10 b543285 [pipe] Increase the default pipe buffers size, make it configurable Signed-off-by: "Yurii Zubrytskyi" <zyy@google.com> Change-Id: I140d506204cab6e78dd503e5a43abc8886e4ffff
* | ANDROID: goldfish_pipe: bugfixes and performance improvements.Yurii Zubrytskyi2016-11-17
| | | | | | | | | | | | | | | | | | | | | | | | Combine following patches from android-goldfish-3.18 branch: c0f015a [pipe] Fix the pipe driver for x64 platform + correct pages count 48e6bf5 [pipe] Use get_use_pages_fast() which is possibly faster fb20f13 [goldfish] More pages in goldfish pipe f180e6d goldfish_pipe: Return from read_write on signal and EIO 3dec3b7 [pipe] Fix a minor leak in setup_access_params_addr() Change-Id: I1041fd65d7faaec123e6cedd3dbbc5a2fbb86c4d
* | goldfish_bus: switch GOLDFISH_BUS config back to boolAmit Pundir2016-02-16
| | | | | | | | | | | | | | | | | | | | | | AOSP commit a61e4d271cba "Enable adb with android-pipe in IA image" made GOLDFISH_BUS modular (i.e switched it to "tristate" in Kconfig from "bool"), which is not buildable. Instead of fixing the build and supporting it in modular form, which AOSP doesn't agree with anyway, lets restore it to the original state ("bool") in the Kconfig. Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
* | goldfish: pipe: fix platform_no_drv_owner.cocci warningsFengguang Wu2016-02-16
| | | | | | | | | | | | | | | | | | | | | | | | No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Lizhe Liu <lizhe.liu@intel.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
* | Enable adb with android-pipe in IA imageLizhe Liu2016-02-16
|/ | | | | | | | | | | | | | | | | | | | | | | To enable adb for x86/x86_64 Brillo emulator, we bring drivers/platform/goldfish/ in kernel/common (branch android-3.18) up to date with that in kernel/goldfish (branch android-goldfish-3.10), by porting the following patches: 044d26f goldfish: Enable ACPI-based enumeration for android pipe acf92a5 goldfish_pipe: Pass physical addresses to the device if supported 77559b0 [MIPS] Enable platform support for Goldfish virtual devices 1bebc76 platform: goldfish: pipe: don't log when dropping PIPE_ERROR_AGAIN 3c56d07 platform: goldfish: pipe: add devicetree bindings ca8dafc android_pipe: Pin pages to memory while copying and other cleanups b765d47 android_pipe: don't be clever with #define offsets 7119108 goldfish: refactor goldfish platform configs dc02035 goldfish: fix kernel panic when using multiple adb connection Change-Id: Ic4f2f5e43ba2a70831d6a12a370417984f784dbc Signed-off-by: Lizhe Liu <lizhe.liu@intel.com> Signed-off-by: Tina Zhang <tina.zhang@intel.com> Signed-off-by: Jason Hu <jia-cheng.hu@intel.com> Signed-off-by: Yu Ning <yu.ning@intel.com>
* Merge tag 'module-builtin_driver-v4.1-rc8' of ↵Linus Torvalds2015-07-02
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux Pull module_platform_driver replacement from Paul Gortmaker: "Replace module_platform_driver with builtin_platform driver in non modules. We see an increasing number of non-modular drivers using modular_driver() type register functions. There are several downsides to letting this continue unchecked: - The code can appear modular to a reader of the code, and they won't know if the code really is modular without checking the Makefile and Kconfig to see if compilation is governed by a bool or tristate. - Coders of drivers may be tempted to code up an __exit function that is never used, just in order to satisfy the required three args of the modular registration function. - Non-modular code ends up including the <module.h> which increases CPP overhead that they don't need. - It hinders us from performing better separation of the module init code and the generic init code. So here we introduce similar macros for builtin drivers. Then we convert builtin drivers (controlled by a bool Kconfig) by making the following type of mapping: module_platform_driver() ---> builtin_platform_driver() module_platform_driver_probe() ---> builtin_platform_driver_probe(). The set of drivers that are converted here are just the ones that showed up as relying on an implicit include of <module.h> during a pending header cleanup. So we convert them here vs adding an include of <module.h> to non-modular code to avoid compile fails. Additonal conversions can be done asynchronously at any time. Once again, an unused module_exit function that is removed here appears in the diffstat as an outlier wrt all the other changes" * tag 'module-builtin_driver-v4.1-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux: drivers/clk: convert sunxi/clk-mod0.c to use builtin_platform_driver drivers/power: Convert non-modular syscon-reboot to use builtin_platform_driver drivers/soc: Convert non-modular soc-realview to use builtin_platform_driver drivers/soc: Convert non-modular tegra/pmc to use builtin_platform_driver drivers/cpufreq: Convert non-modular s5pv210-cpufreq.c to use builtin_platform_driver drivers/cpuidle: Convert non-modular drivers to use builtin_platform_driver drivers/platform: Convert non-modular pdev_bus to use builtin_platform_driver platform_device: better support builtin boilerplate avoidance
| * drivers/platform: Convert non-modular pdev_bus to use builtin_platform_driverPaul Gortmaker2015-06-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This driver is configured with a Kconfig option that is declared as a bool. Hence it is not possible for the code to be built as modular. However the code is currently using the module_platform_driver() macro for driver registration. While this currently works, we really don't want to be including the module.h header in non-modular code, which we'll be forced to do, pending some upcoming code relocation from init.h into module.h. So we fix it now by using the non-modular equivalent. And since we've already established that the code is non-modular, we can completely drop any code relating to module_exit. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
* | Merge tag 'staging-4.2-rc1' of ↵Linus Torvalds2015-06-26
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging Pull staging driver updates from Greg KH: "Here's the big, really big, staging tree patches for 4.2-rc1. Loads of stuff in here, almost all just coding style fixes / churn, and a few new drivers as well, one of which I just disabled from the build a few minutes ago due to way too many build warnings. Other than the one "disable this driver" patch, all of these have been in linux-next for quite a while with no reported issues" * tag 'staging-4.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (1163 commits) staging: wilc1000: disable driver due to build warnings Staging: rts5208: fix CHANGE_LINK_STATE value Staging: sm750fb: ddk750_swi2c.c: Insert spaces before parenthesis Staging: sm750fb: ddk750_swi2c.c: Place braces on correct lines Staging: sm750fb: ddk750_swi2c.c: Insert spaces around operators Staging: sm750fb: ddk750_swi2c.c: Replace spaces with tabs Staging: sm750fb: ddk750_swi2c.h: Shorten lines to under 80 characters Staging: sm750fb: ddk750_swi2c.h: Replace spaces with tabs Staging: sm750fb: modedb.h: Shorten lines to under 80 characters Staging: sm750fb: modedb.h: Replace spaces with tabs staging: comedi: addi_apci_3120: rename 'this_board' variables staging: comedi: addi_apci_1516: rename 'this_board' variables staging: comedi: ni_atmio: cleanup ni_getboardtype() staging: comedi: vmk80xx: sanity check context used to get the boardinfo staging: comedi: vmk80xx: rename 'boardinfo' variables staging: comedi: dt3000: rename 'this_board' variables staging: comedi: adv_pci_dio: rename 'this_board' variables staging: comedi: cb_pcidas64: rename 'thisboard' variables staging: comedi: cb_pcidas: rename 'thisboard' variables staging: comedi: me4000: rename 'thisboard' variables ...
| * | staging: goldfish: Fix pointer cast for 32 bitsPeter Senna Tschudin2015-05-31
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As the first argument of gf_write64() was of type unsigned long, and as some calls to gf_write64() were casting the first argument from void * to u64 the compiler and/or sparse were printing warnings for casts of wrong sizes when compiling for i386. This patch changes the type of the first argument of gf_write64() to const void *, and update calls to the function. This change fixed the warnings and allowed to remove casts from 3 calls to gf_write64(). In addition gf_write64() was renamed to gf_write_ptr() as the name was misleading because it only writes 32 bits on 32 bit systems. gf_write_dma_addr() was added to handle dma_addr_t values which is used at drivers/staging/goldfish/goldfish_audio.c. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* / goldfish_pipe: Fix unlikely() misuseJoe Perches2015-05-24
|/ | | | | | | Move the close parenthesis. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: pipe: fix warnings for 32bit buildsOctavian Purdila2014-05-16
| | | | | | | | | | | | | | | | | | | | drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_cmd_status': drivers/platform/goldfish/goldfish_pipe.c:164:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL); ^ drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_cmd': drivers/platform/goldfish/goldfish_pipe.c:180:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL); ^ drivers/platform/goldfish/goldfish_pipe.c: In function 'goldfish_pipe_read_write': drivers/platform/goldfish/goldfish_pipe.c:337:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] writel((u32)(u64)pipe, dev->base + PIPE_REG_CHANNEL); Reported-by: Fengguang Wu <fengguang.wu@intel.com> Cc: Jun Tian <jun.j.tian@intel.com> Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: bus: fix warnings for 32bit buildsOctavian Purdila2014-05-16
| | | | | | | | | | | | drivers/platform/goldfish/pdev_bus.c: In function 'goldfish_new_pdev': drivers/platform/goldfish/pdev_bus.c:136:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] writel((u32)(u64)name, pdev_bus_base + PDEV_BUS_GET_NAME); Reported-by: Fengguang Wu <fengguang.wu@intel.com> Cc: Jun Tian <jun.j.tian@intel.com> Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: clean up the pipe driver 64bit ifdefsAlan2014-05-15
| | | | | | | | Use the 64bit helper method to scrub most of the ifdefs from the driver. The pipe reading has a funny case we can't scrub completely. Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: add support for 64bit to the virtual busOctavian Purdila2014-05-15
| | | | | | | | | | This patchs adds a new register to pass the upper 32bits for the device name address when running in 64bit mode. Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> Signed-off-by: Jun Tian <jun.j.tian@intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: fix kernel panic when using multiple adb connectionJun Tian2014-05-15
| | | | | | | | | When using multiple adb on 64 bit kernel to transfer data, the goldfish pipe interrupt will crash the kernel. Signed-off-by: Jun Tian <jun.j.tian@intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* goldfish: 64-bit pipe driver for goldfish platformJun Tian2014-05-15
| | | | | | | | | | Support 64-bit channel and address for the goldfish pipe driver. Signed-off-by: Jun Tian <jun.j.tian@intel.com> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> Signed-off-by: Brian Wood <brian.j.wood@intel.com> Signed-off-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.25.1) at 2026-01-28 17:44:37 +0000