diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2020-05-06 15:33:04 -0600 |
|---|---|---|
| committer | Michael Bestas <mkbestas@lineageos.org> | 2020-12-31 19:40:44 +0200 |
| commit | 7a2c0fd2f9bbeba37377d4836195ef28eb6fc4af (patch) | |
| tree | 8c4d1a8e3a5663d78fcbc2a673e71d2360ce71eb /kernel/workqueue.c | |
| parent | c8b74de7a529914e3174d950890deafb8ac5bbf4 (diff) | |
UPSTREAM: wireguard: send/receive: cond_resched() when processing worker ringbuffers
Users with pathological hardware reported CPU stalls on CONFIG_
PREEMPT_VOLUNTARY=y, because the ringbuffers would stay full, meaning
these workers would never terminate. That turned out not to be okay on
systems without forced preemption, which Sultan observed. This commit
adds a cond_resched() to the bottom of each loop iteration, so that
these workers don't hog the core. Note that we don't need this on the
napi poll worker, since that terminates after its budget is expended.
Suggested-by: Sultan Alsawaf <sultan@kerneltoast.com>
Reported-by: Wang Jian <larkwang@gmail.com>
Fixes: e7096c131e51 ("net: WireGuard secure network tunnel")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 4005f5c3c9d006157ba716594e0d70c88a235c5e)
Bug: 152722841
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Change-Id: I95440398070e8f6bf11894bd967a3fc4e06c29a8
Diffstat (limited to 'kernel/workqueue.c')
0 files changed, 0 insertions, 0 deletions