diff options
| author | Ghanim Fodi <gfodi@codeaurora.org> | 2018-03-06 16:43:18 +0200 |
|---|---|---|
| committer | Michael Bestas <mkbestas@lineageos.org> | 2020-02-02 01:40:58 +0200 |
| commit | f133f6bfdc78ec159b50b1f4c2f496e2933b18a0 (patch) | |
| tree | 2c24aacd6bbec7e18d8a1dc53b4c60bd0915fc04 /kernel/sysctl_binary.c | |
| parent | fc9b313534e6c572a93475d71005431604f8d856 (diff) | |
msm: ipa3: Use bitwise instead of logical operator
commit 189a5aa30fc8 ("msm: ipa3: Fix IPA aggregation register val-mask
calculation") introduced a compile time error. The logical '&&' has been
used in a situation where the bitwise '&' operator is needed.
drivers/platform/msm/ipa/ipa_v3/ipahal/ipahal_reg.c:2132:67: error: use of logical '&&' with
constant operand [-Werror,-Wconstant-logical-operand]
valmask->val = (1 << IPA_ENDP_INIT_AGGR_n_AGGR_FORCE_CLOSE_SHFT) &&
^
drivers/platform/msm/ipa/ipa_v3/ipahal/ipahal_reg.c:2132:67: note: use '&' for a bitwise
operation
valmask->val = (1 << IPA_ENDP_INIT_AGGR_n_AGGR_FORCE_CLOSE_SHFT) &&
^~
&
drivers/platform/msm/ipa/ipa_v3/ipahal/ipahal_reg.c:2132:67: note: remove constant to silence
this warning
valmask->val = (1 << IPA_ENDP_INIT_AGGR_n_AGGR_FORCE_CLOSE_SHFT) &&
~^~
drivers/platform/msm/ipa/ipa_v3/ipahal/ipahal_reg.c:2136:60: error: use of logical '&&' with
constant operand [-Werror,-Wconstant-logical-operand]
valmask->val |= ((0 << IPA_ENDP_INIT_AGGR_n_AGGR_EN_SHFT) &&
^
drivers/platform/msm/ipa/ipa_v3/ipahal/ipahal_reg.c:2136:60: note: use '&' for a bitwise
operation
valmask->val |= ((0 << IPA_ENDP_INIT_AGGR_n_AGGR_EN_SHFT) &&
^~
&
drivers/platform/msm/ipa/ipa_v3/ipahal/ipahal_reg.c:2136:60: note: remove constant to silence
this warning
valmask->val |= ((0 << IPA_ENDP_INIT_AGGR_n_AGGR_EN_SHFT) &&
~^~
2 errors generated.
Fixes: 189a5aa30fc8 ("msm: ipa3: Fix IPA aggregation register val-mask calculation")
Signed-off-by: Daniel Mentz <danielmentz@google.com>
Change-Id: Ia077e270743e4551e4b7777c2ced5b021487fff6
CRs-fixed: 2196859
Signed-off-by: Ghanim Fodi <gfodi@codeaurora.org>
Link: https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=9400cb84016214a08682c4d9726179e572e0c9a6
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Diffstat (limited to 'kernel/sysctl_binary.c')
0 files changed, 0 insertions, 0 deletions