diff options
| author | Srivatsa Vaddagiri <vatsa@codeaurora.org> | 2014-07-23 14:27:18 +0530 |
|---|---|---|
| committer | David Keitel <dkeitel@codeaurora.org> | 2016-03-23 20:00:03 -0700 |
| commit | 1ffae4dc94bded073868b760fafa443a44303f55 (patch) | |
| tree | 907ea9e3c6144c020938b04e0ddeb80f08b90308 /kernel/sysctl.c | |
| parent | 0b210afc21c31a1bd28b721a70a54aced29eedb0 (diff) | |
sched: window-stats: Handle policy change properly
sched_window_stat_policy influences task demand and thus various
statistics maintained per-cpu like curr_runnable_sum. Changing policy
non-atomically would lead to improper accounting. For example, when
task is enqueued on a cpu's runqueue, its demand that is added to
rq->cumulative_runnable_avg could be based on AVG policy and when its
dequeued its demand that is removed can be based on MAX, leading to
erroneous accounting.
This change causes policy change to be "atomic" i.e all cpu's rq->lock
are held and all task's window-stats are reset before policy is changed.
Change-Id: I6a3e4fb7bc299dfc5c367693b5717a1ef518c32d
CRs-Fixed: 687409
Signed-off-by: Srivatsa Vaddagiri <vatsa@codeaurora.org>
[joonwoop@codeaurora.org: fixed minor conflict in
include/linux/sched/sysctl.h.
Signed-off-by: Joonwoo Park <joonwoop@codeaurora.org>
Diffstat (limited to 'kernel/sysctl.c')
| -rw-r--r-- | kernel/sysctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index abe1ea74f977..2c464882e2da 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -314,7 +314,7 @@ static struct ctl_table kern_table[] = { .data = &sysctl_sched_window_stats_policy, .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = sched_window_stats_policy_update_handler, }, { .procname = "sched_wakeup_load_threshold", |