summaryrefslogtreecommitdiff
path: root/include/linux
diff options
context:
space:
mode:
authorMark Rutland <mark.rutland@arm.com>2016-01-25 11:44:55 +0000
committerJeff Vander Stoep <jeffv@google.com>2016-09-18 14:50:53 -0700
commit81d07628d337df8070830a82fbca2f52015e0ebd (patch)
tree9b17aced0199319ccdbd3a55517ce42d6850b320 /include/linux
parent720345213019ec25bc43f6b78592f4c39e2c1731 (diff)
UPSTREAM: asm-generic: Fix local variable shadow in __set_fixmap_offset
Currently __set_fixmap_offset is a macro function which has a local variable called 'addr'. If a caller passes a 'phys' parameter which is derived from a variable also called 'addr', the local variable will shadow this, and the compiler will complain about the use of an uninitialized variable. To avoid the issue with namespace clashes, 'addr' is prefixed with a liberal sprinkling of underscores. Turning __set_fixmap_offset into a static inline breaks the build for several architectures. Fixing this properly requires updates to a number of architectures to make them agree on the prototype of __set_fixmap (it could be done as a subsequent patch series). Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Arnd Bergmann <arnd@arndb.de> [catalin.marinas@arm.com: squashed the original function patch and macro fixup] Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> Bug: 30369029 Patchset: rework-pagetable (cherry picked from commit 3694bd76781b76c4f8d2ecd85018feeb1609f0e5) Signed-off-by: Jeff Vander Stoep <jeffv@google.com> Change-Id: Iec27cb36dfca39e333de9f7318e76da0670d0156
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions