summaryrefslogtreecommitdiff
path: root/include/linux
diff options
context:
space:
mode:
authorDenis Efremov <efremov@ispras.ru>2019-07-12 21:55:21 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-08-04 09:34:52 +0200
commit350de13e03e487575dbca4dfddb574cd6526115e (patch)
treef60303a9a8222b28f1f061c8e1a98b70633263e9 /include/linux
parent26d6284d5d392bd96c414f745bcbf3620e93c8fd (diff)
floppy: fix out-of-bounds read in next_valid_format
[ Upstream commit 5635f897ed83fd539df78e98ba69ee91592f9bb8 ] This fixes a global out-of-bounds read access in the next_valid_format function of the floppy driver. The values from autodetect field of the struct floppy_drive_params are used as indices for the floppy_type array in the next_valid_format function 'floppy_type[DP->autodetect[probed_format]].sect'. To trigger the bug, one could use a value out of range and set the drive parameters with the FDSETDRVPRM ioctl. A floppy disk is not required to be inserted. CAP_SYS_ADMIN is required to call FDSETDRVPRM. The patch adds the check for values of the autodetect field to be in the '0 <= x < ARRAY_SIZE(floppy_type)' range of the floppy_type array indices. The bug was found by syzkaller. Signed-off-by: Denis Efremov <efremov@ispras.ru> Tested-by: Willy Tarreau <w@1wt.eu> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux')
0 files changed, 0 insertions, 0 deletions