diff options
| author | Eric Biggers <ebiggers@google.com> | 2017-10-09 12:46:18 -0700 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2018-01-04 16:32:29 -0800 |
| commit | bc4a61c60bea8d5e7468885ef7b7a41ba16b1b96 (patch) | |
| tree | da51f4e841b6478f73e3b47e54bd2ef19cf42213 /fs/ext4/inode.c | |
| parent | a53dc7e00559b3302b38deeffab735fdfe6ec20c (diff) | |
fscrypt: fix dereference of NULL user_key_payload
When an fscrypt-encrypted file is opened, we request the file's master
key from the keyrings service as a logon key, then access its payload.
However, a revoked key has a NULL payload, and we failed to check for
this. request_key() *does* skip revoked keys, but there is still a
window where the key can be revoked before we acquire its semaphore.
Fix it by checking for a NULL payload, treating it like a key which was
already revoked at the time it was requested.
Fixes: 88bd6ccdcdd6 ("ext4 crypto: add encryption key management facilities")
Reviewed-by: James Morris <james.l.morris@oracle.com>
Cc: <stable@vger.kernel.org> [v4.1+]
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/ext4/inode.c')
0 files changed, 0 insertions, 0 deletions
