summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorLinux Build Service Account <lnxbuild@localhost>2016-08-07 23:22:40 -0700
committerGerrit - the friendly Code Review server <code-review@localhost>2016-08-07 23:22:40 -0700
commit2b3049ef40e6e79af889d3d3eb92cd9797558ed3 (patch)
tree27ca9d72d6ea7b545683f86d75c7f12701b4d337 /drivers
parent5306d48b2975639ce92c6908bf6aa27daa77a519 (diff)
parent3ecbc7ec46644dc7461740577957f39cbfa2da96 (diff)
Merge "qseecom: Fix ion memory issue during unload app failure"
Diffstat (limited to 'drivers')
-rw-r--r--drivers/misc/qseecom.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/misc/qseecom.c b/drivers/misc/qseecom.c
index ca790d684be7..779994a1c9dd 100644
--- a/drivers/misc/qseecom.c
+++ b/drivers/misc/qseecom.c
@@ -2100,7 +2100,7 @@ static int qseecom_unload_app(struct qseecom_dev_handle *data,
if (!memcmp(data->client.app_name, "keymaste", strlen("keymaste"))) {
pr_debug("Do not unload keymaster app from tz\n");
- return 0;
+ goto unload_exit;
}
__qseecom_cleanup_app(data);
@@ -2152,7 +2152,7 @@ static int qseecom_unload_app(struct qseecom_dev_handle *data,
pr_err("scm_call to unload app (id = %d) failed\n",
req.app_id);
ret = -EFAULT;
- goto not_release_exit;
+ goto unload_exit;
} else {
pr_warn("App id %d now unloaded\n", req.app_id);
}
@@ -2160,7 +2160,7 @@ static int qseecom_unload_app(struct qseecom_dev_handle *data,
pr_err("app (%d) unload_failed!!\n",
data->client.app_id);
ret = -EFAULT;
- goto not_release_exit;
+ goto unload_exit;
}
if (resp.result == QSEOS_RESULT_SUCCESS)
pr_debug("App (%d) is unloaded!!\n",
@@ -2170,7 +2170,7 @@ static int qseecom_unload_app(struct qseecom_dev_handle *data,
if (ret) {
pr_err("process_incomplete_cmd fail err: %d\n",
ret);
- goto not_release_exit;
+ goto unload_exit;
}
}
}
@@ -2200,7 +2200,6 @@ static int qseecom_unload_app(struct qseecom_dev_handle *data,
unload_exit:
qseecom_unmap_ion_allocated_memory(data);
data->released = true;
-not_release_exit:
return ret;
}