summaryrefslogtreecommitdiff
path: root/drivers/video/fbdev/msm
diff options
context:
space:
mode:
authorLinux Build Service Account <lnxbuild@localhost>2016-11-28 23:57:25 -0800
committerGerrit - the friendly Code Review server <code-review@localhost>2016-11-28 23:57:25 -0800
commit2c6ca087dab363ec8309ecb9010ce1f9602a0ac2 (patch)
tree8e96db06ee3cafbfc7fb8d984f21934d5be32ca9 /drivers/video/fbdev/msm
parenta471456332f223a778034f8ee0dbff2ced19d9fe (diff)
parent434dda63fc8ab9d486110e8ce5b0d704758fa8ed (diff)
Merge "msm: mdss: Fix potential deferencing of null pointer"
Diffstat (limited to 'drivers/video/fbdev/msm')
-rw-r--r--drivers/video/fbdev/msm/mdss_mdp_pp.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/video/fbdev/msm/mdss_mdp_pp.c b/drivers/video/fbdev/msm/mdss_mdp_pp.c
index 8cbae2cf14d0..5a8438caba4b 100644
--- a/drivers/video/fbdev/msm/mdss_mdp_pp.c
+++ b/drivers/video/fbdev/msm/mdss_mdp_pp.c
@@ -6986,9 +6986,6 @@ static int is_valid_calib_addr(void *addr, u32 operation)
int ret = 0;
char __iomem *ptr = addr;
char __iomem *mixer_base = mdss_res->mixer_intf->base;
- char __iomem *rgb_base = mdss_res->rgb_pipes->base;
- char __iomem *dma_base = mdss_res->dma_pipes->base;
- char __iomem *vig_base = mdss_res->vig_pipes->base;
char __iomem *ctl_base = mdss_res->ctl_off->base;
char __iomem *dspp_base = mdss_res->mixer_intf->dspp_base;
@@ -7020,17 +7017,20 @@ static int is_valid_calib_addr(void *addr, u32 operation)
if (ret)
goto valid_addr;
}
- if (ptr >= vig_base) {
+ if (mdss_res->vig_pipes &&
+ ptr >= mdss_res->vig_pipes->base) {
ret = is_valid_calib_vig_addr(ptr);
if (ret)
goto valid_addr;
}
- if (ptr >= rgb_base) {
+ if (mdss_res->rgb_pipes &&
+ ptr >= mdss_res->rgb_pipes->base) {
ret = is_valid_calib_rgb_addr(ptr);
if (ret)
goto valid_addr;
}
- if (ptr >= dma_base) {
+ if (mdss_res->dma_pipes &&
+ ptr >= mdss_res->dma_pipes->base) {
ret = is_valid_calib_dma_addr(ptr);
if (ret)
goto valid_addr;