summaryrefslogtreecommitdiff
path: root/drivers/usb
diff options
context:
space:
mode:
authorMayank Rana <mrana@codeaurora.org>2016-09-23 11:40:37 -0700
committerMayank Rana <mrana@codeaurora.org>2016-09-23 11:40:37 -0700
commit1ed274d00a29d578cd9dd213d1912f093e404968 (patch)
tree631a52933dc5247ad9b6fc63e63c0662890d4861 /drivers/usb
parent9e2d528dc47d04e98c5e6f1c4ef84fc268115d36 (diff)
usb: gadget: f_cdev: Avoid potential NULL pointer dereference
Fix possible NULL pointer dereference issue as strrchr() API can return NULL if there is no port_num found as part of passed string. Change-Id: I410e58361282f175e46b68cbfaf4824e386454f8 Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/gadget/function/f_cdev.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/gadget/function/f_cdev.c b/drivers/usb/gadget/function/f_cdev.c
index e1302108a917..b288a848aaa0 100644
--- a/drivers/usb/gadget/function/f_cdev.c
+++ b/drivers/usb/gadget/function/f_cdev.c
@@ -1770,6 +1770,10 @@ static int cser_set_inst_name(struct usb_function_instance *f, const char *name)
/* get port number */
str = strrchr(name, '.');
+ if (!str) {
+ pr_err("err: port number not found\n");
+ return -EINVAL;
+ }
pr_debug("str:%s\n", str);
*str = '\0';