summaryrefslogtreecommitdiff
path: root/drivers/net
diff options
context:
space:
mode:
authorWei Yongjun <weiyongjun1@huawei.com>2019-01-18 07:29:52 +0000
committerAlistair Strachan <astrachan@google.com>2019-02-09 01:25:27 +0000
commit363f6f40b1e2b7a8a1dec96bcd6088c7c6dd37d0 (patch)
tree21453ded73bfd7921e4fa8872cce1138e3952cba /drivers/net
parent983e064bcbe0da3b5df688dca6baf417773cee39 (diff)
UPSTREAM: virt_wifi: fix error return code in virt_wifi_newlink()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: c7cdba31ed8b ("mac80211-next: rtnetlink wifi simulation device") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com> (cherry picked from commit f9d672f1c2ca36b788511bbd773d650c744e109a) Change-Id: Ia6290ab996afca7b33e1a8e9b8bcfc0ecbe252f4 Signed-off-by: Cody Schuffelen <schuffelen@google.com>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/wireless/virt_wifi.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index 90ecb7e8834f..9c303f482aa9 100644
--- a/drivers/net/wireless/virt_wifi.c
+++ b/drivers/net/wireless/virt_wifi.c
@@ -527,8 +527,10 @@ static int virt_wifi_newlink(struct net *src_net, struct net_device *dev,
SET_NETDEV_DEV(dev, &priv->lowerdev->dev);
dev->ieee80211_ptr = kzalloc(sizeof(*dev->ieee80211_ptr), GFP_KERNEL);
- if (!dev->ieee80211_ptr)
+ if (!dev->ieee80211_ptr) {
+ err = -ENOMEM;
goto remove_handler;
+ }
dev->ieee80211_ptr->iftype = NL80211_IFTYPE_STATION;
dev->ieee80211_ptr->wiphy = common_wiphy;