diff options
| author | Ankit Gupta <guptaank@codeaurora.org> | 2016-09-15 11:00:16 -0700 |
|---|---|---|
| committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2016-09-21 17:09:10 -0700 |
| commit | d66a881e08373a0d11ceecade7e2bed6f1cb4bc8 (patch) | |
| tree | 6c9eae20406954c2a47208b6b9e446275d6f84fa /core | |
| parent | a507601be7c85b4a8356af690b0ec9cca04ca569 (diff) | |
qcacld-3.0: Align return value check for lim_cmp_ssid
lim_cmp_ssid api returns zero when comparison ssid matches
else returns non zero. Checking return value with true/false
can cause confusion and errors.
Replace the return value check from true/false to
zero/non-zero values.
Change-Id: Id22560cb4c2289431995dab3087b4eb24546a8bf
CRs-Fixed: 1067454
Diffstat (limited to 'core')
| -rw-r--r-- | core/mac/src/pe/lim/lim_api.c | 4 | ||||
| -rw-r--r-- | core/mac/src/pe/lim/lim_assoc_utils.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/core/mac/src/pe/lim/lim_api.c b/core/mac/src/pe/lim/lim_api.c index 8ef2839f37a9..c2d6f88c11d5 100644 --- a/core/mac/src/pe/lim/lim_api.c +++ b/core/mac/src/pe/lim/lim_api.c @@ -1252,7 +1252,7 @@ lim_handle_ibss_coalescing(tpAniSirGlobal pMac, 4. Encyption type in the beacon does not match with self station */ if ((!pBeacon->capabilityInfo.ibss) || - (lim_cmp_ssid(&pBeacon->ssId, psessionEntry) == true) || + lim_cmp_ssid(&pBeacon->ssId, psessionEntry) || (psessionEntry->currentOperChannel != pBeacon->channelNumber)) retCode = eSIR_LIM_IGNORE_BEACON; else if (lim_ibss_enc_type_matched(pBeacon, psessionEntry) != eSIR_TRUE) { @@ -1403,7 +1403,7 @@ lim_detect_change_in_ap_capabilities(tpAniSirGlobal pMac, psessionEntry); if ((false == psessionEntry->limSentCapsChangeNtf) && (((!lim_is_null_ssid(&pBeacon->ssId)) && - (false != lim_cmp_ssid(&pBeacon->ssId, psessionEntry))) || + lim_cmp_ssid(&pBeacon->ssId, psessionEntry)) || ((SIR_MAC_GET_ESS(apNewCaps.capabilityInfo) != SIR_MAC_GET_ESS(psessionEntry->limCurrentBssCaps)) || (SIR_MAC_GET_PRIVACY(apNewCaps.capabilityInfo) != diff --git a/core/mac/src/pe/lim/lim_assoc_utils.c b/core/mac/src/pe/lim/lim_assoc_utils.c index 2fd381ab4b74..31818d187df1 100644 --- a/core/mac/src/pe/lim/lim_assoc_utils.c +++ b/core/mac/src/pe/lim/lim_assoc_utils.c @@ -70,7 +70,7 @@ * This function is called in various places within LIM code * to determine whether received SSID is same as SSID in use. * - * Return: true if SSID matched, false otherwise. + * Return: zero if SSID matched, non-zero otherwise. */ uint32_t lim_cmp_ssid(tSirMacSSid *rx_ssid, tpPESession session_entry) { |