diff options
| author | Ankit Gupta <guptaank@codeaurora.org> | 2016-09-14 11:32:19 -0700 |
|---|---|---|
| committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2016-09-21 17:08:59 -0700 |
| commit | a507601be7c85b4a8356af690b0ec9cca04ca569 (patch) | |
| tree | e69497ee019acd64804e4a594f6681b7e99ee572 /core/dp | |
| parent | 4316b7a8870cd316bcf6524bc96de6b3f9633fde (diff) | |
qcacld-3.0: Align return value check for qdf_mem_cmp
qdf_mem_cmp api returns zero when comparison string matches
else returns non zero. Checking return value with true/false
can cause confusion and errors.
Replace the return value check from true/false to
zero/non-zero values.
Change-Id: I485d69a4bf85d1e6273ea780af6d0423c3910686
CRs-Fixed: 1066946
Diffstat (limited to 'core/dp')
| -rw-r--r-- | core/dp/txrx/ol_rx.c | 4 | ||||
| -rw-r--r-- | core/dp/txrx/ol_rx_fwd.c | 4 | ||||
| -rw-r--r-- | core/dp/txrx/ol_txrx.c | 10 |
3 files changed, 7 insertions, 11 deletions
diff --git a/core/dp/txrx/ol_rx.c b/core/dp/txrx/ol_rx.c index 760500c71642..4d9dc4aac1a9 100644 --- a/core/dp/txrx/ol_rx.c +++ b/core/dp/txrx/ol_rx.c @@ -214,10 +214,8 @@ static void ol_rx_process_inv_peer(ol_txrx_pdev_handle pdev, /* ignore frames for non-existent bssids */ qdf_mem_copy(a1, wh->i_addr1, IEEE80211_ADDR_LEN); TAILQ_FOREACH(vdev, &pdev->vdev_list, vdev_list_elem) { - if (qdf_mem_cmp(a1, vdev->mac_addr.raw, IEEE80211_ADDR_LEN) - != 0) { + if (qdf_mem_cmp(a1, vdev->mac_addr.raw, IEEE80211_ADDR_LEN)) break; - } } if (!vdev) return; diff --git a/core/dp/txrx/ol_rx_fwd.c b/core/dp/txrx/ol_rx_fwd.c index 589f9d2e8e1f..65af905ee306 100644 --- a/core/dp/txrx/ol_rx_fwd.c +++ b/core/dp/txrx/ol_rx_fwd.c @@ -76,9 +76,9 @@ static inline void ol_ap_fwd_check(struct ol_txrx_vdev_t *vdev, qdf_nbuf_t msdu) if (type != IEEE80211_FC0_TYPE_DATA || subtype != 0x0 || ((tods != 1) || (fromds != 0)) || - (qdf_mem_cmp + qdf_mem_cmp (mac_header->i_addr3, vdev->mac_addr.raw, - IEEE80211_ADDR_LEN) != 0)) { + IEEE80211_ADDR_LEN)) { #ifdef DEBUG_HOST_RC TXRX_PRINT(TXRX_PRINT_LEVEL_INFO1, "Exit: %s | Unnecessary to adjust mac header\n", diff --git a/core/dp/txrx/ol_txrx.c b/core/dp/txrx/ol_txrx.c index c43ea2b82182..82c2b116b580 100644 --- a/core/dp/txrx/ol_txrx.c +++ b/core/dp/txrx/ol_txrx.c @@ -95,9 +95,9 @@ void ol_txrx_copy_mac_addr_raw(ol_txrx_vdev_handle vdev, uint8_t *bss_addr) { if (bss_addr && vdev->last_real_peer && - (qdf_mem_cmp((u8 *)bss_addr, + !qdf_mem_cmp((u8 *)bss_addr, vdev->last_real_peer->mac_addr.raw, - IEEE80211_ADDR_LEN) == 0)) + IEEE80211_ADDR_LEN)) qdf_mem_copy(vdev->hl_tdls_ap_mac_addr.raw, vdev->last_real_peer->mac_addr.raw, OL_TXRX_MAC_ADDR_LEN); @@ -2087,7 +2087,6 @@ ol_txrx_peer_attach(ol_txrx_vdev_handle vdev, uint8_t *peer_mac_addr) struct ol_txrx_peer_t *peer; struct ol_txrx_peer_t *temp_peer; uint8_t i; - int differs; bool wait_on_deletion = false; unsigned long rc; struct ol_txrx_pdev_t *pdev; @@ -2191,9 +2190,8 @@ ol_txrx_peer_attach(ol_txrx_vdev_handle vdev, uint8_t *peer_mac_addr) /* * For every peer MAp message search and set if bss_peer */ - differs = qdf_mem_cmp(peer->mac_addr.raw, vdev->mac_addr.raw, - OL_TXRX_MAC_ADDR_LEN); - if (differs) + if (qdf_mem_cmp(peer->mac_addr.raw, vdev->mac_addr.raw, + OL_TXRX_MAC_ADDR_LEN)) peer->bss_peer = 1; /* |