summaryrefslogtreecommitdiff
path: root/arch/sparc/kernel/stacktrace.c
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2019-04-15 12:52:30 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-04-27 09:34:01 +0200
commit1d149c6cfcd12d9b6be588474cfeb08a2f570da5 (patch)
tree963a91c8c522df444cb1fdc24b2bec3967b6cd27 /arch/sparc/kernel/stacktrace.c
parent32ae16ff1eaf2bdb3458c2197b31f72fc3ed3049 (diff)
staging: comedi: vmk80xx: Fix possible double-free of ->usb_rx_buf
commit 663d294b4768bfd89e529e069bffa544a830b5bf upstream. `vmk80xx_alloc_usb_buffers()` is called from `vmk80xx_auto_attach()` to allocate RX and TX buffers for USB transfers. It allocates `devpriv->usb_rx_buf` followed by `devpriv->usb_tx_buf`. If the allocation of `devpriv->usb_tx_buf` fails, it frees `devpriv->usb_rx_buf`, leaving the pointer set dangling, and returns an error. Later, `vmk80xx_detach()` will be called from the core comedi module code to clean up. `vmk80xx_detach()` also frees both `devpriv->usb_rx_buf` and `devpriv->usb_tx_buf`, but `devpriv->usb_rx_buf` may have already been freed, leading to a double-free error. Fix it by removing the call to `kfree(devpriv->usb_rx_buf)` from `vmk80xx_alloc_usb_buffers()`, relying on `vmk80xx_detach()` to free the memory. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch/sparc/kernel/stacktrace.c')
0 files changed, 0 insertions, 0 deletions