diff options
| author | Tony Lindgren <tony@atomide.com> | 2019-03-21 11:00:21 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-29 10:21:41 +0100 |
| commit | d3263a55cbec60cde2bae3ce0828f6afe25afdf1 (patch) | |
| tree | 77436145df88ae1e5c689798662e5daf62dd262e /arch/powerpc/sysdev/qe_lib/gpio.c | |
| parent | 1f4738fa3e743a3bb29d64efbb8f428b1720c145 (diff) | |
ARM: OMAP2+: Fix potentially uninitialized return value for _setup_reset()
[ Upstream commit 7f0d078667a494466991aa7133f49594f32ff6a2 ]
Commit 747834ab8347 ("ARM: OMAP2+: hwmod: revise hardreset behavior") made
the call to _enable() conditional based on no oh->rst_lines_cnt. This
caused the return value to be potentially uninitialized. Curiously we see
no compiler warnings for this, probably as this gets inlined.
We call _setup_reset() from _setup() and only _setup_postsetup() if the
return value is zero. Currently the return value can be uninitialized for
cases where oh->rst_lines_cnt is set and HWMOD_INIT_NO_RESET is not set.
Fixes: 747834ab8347 ("ARM: OMAP2+: hwmod: revise hardreset behavior")
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch/powerpc/sysdev/qe_lib/gpio.c')
0 files changed, 0 insertions, 0 deletions
