diff options
| author | Tushnim Bhattacharyya <tushnimb@qca.qualcomm.com> | 2014-01-15 14:13:27 -0800 |
|---|---|---|
| committer | Prakash Dhavali <pdhavali@qca.qualcomm.com> | 2014-01-26 20:06:34 -0800 |
| commit | ff5e5c77784d5fc531ae1d3ccfd657293763a751 (patch) | |
| tree | ec7726a3744a57b7de751aa18e0929e5ef2a119b | |
| parent | 441209eff76de64ef4e958dd138d4098bbf283b6 (diff) | |
wlan: Fix issues found in static analysis on BAP.
Some of the VOSS pkt utility functions are made NOP for QCA_WIFI_2_0.
But they do return success. Due to this some of the stack variables
in BAP module remained uninitialized but used. Fixed the uninitialized
stack variables
Change-Id: If57eacf0742de963e55ca3053d46ec30d0ad3b5a
CRs-Fixed: 600779
| -rw-r--r-- | CORE/BAP/src/bapApiData.c | 2 | ||||
| -rw-r--r-- | CORE/BAP/src/bapApiLinkSupervision.c | 2 | ||||
| -rw-r--r-- | CORE/BAP/src/bapRsnSsmEapol.c | 4 | ||||
| -rw-r--r-- | CORE/BAP/src/bapRsnTxRx.c | 6 |
4 files changed, 7 insertions, 7 deletions
diff --git a/CORE/BAP/src/bapApiData.c b/CORE/BAP/src/bapApiData.c index 37c3d49b3686..fcba460ded3f 100644 --- a/CORE/BAP/src/bapApiData.c +++ b/CORE/BAP/src/bapApiData.c @@ -303,7 +303,7 @@ WLANBAP_XlateTxDataPkt ptBtampContext pBtampCtx = (ptBtampContext) btampHandle; tpBtampLogLinkCtx pLogLinkContext; WLANBAP_8023HeaderType w8023Header; - WLANBAP_HCIACLHeaderType hciACLHeader; + WLANBAP_HCIACLHeaderType hciACLHeader = { 0 }; v_U8_t aucLLCHeader[WLANBAP_LLC_HEADER_LEN]; VOS_STATUS vosStatus; v_U8_t ucSTAId; /* The StaId (used by TL, PE, and HAL) */ diff --git a/CORE/BAP/src/bapApiLinkSupervision.c b/CORE/BAP/src/bapApiLinkSupervision.c index 1973cd46a9e0..abc19db19512 100644 --- a/CORE/BAP/src/bapApiLinkSupervision.c +++ b/CORE/BAP/src/bapApiLinkSupervision.c @@ -106,7 +106,7 @@ VOS_STATUS WLANBAP_AcquireLSPacket( ptBtampContext pBtampCtx, vos_pkt_t **ppPacket, v_U16_t size, tANI_BOOLEAN isLsReq ) { VOS_STATUS vosStatus; - vos_pkt_t *pPacket; + vos_pkt_t *pPacket = NULL; WLANBAP_8023HeaderType w8023Header; v_U8_t aucLLCHeader[WLANBAP_LLC_HEADER_LEN]; v_U16_t headerLength; /* The 802.3 frame length*/ diff --git a/CORE/BAP/src/bapRsnSsmEapol.c b/CORE/BAP/src/bapRsnSsmEapol.c index 14f2f93a9c79..f534556007ee 100644 --- a/CORE/BAP/src/bapRsnSsmEapol.c +++ b/CORE/BAP/src/bapRsnSsmEapol.c @@ -1067,7 +1067,7 @@ int bapRsnFormPktFromVosPkt( tAniPacket **ppPacket, vos_pkt_t *pVosPacket ) v_U16_t uPktLen; #define BAP_RSN_SNAP_TYPE_OFFSET 20 #define BAP_RSN_ETHERNET_3_HEADER_LEN 22 - v_U8_t *pFrame; + v_U8_t *pFrame = NULL; tAniPacket *pAniPacket = NULL; do @@ -1082,7 +1082,7 @@ int bapRsnFormPktFromVosPkt( tAniPacket **ppPacket, vos_pkt_t *pVosPacket ) break; } status = vos_pkt_peek_data( pVosPacket, 0, (v_VOID_t *)&pFrame, uPktLen ); - if( !VOS_IS_STATUS_SUCCESS(status) ) break; + if( !VOS_IS_STATUS_SUCCESS(status) || (NULL == pFrame) ) break; retVal = aniAsfPacketAllocateExplicit(&pAniPacket, uPktLen, 0 ); if( !ANI_IS_STATUS_SUCCESS( retVal ) ) { diff --git a/CORE/BAP/src/bapRsnTxRx.c b/CORE/BAP/src/bapRsnTxRx.c index d56bae34f707..61f9da829947 100644 --- a/CORE/BAP/src/bapRsnTxRx.c +++ b/CORE/BAP/src/bapRsnTxRx.c @@ -26,7 +26,7 @@ */ /**============================================================================= - vos_list.c + bapRsnTxRx.c \brief @@ -73,7 +73,7 @@ void bapRsnClearTxRxCallbacks(void) static VOS_STATUS bapRsnAcquirePacket( vos_pkt_t **ppPacket, v_U8_t **ppData, v_U16_t size ) { VOS_STATUS status; - vos_pkt_t *pPacket; + vos_pkt_t *pPacket = NULL; status = vos_pkt_get_packet( &pPacket, VOS_PKT_TYPE_TX_802_11_MGMT, size, 1, VOS_TRUE, NULL, NULL ); @@ -204,7 +204,7 @@ VOS_STATUS bapRsnSendEapolFrame( v_PVOID_t pvosGCtx, tAniPacket *pAniPkt ) { VOS_STATUS status; vos_pkt_t *pPacket = NULL; - v_U8_t *pData, *pSrc; + v_U8_t *pData = NULL, *pSrc = NULL; int pktLen = aniAsfPacketGetBytes( pAniPkt, &pSrc ); if( pktLen <= 0 ) |