diff options
| author | Frank Liu <qiliu@codeaurora.org> | 2017-06-26 15:51:12 +0800 |
|---|---|---|
| committer | snandini <snandini@codeaurora.org> | 2017-07-11 03:46:08 -0700 |
| commit | ff0e9956d8164f8bd440ffa092f8680ea0b65364 (patch) | |
| tree | 898bae637286b13789f640774cf9aec4dcd86765 | |
| parent | 032c78df51c3681f235fdbb7e27fe2dc5a73b778 (diff) | |
qcacmn: fix start modules fail on sdio card
When open sdio bus, "probed" will be checked and increased, but it's not
decreased in close sdio bus, so if driver goes through hdd_wlan_startup ->
hdd_wlan_stop_modules -> __hdd_open process, it will fail to open the sdio
bus and to bring up the interface.
The fix is to remove the static variable, since the check is trivial for
two reason:
1. driver control flow guarantee no re-enter;
2. if re-enter happen, it is no harm.
Change-Id: Ie701fb44732600440aa70ff28f62fe766d4271e7
CRs-Fixed: 2066582
| -rw-r--r-- | hif/src/sdio/if_sdio.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/hif/src/sdio/if_sdio.c b/hif/src/sdio/if_sdio.c index a27dd85a60d3..57bc70e813b4 100644 --- a/hif/src/sdio/if_sdio.c +++ b/hif/src/sdio/if_sdio.c @@ -295,7 +295,6 @@ static char *dev_info = "ath_hif_sdio"; */ static int init_ath_hif_sdio(void) { - static int probed; QDF_STATUS status; struct osdrv_callbacks osdrv_callbacks; @@ -307,10 +306,6 @@ static int init_ath_hif_sdio(void) osdrv_callbacks.device_resume_handler = hif_sdio_resume; osdrv_callbacks.device_power_change_handler = hif_sdio_power_change; - if (probed) - return -ENODEV; - probed++; - QDF_TRACE(QDF_MODULE_ID_HIF, QDF_TRACE_LEVEL_INFO, "%s %d", __func__, __LINE__); status = hif_init(&osdrv_callbacks); |