diff options
| author | Srinivas Girigowda <sgirigow@qca.qualcomm.com> | 2015-07-07 13:29:43 -0700 |
|---|---|---|
| committer | Anjaneedevi Kapparapu <akappa@codeaurora.org> | 2015-07-10 20:33:30 +0530 |
| commit | f5e901a98d2d8ed65a33db469e5304cf0d1f44e4 (patch) | |
| tree | 776cba02b25a0a80085926ec5726c39ef4d401c2 | |
| parent | 952ee96bc63d0cbe0867c56d94a066e5ec99a510 (diff) | |
qcacld-2.0: Fix buffer overwrite problem in GETSCANCHANNELTIME
If (len + 1) is greater than priv_data.total_len then copy_to_user
results in writing more data than the buffer can hold.
Fix this by writing mininum of (len + 1) and priv_data.total_len.
Change-Id: I9b4e118a8e145efe2f54b87f46030e874de67750
CRs-Fixed: 865556
| -rwxr-xr-x | CORE/HDD/src/wlan_hdd_main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/CORE/HDD/src/wlan_hdd_main.c b/CORE/HDD/src/wlan_hdd_main.c index 42ae91e3d283..c8177183a4ad 100755 --- a/CORE/HDD/src/wlan_hdd_main.c +++ b/CORE/HDD/src/wlan_hdd_main.c @@ -4689,8 +4689,8 @@ static int hdd_driver_command(hdd_adapter_t *pAdapter, /* value is interms of msec */ len = scnprintf(extra, sizeof(extra), "%s %d", "GETSCANCHANNELTIME", val); - if (copy_to_user(priv_data.buf, &extra, len + 1)) - { + len = VOS_MIN(priv_data.total_len, len + 1); + if (copy_to_user(priv_data.buf, &extra, len)) { VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR, "%s: failed to copy data to user buffer", __func__); ret = -EFAULT; |