diff options
| author | Roman Kiryanov <rkir@google.com> | 2018-03-20 13:40:04 -0700 |
|---|---|---|
| committer | Roman Kiryanov <rkir@google.com> | 2018-05-01 11:47:38 -0700 |
| commit | ec6875b2de0551078ae83f04917624aca20c67ff (patch) | |
| tree | 458c9ce87350134d8419ce74517370b0e0563e16 | |
| parent | 12ef385f51fecec81b6a690da98d9ee5bb96e887 (diff) | |
goldfish: pipe: ANDROID: fix logging format strings
* remove '%p' to avoid exposing kernel addresses;
* add missing '\n'.
Bug: 72717639
Bug: 66884503
Change-Id: I81357841dc334df595a3244f232c2e6bb72e64a1
Signed-off-by: Roman Kiryanov <rkir@google.com>
| -rw-r--r-- | drivers/platform/goldfish/goldfish_pipe_v2.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/platform/goldfish/goldfish_pipe_v2.c b/drivers/platform/goldfish/goldfish_pipe_v2.c index 3119b3341a7b..aa794a6fcee7 100644 --- a/drivers/platform/goldfish/goldfish_pipe_v2.c +++ b/drivers/platform/goldfish/goldfish_pipe_v2.c @@ -721,12 +721,11 @@ static int goldfish_pipe_open(struct inode *inode, struct file *file) status = goldfish_cmd_locked(pipe, PIPE_CMD_OPEN); spin_unlock_irqrestore(&dev->lock, flags); if (status < 0) { - pr_err("Could not tell host of new pipe! status=%d", status); + pr_err("Could not tell host of new pipe! status=%d\n", status); goto err_cmd; } /* All is done, save the pipe into the file's private data field */ file->private_data = pipe; - pr_debug("%s on 0x%p\n", __func__, pipe); return 0; err_cmd: @@ -746,8 +745,6 @@ static int goldfish_pipe_release(struct inode *inode, struct file *filp) struct goldfish_pipe *pipe = filp->private_data; struct goldfish_pipe_dev *dev = pipe->dev; - pr_debug("%s on 0x%p\n", __func__, pipe); - /* The guest is closing the channel, so tell the emulator right now */ (void)goldfish_cmd(pipe, PIPE_CMD_CLOSE); |