summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAbhishek Singh <absingh@qti.qualcomm.com>2014-03-30 15:19:17 -0700
committerPitani Venkata Rajesh Kumar <c_vpitan@qti.qualcomm.com>2014-04-15 02:06:26 +0530
commite600eb22168f8fbfbafb183f818439f728fb09dd (patch)
tree07536809abb03b1aa11d7c630cf430b1c57578a9
parenta5782a14ec6f2fa17eba3a360a89963fa8739619 (diff)
wlan: Fix null pointer references found in static analysis.
Fixed potential null pointer references and memory leaks find by static code analysis. Change-Id: I4b7e417e4347de48befdeef29211cccb3c7ede4c CRs-Fixed: 594219
-rw-r--r--CORE/HDD/src/wlan_hdd_cfg80211.c2
-rw-r--r--CORE/SME/src/csr/csrApiRoam.c2
-rw-r--r--CORE/WDA/src/wlan_qct_wda.c4
3 files changed, 4 insertions, 4 deletions
diff --git a/CORE/HDD/src/wlan_hdd_cfg80211.c b/CORE/HDD/src/wlan_hdd_cfg80211.c
index 499aeb447f20..96948c261589 100644
--- a/CORE/HDD/src/wlan_hdd_cfg80211.c
+++ b/CORE/HDD/src/wlan_hdd_cfg80211.c
@@ -4679,7 +4679,7 @@ wlan_hdd_cfg80211_inform_bss_frame( hdd_adapter_t *pAdapter,
((ie_length != 0) ? (const char *)&bss_desc->ieFields: NULL);
unsigned int freq;
struct ieee80211_channel *chan;
- struct ieee80211_mgmt *mgmt;
+ struct ieee80211_mgmt *mgmt = NULL;
struct cfg80211_bss *bss_status = NULL;
size_t frame_len = sizeof (struct ieee80211_mgmt) + ie_length;
int rssi = 0;
diff --git a/CORE/SME/src/csr/csrApiRoam.c b/CORE/SME/src/csr/csrApiRoam.c
index 00dc9b2e8d9a..a2724726a892 100644
--- a/CORE/SME/src/csr/csrApiRoam.c
+++ b/CORE/SME/src/csr/csrApiRoam.c
@@ -12203,7 +12203,7 @@ eHalStatus csrRoamDelPMKIDfromCache( tpAniSirGlobal pMac, tANI_U32 sessionId,
}
}
if( !fMatchFound ) break;
- vos_mem_set(pSession->PmkidCacheInfo[Index].BSSID, sizeof(tPmkidCacheInfo), 0);
+ vos_mem_set(pSession->PmkidCacheInfo[Index].BSSID, sizeof(tCsrBssid), 0);
status = eHAL_STATUS_SUCCESS;
}
while( 0 );
diff --git a/CORE/WDA/src/wlan_qct_wda.c b/CORE/WDA/src/wlan_qct_wda.c
index f8d86b0fe8fe..ee49881a4894 100644
--- a/CORE/WDA/src/wlan_qct_wda.c
+++ b/CORE/WDA/src/wlan_qct_wda.c
@@ -5255,10 +5255,10 @@ VOS_STATUS WDA_ProcessGetRoamRssiReq(tWDA_CbContext *pWDA,
VOS_TRACE( VOS_MODULE_ID_WDA, VOS_TRACE_LEVEL_ERROR,
"%s: VOS MEM Alloc Failure", __func__);
VOS_ASSERT(0);
+ vos_mem_free(pGetRoamRssiParams);
+ vos_mem_free(pWdaParams);
return VOS_STATUS_E_NOMEM;
}
- vos_mem_free(pGetRoamRssiParams);
- vos_mem_free(pWdaParams);
pGetRoamRssiRspParams->staId = pGetRoamRssiParams->staId;
pGetRoamRssiRspParams->rc = eSIR_FAILURE;
pGetRoamRssiRspParams->rssi = 0;