summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>2016-06-24 14:50:24 -0700
committerPrakash Gupta <guptap@codeaurora.org>2017-07-07 15:39:33 +0530
commitd2d3c7bc7e5376b49d63b01017ede95b7657b9fa (patch)
treed9b5a21525bce6d4621324da11fc1fe2635a1473
parentacda305dcb5474a401753912db382358b3436ab9 (diff)
mm/page_owner: avoid null pointer dereference
We have dereferenced page_ext before checking it. Lets check it first and then used it. Change-Id: I9184110069df51ddcf6eb699cb6ed2320fa09ab0 Fixes: f86e4271978b ("mm: check the return value of lookup_page_ext for all call sites") Link: http://lkml.kernel.org/r/1465249059-7883-1-git-send-email-sudipm.mukherjee@gmail.com Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Acked-by: Vlastimil Babka <vbabka@suse.cz> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Git-commit: 8285027fc479949a7a166bc1b26ce57e894878a7 Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Signed-off-by: Prakash Gupta <guptap@codeaurora.org>
-rw-r--r--mm/page_owner.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/mm/page_owner.c b/mm/page_owner.c
index 70f9595e06c0..eea25c7eb34b 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -215,13 +215,15 @@ void __dump_page_owner(struct page *page)
.nr_entries = page_ext->nr_entries,
.entries = &page_ext->trace_entries[0],
};
- gfp_t gfp_mask = page_ext->gfp_mask;
- int mt = gfpflags_to_migratetype(gfp_mask);
+ gfp_t gfp_mask;
+ int mt;
if (unlikely(!page_ext)) {
pr_alert("There is not page extension available.\n");
return;
}
+ gfp_mask = page_ext->gfp_mask;
+ mt = gfpflags_to_migratetype(gfp_mask);
if (!test_bit(PAGE_EXT_OWNER, &page_ext->flags)) {
pr_alert("page_owner info is not active (free page?)\n");