summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDustin Brown <dustinb@codeaurora.org>2017-01-18 12:25:50 -0800
committerqcabuildsw <qcabuildsw@localhost>2017-01-20 06:18:20 -0800
commitd0857c075c5426e446b16a69da3fcf178a45ac04 (patch)
treec62bccfaa4e91a15a90d80d17112bb3e38910811
parentae5c83897908da331c0bcb5e6e1bfacdbeb647ad (diff)
qcacld-3.0: Fix bandwidth timer restart condition
A previous change introduced a regression that prevents the bandwidth timer from restarting correctly. Fix said regression by inverting the conditional at the end of the timer callback. Change-Id: I84db7df6af55dccd447ba04a32aeada27e7a6f3b CRs-Fixed: 1112498
-rw-r--r--core/hdd/src/wlan_hdd_main.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/core/hdd/src/wlan_hdd_main.c b/core/hdd/src/wlan_hdd_main.c
index c03c3a46c530..e1e512491a79 100644
--- a/core/hdd/src/wlan_hdd_main.c
+++ b/core/hdd/src/wlan_hdd_main.c
@@ -5507,13 +5507,11 @@ static void hdd_bus_bw_work_handler(struct work_struct *work)
hdd_ipa_set_perf_level(hdd_ctx, tx_packets, rx_packets);
hdd_ipa_uc_stat_request(adapter, 2);
- /* restart the periodic timer */
+ /* ensure periodic timer should still be running before restarting it */
qdf_spinlock_acquire(&hdd_ctx->bus_bw_timer_lock);
- if (!hdd_ctx->bus_bw_timer_running) {
- hdd_ctx->bus_bw_timer_running = true;
+ if (hdd_ctx->bus_bw_timer_running)
qdf_timer_start(&hdd_ctx->bus_bw_timer,
hdd_ctx->config->busBandwidthComputeInterval);
- }
qdf_spinlock_release(&hdd_ctx->bus_bw_timer_lock);
}