summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorc_hpothu <c_hpothu@qti.qualcomm.com>2014-03-31 01:35:31 -0700
committerAkash Patel <c_akashp@qca.qualcomm.com>2014-04-17 16:45:55 -0700
commitd01013f1bcca47abb0ea36b1696456d3eb802cb2 (patch)
tree158f469e97e2515f33dd251ee46bfac27c55a40c
parentb76a99192adc00ff78028b342a497dd5aed02b22 (diff)
wlan: HDD layer logging enhancement phase-2.
Added logs which should get printed when some unexpected error happens.In this change, updaing wlan_hdd_early_suspend.c, wlan_hdd_ftm.c and wlan_hdd_hostapd.c files. Change-Id: I714b1c605d833f6bf7f2749cc13533dcd6b872b7 CRs-Fixed: 640951
-rw-r--r--CORE/HDD/src/wlan_hdd_early_suspend.c114
-rw-r--r--CORE/HDD/src/wlan_hdd_ftm.c251
-rw-r--r--CORE/HDD/src/wlan_hdd_hostapd.c72
3 files changed, 337 insertions, 100 deletions
diff --git a/CORE/HDD/src/wlan_hdd_early_suspend.c b/CORE/HDD/src/wlan_hdd_early_suspend.c
index 9cb9f39b1afc..2d458449be60 100644
--- a/CORE/HDD/src/wlan_hdd_early_suspend.c
+++ b/CORE/HDD/src/wlan_hdd_early_suspend.c
@@ -163,6 +163,7 @@ void hdd_suspend_full_pwr_callback(void *callbackContext, eHalStatus status)
eHalStatus hdd_exit_standby(hdd_context_t *pHddCtx)
{
eHalStatus status = VOS_STATUS_SUCCESS;
+ long ret;
hddLog(VOS_TRACE_LEVEL_INFO, "%s: WLAN being resumed from standby",__func__);
INIT_COMPLETION(pHddCtx->full_pwr_comp_var);
@@ -174,8 +175,14 @@ eHalStatus hdd_exit_standby(hdd_context_t *pHddCtx)
if(status == eHAL_STATUS_PMC_PENDING)
{
//Block on a completion variable. Can't wait forever though
- wait_for_completion_interruptible_timeout(&pHddCtx->full_pwr_comp_var,
- msecs_to_jiffies(WLAN_WAIT_TIME_FULL_PWR));
+ ret = wait_for_completion_interruptible_timeout(
+ &pHddCtx->full_pwr_comp_var,
+ msecs_to_jiffies(WLAN_WAIT_TIME_FULL_PWR));
+ if (0 >= ret)
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR,
+ FL("wait on full_pwr_comp_var failed %ld"), ret);
+ }
status = g_full_pwr_status;
if(g_full_pwr_status != eHAL_STATUS_SUCCESS)
{
@@ -206,6 +213,7 @@ VOS_STATUS hdd_enter_standby(hdd_context_t *pHddCtx)
{
eHalStatus halStatus = eHAL_STATUS_SUCCESS;
VOS_STATUS vosStatus = VOS_STATUS_SUCCESS;
+ long ret;
//Disable IMPS/BMPS as we do not want the device to enter any power
//save mode on its own during suspend sequence
@@ -228,8 +236,15 @@ VOS_STATUS hdd_enter_standby(hdd_context_t *pHddCtx)
if(halStatus == eHAL_STATUS_PMC_PENDING)
{
//Block on a completion variable. Can't wait forever though
- wait_for_completion_interruptible_timeout(&pHddCtx->full_pwr_comp_var,
- msecs_to_jiffies(WLAN_WAIT_TIME_FULL_PWR));
+ ret = wait_for_completion_interruptible_timeout(
+ &pHddCtx->full_pwr_comp_var,
+ msecs_to_jiffies(WLAN_WAIT_TIME_FULL_PWR));
+ if (0 >= ret)
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR,
+ FL( "wait on full_pwr_comp_var failed %ld"), ret);
+ }
+
if(g_full_pwr_status != eHAL_STATUS_SUCCESS)
{
hddLog(VOS_TRACE_LEVEL_FATAL,"%s: sme_RequestFullPower Failed",__func__);
@@ -264,8 +279,14 @@ VOS_STATUS hdd_enter_standby(hdd_context_t *pHddCtx)
if (halStatus == eHAL_STATUS_PMC_PENDING)
{
//Wait till WLAN device enters standby mode
- wait_for_completion_timeout(&pHddCtx->standby_comp_var,
+ ret = wait_for_completion_timeout(&pHddCtx->standby_comp_var,
msecs_to_jiffies(WLAN_WAIT_TIME_STANDBY));
+ if (0 >= ret)
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR,
+ FL("wait on standby_comp_var failed %ld"), ret);
+ }
+
if (g_standby_status != eHAL_STATUS_SUCCESS && g_standby_status != eHAL_STATUS_PMC_NOT_NOW)
{
hddLog(VOS_TRACE_LEVEL_FATAL,"%s: sme_RequestStandby failed",__func__);
@@ -303,6 +324,7 @@ VOS_STATUS hdd_enter_deep_sleep(hdd_context_t *pHddCtx, hdd_adapter_t *pAdapter)
eHalStatus halStatus;
VOS_STATUS vosStatus = VOS_STATUS_SUCCESS;
vos_call_status_type callType;
+ long ret;
//Stop the Interface TX queue.
netif_tx_disable(pAdapter->dev);
@@ -322,8 +344,15 @@ VOS_STATUS hdd_enter_deep_sleep(hdd_context_t *pHddCtx, hdd_adapter_t *pAdapter)
if(halStatus == eHAL_STATUS_PMC_PENDING)
{
//Block on a completion variable. Can't wait forever though
- wait_for_completion_interruptible_timeout(&pHddCtx->full_pwr_comp_var,
- msecs_to_jiffies(WLAN_WAIT_TIME_FULL_PWR));
+ ret = wait_for_completion_interruptible_timeout(
+ &pHddCtx->full_pwr_comp_var,
+ msecs_to_jiffies(WLAN_WAIT_TIME_FULL_PWR));
+ if (0 >= ret)
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR,
+ FL("wait on full_pwr_comp_var failed %ld"), ret);
+ }
+
if(g_full_pwr_status != eHAL_STATUS_SUCCESS){
hddLog(VOS_TRACE_LEVEL_FATAL,"%s: sme_RequestFullPower failed",__func__);
VOS_ASSERT(0);
@@ -344,21 +373,40 @@ VOS_STATUS hdd_enter_deep_sleep(hdd_context_t *pHddCtx, hdd_adapter_t *pAdapter)
if(halStatus == eHAL_STATUS_SUCCESS)
{
//Block on a completion variable. Can't wait forever though.
- wait_for_completion_interruptible_timeout(&pAdapter->disconnect_comp_var,
- msecs_to_jiffies(WLAN_WAIT_TIME_DISCONNECT));
+ ret = wait_for_completion_interruptible_timeout(
+ &pAdapter->disconnect_comp_var,
+ msecs_to_jiffies(WLAN_WAIT_TIME_DISCONNECT));
+ if (0 >= ret)
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR,
+ FL("wait on disconnect_comp_var failed %ld"), ret);
+ }
}
-
-
//None of the steps should fail after this. Continue even in case of failure
vosStatus = vos_stop( pHddCtx->pvosContext );
- VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
+ if (!VOS_IS_STATUS_SUCCESS( vosStatus ))
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR, "%s: vos_stop return failed %d",
+ __func__, vosStatus);
+ VOS_ASSERT(0);
+ }
vosStatus = vos_chipAssertDeepSleep( &callType, NULL, NULL );
- VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
+ if( VOS_IS_STATUS_SUCCESS( vosStatus ))
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR,
+ FL("vos_chipAssertDeepSleep return failed %d"), vosStatus);
+ VOS_ASSERT(0);
+ }
//Vote off any PMIC voltage supplies
vosStatus = vos_chipPowerDown(NULL, NULL, NULL);
-
+ if( !VOS_IS_STATUS_SUCCESS( vosStatus ))
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR, "%s: vos_chipPowerDown return failed %d",
+ __func__, vosStatus);
+ VOS_ASSERT(0);
+ }
pHddCtx->hdd_ps_state = eHDD_SUSPEND_DEEP_SLEEP;
//Restore IMPS config
@@ -382,8 +430,8 @@ VOS_STATUS hdd_exit_deep_sleep(hdd_context_t *pHddCtx, hdd_adapter_t *pAdapter)
vosStatus = vos_chipPowerUp(NULL,NULL,NULL);
if (!VOS_IS_STATUS_SUCCESS(vosStatus))
{
- hddLog(VOS_TRACE_LEVEL_FATAL, "%s: Libra WLAN not Powered Up. "
- "exiting", __func__);
+ hddLog(VOS_TRACE_LEVEL_FATAL, "%s: WLAN not Powered Up.exiting",
+ __func__);
goto err_deep_sleep;
}
@@ -1149,6 +1197,9 @@ static void hdd_conf_suspend_ind(hdd_context_t* pHddCtx,
{
pHddCtx->hdd_mcastbcast_filter_set = TRUE;
} else {
+ hddLog(VOS_TRACE_LEVEL_ERROR,
+ FL("sme_ConfigureSuspendInd returned failure %d"), halStatus);
+
vos_mem_free(wlanSuspendParam);
}
}
@@ -1179,6 +1230,9 @@ static void hdd_conf_resume_ind(hdd_adapter_t *pAdapter)
halStatus = sme_ConfigureResumeReq(pHddCtx->hHal, wlanResumeParam);
if (eHAL_STATUS_SUCCESS != halStatus)
{
+ hddLog(VOS_TRACE_LEVEL_ERROR,
+ "%s: sme_ConfigureResumeReq return failure %d",
+ __func__, halStatus);
vos_mem_free(wlanResumeParam);
}
@@ -1874,7 +1928,12 @@ VOS_STATUS hdd_wlan_shutdown(void)
}
#else
vosStatus = vos_wda_shutdown(pVosContext);
- VOS_ASSERT(VOS_IS_STATUS_SUCCESS(vosStatus));
+ if (!VOS_IS_STATUS_SUCCESS(vosStatus))
+ {
+ VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failed to stop wda %d", __func__, vosStatus);
+ VOS_ASSERT(0);
+ }
#endif
hddLog(VOS_TRACE_LEVEL_FATAL, "%s: Doing SME STOP",__func__);
@@ -1882,17 +1941,32 @@ VOS_STATUS hdd_wlan_shutdown(void)
* on threads being running to process the SYS Stop
*/
vosStatus = sme_Stop(pHddCtx->hHal, HAL_STOP_TYPE_SYS_RESET);
- VOS_ASSERT(VOS_IS_STATUS_SUCCESS(vosStatus));
+ if (!VOS_IS_STATUS_SUCCESS(vosStatus))
+ {
+ VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failed to stop sme %d", __func__, vosStatus);
+ VOS_ASSERT(0);
+ }
hddLog(VOS_TRACE_LEVEL_FATAL, "%s: Doing MAC STOP",__func__);
/* Stop MAC (PE and HAL) */
vosStatus = macStop(pHddCtx->hHal, HAL_STOP_TYPE_SYS_RESET);
- VOS_ASSERT(VOS_IS_STATUS_SUCCESS(vosStatus));
+ if (!VOS_IS_STATUS_SUCCESS(vosStatus))
+ {
+ VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failed to stop mac %d", __func__, vosStatus);
+ VOS_ASSERT(0);
+ }
hddLog(VOS_TRACE_LEVEL_FATAL, "%s: Doing TL STOP",__func__);
/* Stop TL */
vosStatus = WLANTL_Stop(pVosContext);
- VOS_ASSERT(VOS_IS_STATUS_SUCCESS(vosStatus));
+ if (!VOS_IS_STATUS_SUCCESS(vosStatus))
+ {
+ VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failed to stop TL %d", __func__, vosStatus);
+ VOS_ASSERT(0);
+ }
#ifndef QCA_WIFI_ISOC
hif_disable_isr(((VosContextType*)pVosContext)->pHIFContext);
diff --git a/CORE/HDD/src/wlan_hdd_ftm.c b/CORE/HDD/src/wlan_hdd_ftm.c
index d8be6322aee0..031db81f5e2f 100644
--- a/CORE/HDD/src/wlan_hdd_ftm.c
+++ b/CORE/HDD/src/wlan_hdd_ftm.c
@@ -670,7 +670,8 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
/* Critical Error ... Cannot proceed further */
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to initialize VOS free message queue",__func__);
+ "%s: Failed to initialize VOS free message queue %d",
+ __func__, vStatus);
VOS_ASSERT(0);
goto err_wda_complete_event;
}
@@ -691,7 +692,7 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
{
/* Critical Error ... Cannot proceed further */
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to open VOS Scheduler", __func__);
+ "%s: Failed to open VOS Scheduler %d", __func__, vStatus);
VOS_ASSERT(0);
goto err_msg_queue;
}
@@ -745,7 +746,7 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
{
/* Critical Error ... Cannot proceed further */
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to open SYS module",__func__);
+ "%s: Failed to open SYS module %d", __func__, vStatus);
VOS_ASSERT(0);
goto err_sched_close;
}
@@ -759,7 +760,7 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
(NULL == pHddCtx->cfg_ini))
{
/* Critical Error ... Cannot proceed further */
- VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
"%s: Hdd Context is Null", __func__);
VOS_ASSERT(0);
goto err_sys_close;
@@ -779,7 +780,7 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
{
/* Critical Error ... Cannot proceed further */
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to open WDA module",__func__);
+ "%s: Failed to open WDA module %d", __func__, vStatus);
VOS_ASSERT(0);
goto err_sys_close;
}
@@ -807,7 +808,7 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
// NV module cannot be initialized, however the driver is allowed
// to proceed
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to initialize the NV module", __func__);
+ "%s: Failed to initialize the NV module %d", __func__, vStatus);
goto err_wda_close;
}
@@ -816,7 +817,8 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
if (!VOS_IS_STATUS_SUCCESS(vStatus))
{
VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s : failed to get dictionary data for NV", __func__);
+ "%s : failed to get dictionary data for NV %d",
+ __func__, vStatus);
goto err_wda_close;
}
@@ -835,7 +837,7 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
{
/* Critical Error ... Cannot proceed further */
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to open MAC", __func__);
+ "%s: Failed to open MAC %d", __func__, sirStatus);
VOS_ASSERT(0);
goto err_nv_close;
}
@@ -847,7 +849,7 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex
{
/* Critical Error ... Cannot proceed further */
VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to open SME",__func__);
+ "%s: Failed to open SME %d", __func__, vStatus);
goto err_mac_close;
}
@@ -930,7 +932,7 @@ static VOS_STATUS wlan_ftm_vos_close( v_CONTEXT_t vosContext )
if (!VOS_IS_STATUS_SUCCESS(vosStatus))
{
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to close BAL",__func__);
+ "%s: Failed to close SME %d", __func__, vosStatus);
VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
}
#endif
@@ -939,7 +941,7 @@ static VOS_STATUS wlan_ftm_vos_close( v_CONTEXT_t vosContext )
if (!VOS_IS_STATUS_SUCCESS(vosStatus))
{
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to close MAC",__func__);
+ "%s: Failed to close MAC %d", __func__, vosStatus);
VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
}
@@ -949,7 +951,7 @@ static VOS_STATUS wlan_ftm_vos_close( v_CONTEXT_t vosContext )
if (!VOS_IS_STATUS_SUCCESS(vosStatus))
{
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to close NV",__func__);
+ "%s: Failed to close NV %d", __func__, vosStatus);
VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
}
@@ -958,7 +960,7 @@ static VOS_STATUS wlan_ftm_vos_close( v_CONTEXT_t vosContext )
if (!VOS_IS_STATUS_SUCCESS(vosStatus))
{
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to close SYS",__func__);
+ "%s: Failed to close SYS %d", __func__, vosStatus);
VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
}
@@ -966,7 +968,7 @@ static VOS_STATUS wlan_ftm_vos_close( v_CONTEXT_t vosContext )
if (!VOS_IS_STATUS_SUCCESS(vosStatus))
{
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to close WDA",__func__);
+ "%s: Failed to close WDA %d", __func__, vosStatus);
VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
}
@@ -986,7 +988,7 @@ static VOS_STATUS wlan_ftm_vos_close( v_CONTEXT_t vosContext )
if (!VOS_IS_STATUS_SUCCESS(vosStatus))
{
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to destroy ProbeEvent",__func__);
+ "%s: Failed to destroy ProbeEvent %d", __func__, vosStatus);
VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
}
@@ -994,7 +996,7 @@ static VOS_STATUS wlan_ftm_vos_close( v_CONTEXT_t vosContext )
if (!VOS_IS_STATUS_SUCCESS(vosStatus))
{
VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
- "%s: Failed to destroy wdaCompleteEvent",__func__);
+ "%s: Failed to destroy wdaCompleteEvent %d", __func__, vosStatus);
VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
}
@@ -1034,7 +1036,8 @@ static VOS_STATUS wlan_ftm_priv_set_txifs(hdd_adapter_t *pAdapter,v_U32_t ifs)
if (ifs > 100000) //max = (MSK_24 / ONE_MICROSECOND)
{
- VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL, "%s:ifs value is invalid ",__func__);
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
+ "%s:ifs value is invalid %x", __func__, ifs);
return VOS_STATUS_E_FAILURE;
}
@@ -1074,7 +1077,8 @@ static VOS_STATUS wlan_ftm_priv_set_txpktcnt(hdd_adapter_t *pAdapter,v_U32_t cnt
if (cnt > QWLAN_PHYDBG_TXPKT_CNT_CNT_MASK) //0xFFFF
{
- VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL, "%s:pktcnt value is invalid",__func__);
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
+ "%s:pktcnt value is invalid %08x", __func__, cnt);
return VOS_STATUS_E_FAILURE;
}
@@ -1101,7 +1105,8 @@ static VOS_STATUS wlan_ftm_priv_set_txpktlen(hdd_adapter_t *pAdapter,v_U32_t len
if (len > 4095) //4096
{
- VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL, "%s:payload len is invalid",__func__);
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
+ "%s:payload len is invalid %08x", __func__, len);
return VOS_STATUS_E_FAILURE;
}
@@ -1117,6 +1122,7 @@ static VOS_STATUS wlan_ftm_priv_enable_chain(hdd_adapter_t *pAdapter,v_U16_t cha
VOS_STATUS status;
v_U16_t chainSelect_save = chainSelect;
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
+ long ret;
if(pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
{
@@ -1126,7 +1132,8 @@ static VOS_STATUS wlan_ftm_priv_enable_chain(hdd_adapter_t *pAdapter,v_U16_t cha
if (chainSelect > FTM_CHAIN_SEL_MAX)
{
- VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL, "%s:Invalid chain",__func__);
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
+ "%s:Invalid chain %08x", __func__, chainSelect);
return VOS_STATUS_E_FAILURE;
}
@@ -1169,8 +1176,13 @@ static VOS_STATUS wlan_ftm_priv_enable_chain(hdd_adapter_t *pAdapter,v_U16_t cha
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret)
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -1225,6 +1237,8 @@ static VOS_STATUS wlan_ftm_priv_get_status(hdd_adapter_t *pAdapter,char *buf)
ftm_status.frameParams.interFrameSpace);
if ((lenRes < 0) || (lenRes >= lenBuf))
{
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("failed to copy data into buf %d"), lenRes);
return VOS_STATUS_E_FAILURE;
}
@@ -1247,6 +1261,8 @@ static VOS_STATUS wlan_ftm_priv_get_status(hdd_adapter_t *pAdapter,char *buf)
}
if ((lenRes < 0) || (lenRes >= lenBuf))
{
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("failed to copy data into buf %d"), lenRes);
return VOS_STATUS_E_FAILURE;
}
@@ -1260,6 +1276,8 @@ static VOS_STATUS wlan_ftm_priv_get_status(hdd_adapter_t *pAdapter,char *buf)
if ((lenRes < 0) || (lenRes >= lenBuf))
{
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("failed to copy data into buf %d"), lenRes);
return VOS_STATUS_E_FAILURE;
}
@@ -1590,10 +1608,21 @@ int wlan_hdd_ftm_close(hdd_context_t *pHddCtx)
//Assert Deep sleep signal now to put Libra HW in lowest power state
vosStatus = vos_chipAssertDeepSleep( NULL, NULL, NULL );
- VOS_ASSERT( VOS_IS_STATUS_SUCCESS( vosStatus ) );
+ if (!VOS_IS_STATUS_SUCCESS(vosStatus))
+ {
+ VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failed to assert deep sleep signal", __func__);
+ VOS_ASSERT( 0 );
+ }
//Vote off any PMIC voltage supplies
- vos_chipPowerDown(NULL, NULL, NULL);
+ vosStatus = vos_chipPowerDown(NULL, NULL, NULL);
+ if (!VOS_IS_STATUS_SUCCESS(vosStatus))
+ {
+ VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ "%s: Failed to put HW into low power", __func__);
+ VOS_ASSERT( 0 );
+ }
vos_chipVoteOffXOBuffer(NULL, NULL, NULL);
@@ -1915,8 +1944,8 @@ int wlan_hdd_ftm_get_nv_table
nvStatus = vos_nv_getNVBuffer((void **)&nvContents, &nvSize);
if ((VOS_STATUS_SUCCESS != nvStatus) || (NULL == nvContents))
{
- VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_FATAL,
- "Fail to get cached NV value Status %d", nvStatus);
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ FL("Fail to get cached NV value Status %d"), nvStatus);
return -EIO;
}
@@ -2077,8 +2106,8 @@ int wlan_hdd_ftm_set_nv_table
nvStatus = vos_nv_getNVBuffer((void **)&nvContents, &nvSize);
if ((VOS_STATUS_SUCCESS != nvStatus) || (NULL == nvContents))
{
- VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_FATAL,
- "Fail to get cached NV value Status %d", nvStatus);
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ FL("Fail to get cached NV value Status %d"), nvStatus);
return -EINVAL;
}
@@ -2215,8 +2244,8 @@ int wlan_hdd_ftm_blank_nv_table
nvStatus = vos_nv_getNVBuffer((void **)&nvContents, &nvSize);
if((VOS_STATUS_SUCCESS != nvStatus) || (NULL == nvContents))
{
- VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_INFO,
- "Fail to get cached NV value Status %d", nvStatus);
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ FL("Fail to get cached NV value Status %d"), nvStatus);
return -EIO;
}
@@ -2299,8 +2328,8 @@ int wlan_hdd_ftm_delete_nv_table
nvStatus = vos_nv_getNVBuffer((void **)&nvContents, &nvSize);
if ((VOS_STATUS_SUCCESS != nvStatus) || (NULL == nvContents))
{
- VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_INFO,
- "Fail to get cached NV value Status %d", nvStatus);
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ FL("Fail to get cached NV value Status %d"), nvStatus);
return -EIO;
}
@@ -2419,8 +2448,8 @@ int wlan_hdd_ftm_get_nv_field
nvStatus = vos_nv_getNVBuffer((void **)&nvContents, &nvSize);
if ((VOS_STATUS_SUCCESS != nvStatus) || (NULL == nvContents))
{
- VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_INFO,
- "Fail to get cached NV value Status %d", nvStatus);
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ FL("Fail to get cached NV value Status %d"), nvStatus);
return -EIO;
}
memcpy(&nvFieldDataBuffer, &nvContents->fields, sizeof(sNvFields));
@@ -2533,8 +2562,8 @@ int wlan_hdd_ftm_set_nv_field
nvStatus = vos_nv_getNVBuffer((void **)&nvContents, &nvSize);
if((VOS_STATUS_SUCCESS != nvStatus) || (NULL == nvContents))
{
- VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_INFO,
- "Fail to get cached NV value Status %d", nvStatus);
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ FL("Fail to get cached NV value Status %d"), nvStatus);
return -EIO;
}
@@ -2650,6 +2679,8 @@ int wlan_hdd_ftm_store_nv_table
nvStatus = vos_nv_getNVBuffer((void **)&nvContents, &nvSize);
if((VOS_STATUS_SUCCESS != nvStatus) || (NULL == nvContents))
{
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ FL("Fail to get cached NV value Status %d"), nvStatus);
return -EIO;
}
@@ -2743,6 +2774,8 @@ int wlan_hdd_ftm_store_nv_table
tableSize);
if(VOS_STATUS_SUCCESS != nvStatus)
{
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ "Failed update nv item %d", nvStatus);
return -EIO;
}
@@ -2788,9 +2821,9 @@ static int wlan_hdd_ftm_get_nv_bin
if ((VOS_STATUS_SUCCESS != nvStatus) || (NULL == nvContents))
{
- VOS_TRACE( VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_FATAL,
- "Fail to get cached NV value Status %d", nvStatus);
- return -EIO;
+ VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_ERROR,
+ FL("Fail to get cached NV value Status %d"), nvStatus);
+ return -EIO;
}
switch (nvTable->nvTable)
@@ -3429,7 +3462,11 @@ static VOS_STATUS validate_channel(unsigned int channel,unsigned int cb)
table = valid_channel_cb80;
if (NULL == table)
+ {
+ hddLog(VOS_TRACE_LEVEL_ERROR, "%s failed to find channel table %d",
+ __func__, cb);
return VOS_STATUS_E_FAILURE;
+ }
while (table[index] != 0)
{
@@ -3495,6 +3532,7 @@ static VOS_STATUS wlan_ftm_priv_set_channel(hdd_adapter_t *pAdapter,v_U16_t chan
{
uPttMsgs *pMsgBody;
VOS_STATUS status;
+ long ret;
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -3533,8 +3571,13 @@ static VOS_STATUS wlan_ftm_priv_set_channel(hdd_adapter_t *pAdapter,v_U16_t chan
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -3568,6 +3611,7 @@ static VOS_STATUS wlan_ftm_priv_set_pwr_cntl_mode(hdd_adapter_t *pAdapter,
{
uPttMsgs *pMsgBody;
VOS_STATUS status;
+ long ret;
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -3600,8 +3644,13 @@ static VOS_STATUS wlan_ftm_priv_set_pwr_cntl_mode(hdd_adapter_t *pAdapter,
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -3634,6 +3683,7 @@ static VOS_STATUS wlan_ftm_priv_set_txpower(hdd_adapter_t *pAdapter,
{
uPttMsgs *pMsgBody;
VOS_STATUS status;
+ long ret;
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -3677,8 +3727,13 @@ static VOS_STATUS wlan_ftm_priv_set_txpower(hdd_adapter_t *pAdapter,
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -3795,6 +3850,8 @@ static VOS_STATUS wlan_ftm_priv_start_stop_tx_pktgen(hdd_adapter_t *pAdapter,v_U
{
uPttMsgs *pMsgBody;
VOS_STATUS status;
+ long ret;
+
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -3835,8 +3892,14 @@ static VOS_STATUS wlan_ftm_priv_start_stop_tx_pktgen(hdd_adapter_t *pAdapter,v_U
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
+
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL,
@@ -3860,7 +3923,15 @@ static VOS_STATUS wlan_ftm_priv_start_stop_tx_pktgen(hdd_adapter_t *pAdapter,v_U
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var, msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ ret = wait_for_completion_interruptible_timeout(
+ &pHddCtx->ftm.ftm_comp_var,
+ msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
+
if(pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_FATAL, "%s:Ptt response status failed",__func__);
@@ -3931,6 +4002,7 @@ static VOS_STATUS wlan_ftm_priv_rx_mode(hdd_adapter_t *pAdapter,v_U16_t rxmode)
{
uPttMsgs *pMsgBody;
VOS_STATUS status;
+ long ret;
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -3992,8 +4064,13 @@ static VOS_STATUS wlan_ftm_priv_rx_mode(hdd_adapter_t *pAdapter,v_U16_t rxmode)
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL(" wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -4024,6 +4101,8 @@ done:
static VOS_STATUS wlan_ftm_priv_rx_pkt_clear(hdd_adapter_t *pAdapter,v_U16_t rx_pkt_clear)
{
VOS_STATUS status;
+ long ret;
+
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -4054,8 +4133,13 @@ static VOS_STATUS wlan_ftm_priv_rx_pkt_clear(hdd_adapter_t *pAdapter,v_U16_t rx_
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -4089,6 +4173,7 @@ static VOS_STATUS wlan_ftm_priv_get_channel(hdd_adapter_t *pAdapter,v_U16_t *pCh
VOS_STATUS status;
v_U16_t freq;
v_U8_t indx=0;
+ long ret;
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
@@ -4116,8 +4201,13 @@ static VOS_STATUS wlan_ftm_priv_get_channel(hdd_adapter_t *pAdapter,v_U16_t *pCh
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -4164,6 +4254,8 @@ static VOS_STATUS wlan_ftm_priv_get_txpower(hdd_adapter_t *pAdapter,v_U16_t *pTx
{
uPttMsgs *pMsgBody;
VOS_STATUS status;
+ long ret;
+
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -4188,8 +4280,13 @@ static VOS_STATUS wlan_ftm_priv_get_txpower(hdd_adapter_t *pAdapter,v_U16_t *pTx
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -4227,6 +4324,7 @@ VOS_STATUS wlan_ftm_priv_get_ftm_version(hdd_adapter_t *pAdapter,char *pftmVer)
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
int lenRes = 0;
int lenBuf = WE_FTM_MAX_STR_LEN;
+ long ret;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
{
@@ -4253,8 +4351,13 @@ VOS_STATUS wlan_ftm_priv_get_ftm_version(hdd_adapter_t *pAdapter,char *pftmVer)
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -4282,9 +4385,13 @@ VOS_STATUS wlan_ftm_priv_get_ftm_version(hdd_adapter_t *pAdapter,char *pftmVer)
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
-
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
lenRes = snprintf(buf, lenBuf, "%s_",WLAN_CHIP_VERSION);
if(lenRes < 0 || lenRes >= lenBuf)
@@ -4343,6 +4450,8 @@ static VOS_STATUS wlan_ftm_priv_get_txrate(hdd_adapter_t *pAdapter,char *pTxRate
uPttMsgs *pMsgBody;
VOS_STATUS status;
v_U16_t rate_index,ii;
+ long ret;
+
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -4368,8 +4477,13 @@ static VOS_STATUS wlan_ftm_priv_get_txrate(hdd_adapter_t *pAdapter,char *pTxRate
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse == PTT_STATUS_SUCCESS) {
@@ -4419,6 +4533,8 @@ static VOS_STATUS wlan_ftm_priv_get_rx_pkt_count(hdd_adapter_t *pAdapter,v_U16_t
{
uPttMsgs *pMsgBody;
VOS_STATUS status;
+ long ret;
+
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -4443,8 +4559,13 @@ static VOS_STATUS wlan_ftm_priv_get_rx_pkt_count(hdd_adapter_t *pAdapter,v_U16_t
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -4478,7 +4599,7 @@ static VOS_STATUS wlan_ftm_priv_get_rx_rssi(hdd_adapter_t *pAdapter,char *buf)
uPttMsgs *pMsgBody;
VOS_STATUS status;
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
- int ret;
+ long ret;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
{
@@ -4502,8 +4623,13 @@ static VOS_STATUS wlan_ftm_priv_get_rx_rssi(hdd_adapter_t *pAdapter,char *buf)
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -4607,6 +4733,8 @@ static VOS_STATUS wlan_ftm_priv_set_mac_address(hdd_adapter_t *pAdapter,char *bu
int macAddr[VOS_MAC_ADDRESS_LEN];
v_U8_t *pMacAddress;
v_U8_t ii;
+ long ret;
+
hdd_context_t *pHddCtx = (hdd_context_t *)pAdapter->pHddCtx;
if (pHddCtx->ftm.ftm_state != WLAN_FTM_STARTED)
@@ -4652,8 +4780,13 @@ static VOS_STATUS wlan_ftm_priv_set_mac_address(hdd_adapter_t *pAdapter,char *bu
status = VOS_STATUS_E_FAILURE;
goto done;
}
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
if (pMsgBuf->msgResponse != PTT_STATUS_SUCCESS)
{
@@ -4684,9 +4817,13 @@ static VOS_STATUS wlan_ftm_priv_set_mac_address(hdd_adapter_t *pAdapter,char *bu
status = VOS_STATUS_E_FAILURE;
goto done;
}
-
- wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
+ ret = wait_for_completion_interruptible_timeout(&pHddCtx->ftm.ftm_comp_var,
msecs_to_jiffies(WLAN_FTM_COMMAND_TIME_OUT));
+ if (0 >= ret )
+ {
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("wait on ftm_comp_var failed %ld"), ret);
+ }
done:
return VOS_STATUS_SUCCESS;
diff --git a/CORE/HDD/src/wlan_hdd_hostapd.c b/CORE/HDD/src/wlan_hdd_hostapd.c
index 30d5760ac7b9..99405a888e9e 100644
--- a/CORE/HDD/src/wlan_hdd_hostapd.c
+++ b/CORE/HDD/src/wlan_hdd_hostapd.c
@@ -376,7 +376,10 @@ static int hdd_hostapd_ioctl(struct net_device *dev,
goto exit;
}
- if ((!ifr) || (!ifr->ifr_data)) {
+ if ((!ifr) || (!ifr->ifr_data))
+ {
+ VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("ifr or ifr->ifr_data is NULL"));
ret = -EINVAL;
goto exit;
}
@@ -629,7 +632,9 @@ VOS_STATUS hdd_hostapd_SAPEventCB( tpSap_Event pSapEvent, v_PVOID_t usrDataForCa
pHostapdAdapter->sessionId =
pSapEvent->sapevt.sapStartBssCompleteEvent.sessionId;
//@@@ need wep logic here to set privacy bit
- hdd_softap_Register_BC_STA(pHostapdAdapter, pHddApCtx->uPrivacy);
+ vos_status = hdd_softap_Register_BC_STA(pHostapdAdapter, pHddApCtx->uPrivacy);
+ if (!VOS_IS_STATUS_SUCCESS(vos_status))
+ hddLog(LOGW, FL("Failed to register BC STA %d"), vos_status);
}
#ifdef IPA_OFFLOAD
if (hdd_ipa_is_enabled(pHddCtx))
@@ -816,25 +821,31 @@ VOS_STATUS hdd_hostapd_SAPEventCB( tpSap_Event pSapEvent, v_PVOID_t usrDataForCa
if (bAuthRequired || bWPSState == eANI_BOOLEAN_TRUE )
{
- hdd_softap_RegisterSTA( pHostapdAdapter,
- TRUE,
- pHddApCtx->uPrivacy,
- pSapEvent->sapevt.sapStationAssocReassocCompleteEvent.staId,
- 0,
- 0,
- (v_MACADDR_t *)wrqu.addr.sa_data,
- pSapEvent->sapevt.sapStationAssocReassocCompleteEvent.wmmEnabled);
+ vos_status = hdd_softap_RegisterSTA(pHostapdAdapter,
+ TRUE,
+ pHddApCtx->uPrivacy,
+ pSapEvent->sapevt.sapStationAssocReassocCompleteEvent.staId,
+ 0,
+ 0,
+ (v_MACADDR_t *)wrqu.addr.sa_data,
+ pSapEvent->sapevt.sapStationAssocReassocCompleteEvent.wmmEnabled);
+ if (!VOS_IS_STATUS_SUCCESS(vos_status))
+ hddLog(LOGW, FL("Failed to register STA %d "MAC_ADDRESS_STR""),
+ vos_status, MAC_ADDR_ARRAY(wrqu.addr.sa_data));
}
else
{
- hdd_softap_RegisterSTA( pHostapdAdapter,
- FALSE,
- pHddApCtx->uPrivacy,
- pSapEvent->sapevt.sapStationAssocReassocCompleteEvent.staId,
- 0,
- 0,
- (v_MACADDR_t *)wrqu.addr.sa_data,
- pSapEvent->sapevt.sapStationAssocReassocCompleteEvent.wmmEnabled);
+ vos_status = hdd_softap_RegisterSTA(pHostapdAdapter,
+ FALSE,
+ pHddApCtx->uPrivacy,
+ pSapEvent->sapevt.sapStationAssocReassocCompleteEvent.staId,
+ 0,
+ 0,
+ (v_MACADDR_t *)wrqu.addr.sa_data,
+ pSapEvent->sapevt.sapStationAssocReassocCompleteEvent.wmmEnabled);
+ if (!VOS_IS_STATUS_SUCCESS(vos_status))
+ hddLog(LOGW, FL("Failed to register STA %d "MAC_ADDRESS_STR""),
+ vos_status, MAC_ADDR_ARRAY(wrqu.addr.sa_data));
}
#ifdef IPA_OFFLOAD
if (hdd_ipa_is_enabled(pHddCtx))
@@ -1001,7 +1012,12 @@ VOS_STATUS hdd_hostapd_SAPEventCB( tpSap_Event pSapEvent, v_PVOID_t usrDataForCa
GFP_KERNEL);
#endif
//Update the beacon Interval if it is P2P GO
- hdd_change_mcc_go_beacon_interval(pHostapdAdapter);
+ vos_status = hdd_change_mcc_go_beacon_interval(pHostapdAdapter);
+ if (VOS_STATUS_SUCCESS != vos_status)
+ {
+ hddLog(LOGE, "%s: failed to update Beacon interval %d",
+ __func__, vos_status);
+ }
#ifdef QCA_WIFI_2_0
if (pHostapdAdapter->device_mode == WLAN_HDD_P2P_GO)
{
@@ -1119,7 +1135,11 @@ VOS_STATUS hdd_hostapd_SAPEventCB( tpSap_Event pSapEvent, v_PVOID_t usrDataForCa
return VOS_STATUS_SUCCESS;
case eSAP_MAC_TRIG_STOP_BSS_EVENT :
- hdd_stop_p2p_link(pHostapdAdapter, usrDataForCallback);
+ vos_status = hdd_stop_p2p_link(pHostapdAdapter, usrDataForCallback);
+ if (!VOS_IS_STATUS_SUCCESS(vos_status))
+ {
+ hddLog(LOGW, FL("hdd_stop_p2p_link failed %d"), vos_status);
+ }
return VOS_STATUS_SUCCESS;
case eSAP_CHANNEL_CHANGE_EVENT:
@@ -1171,7 +1191,9 @@ stopbss :
hdd_hostapd_stop(dev);
/* reclaim all resources allocated to the BSS */
- hdd_softap_stop_bss(pHostapdAdapter);
+ vos_status = hdd_softap_stop_bss(pHostapdAdapter);
+ if (!VOS_IS_STATUS_SUCCESS(vos_status))
+ hddLog(LOGW, FL("hdd_softap_stop_bss failed %d"), vos_status);
/* once the event is set, structure dev/pHostapdAdapter should
* not be touched since they are now subject to being deleted
@@ -1990,6 +2012,8 @@ static iw_softap_getparam(struct net_device *dev,
status = ccmCfgGetInt(hHal, WNI_CFG_ASSOC_STA_LIMIT, (tANI_U32 *)value);
if (eHAL_STATUS_SUCCESS != status)
{
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("failed to get WNI_CFG_ASSOC_STA_LIMIT from cfg %d"),status);
ret = -EIO;
}
break;
@@ -2537,7 +2561,7 @@ static iw_softap_commit(struct net_device *dev,
pConfig = kmalloc(sizeof(tsap_Config_t), GFP_KERNEL);
if(NULL == pConfig) {
- hddLog(LOG1, "VOS unable to allocate memory");
+ hddLog(LOGE, FL("VOS unable to allocate memory"));
return -ENOMEM;
}
pConfig->beacon_int = pCommitConfig->beacon_int;
@@ -2703,7 +2727,9 @@ static iw_softap_commit(struct net_device *dev,
pHostapdState->bCommit = TRUE;
if(pHostapdState->vosStatus)
{
- return -EIO;
+ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR,
+ FL("pHostapdState->vosStatus: %d"), pHostapdState->vosStatus);
+ return -EIO;
}
else
{