diff options
| author | Lakshmi Narayana Kalavala <lkalaval@codeaurora.org> | 2015-12-08 15:35:25 -0800 |
|---|---|---|
| committer | David Keitel <dkeitel@codeaurora.org> | 2016-03-23 21:14:02 -0700 |
| commit | c5120930c9bd388fee023d7e1069661bc1be82fd (patch) | |
| tree | 975f3a743241ff2aa56d753c2e871ad1b6350fa5 | |
| parent | 86b018a60a848a7b4ae491d48922d78026dff41c (diff) | |
msm: camera: Identify invalid buf done's on vb2 buffer
Observed camera module drivers doing invalid buf done's on
vb2 buffers even after the buffers are cleaned up from
the vb2 queue, Hence adding WARN_ON to identify the clients.
Change-Id: Iaca6fc7c481d7c06cd15e94fbbf9aebe2cc7e110
Signed-off-by: Lakshmi Narayana Kalavala <lkalaval@codeaurora.org>
| -rw-r--r-- | drivers/media/platform/msm/camera_v2/msm_vb2/msm_vb2.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/platform/msm/camera_v2/msm_vb2/msm_vb2.c b/drivers/media/platform/msm/camera_v2/msm_vb2/msm_vb2.c index e0cd3829ec44..35635c932456 100644 --- a/drivers/media/platform/msm/camera_v2/msm_vb2/msm_vb2.c +++ b/drivers/media/platform/msm/camera_v2/msm_vb2/msm_vb2.c @@ -249,7 +249,7 @@ static int msm_vb2_put_buf(struct vb2_v4l2_buffer *vb, int session_id, if (vb2_v4l2_buf == vb) break; } - if (vb2_v4l2_buf != vb) { + if (WARN_ON(vb2_v4l2_buf != vb)) { pr_err("VB buffer is INVALID vb=%p, ses_id=%d, str_id=%d\n", vb, session_id, stream_id); spin_unlock_irqrestore(&stream->stream_lock, flags); @@ -291,7 +291,7 @@ static int msm_vb2_buf_done(struct vb2_v4l2_buffer *vb, int session_id, if (vb2_v4l2_buf == vb) break; } - if (vb2_v4l2_buf != vb) { + if (WARN_ON(vb2_v4l2_buf != vb)) { pr_err("VB buffer is INVALID ses_id=%d, str_id=%d, vb=%p\n", session_id, stream_id, vb); spin_unlock_irqrestore(&stream->stream_lock, flags); |