diff options
| author | Shadab Naseem <snaseem@codeaurora.org> | 2019-03-25 21:52:00 +0530 |
|---|---|---|
| committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2020-04-28 04:26:59 -0700 |
| commit | b790ab7e1e81b5ccb8e3889aaa097933778b635b (patch) | |
| tree | a33959ed22f6beba3bcee3bba0d3fac0035aa51f | |
| parent | 477ec0234927c04760eea1b30669ab1e6659a5ea (diff) | |
sysmon-qmi: Fix compilation error while using LLVM
LLVM compiler gave compilation error for directly
dereferencing completion datatype for conditional check.
"warning: address of 'data->ind_recv.done' will always
evaluate to 'true' [-Wpointer-bool-conversion]"
Use completion API to fix it.
Change-Id: I985212802fe37d4b0ebe1b45e90f52d6213864f7
Signed-off-by: Shadab Naseem <snaseem@codeaurora.org>
Signed-off-by: Swetha Chikkaboraiah <schikk@codeaurora.org>
| -rw-r--r-- | drivers/soc/qcom/sysmon-qmi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/soc/qcom/sysmon-qmi.c b/drivers/soc/qcom/sysmon-qmi.c index 1063b96d8d83..e3b947390856 100644 --- a/drivers/soc/qcom/sysmon-qmi.c +++ b/drivers/soc/qcom/sysmon-qmi.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014-2015, 2017, The Linux Foundation. All rights reserved. + * Copyright (c) 2014-2015, 2017, 2020, The Linux Foundation. All rights reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 and @@ -474,7 +474,7 @@ int sysmon_send_shutdown(struct subsys_desc *dest_desc) shutdown_ack_ret = wait_for_shutdown_ack(dest_desc); if (shutdown_ack_ret < 0) { pr_err("shutdown_ack SMP2P bit for %s not set\n", data->name); - if (!&data->ind_recv.done) { + if (!completion_done(&data->ind_recv)) { pr_err("QMI shutdown indication not received\n"); ret = shutdown_ack_ret; } |