summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKapil Gupta <kapgupta@codeaurora.org>2017-08-08 15:44:28 +0530
committersnandini <snandini@codeaurora.org>2017-08-09 12:50:53 -0700
commitb3657c7ee10983d3ddaa2393ac4e6d5487385514 (patch)
tree7a3590e6ac7cb7efa7950ff423ef0c465a66d0b9
parentdc74eb877a5fb3ca838b0730d826946cbfb00f4f (diff)
qcacmn: Correct shash APIs calling
Add changes to correct shash APIs calling. Change-Id: Ic1756311c3869c0b4881e1ac07a8d32be6e1e481 CRs-Fixed: 2089258
-rw-r--r--qdf/linux/src/qdf_crypto.c53
1 files changed, 12 insertions, 41 deletions
diff --git a/qdf/linux/src/qdf_crypto.c b/qdf/linux/src/qdf_crypto.c
index 2308f86cb4d6..af6d456e273f 100644
--- a/qdf/linux/src/qdf_crypto.c
+++ b/qdf/linux/src/qdf_crypto.c
@@ -30,6 +30,7 @@
#include <crypto/skcipher.h>
/* Function Definitions and Documentation */
+#define MAX_HMAC_ELEMENT_CNT 10
/*
* xor: API to calculate xor
@@ -49,28 +50,8 @@ int qdf_get_hash(uint8_t *type,
uint8_t element_cnt, uint8_t *addr[], uint32_t *addr_len,
int8_t *hash)
{
- int i, ret;
- struct shash_desc desc;
-
- /* allocate crypto hash type */
- desc.tfm = crypto_alloc_shash(type, 0, CRYPTO_ALG_ASYNC);
-
- if (IS_ERR(desc.tfm)) {
- ret = PTR_ERR(desc.tfm);
- return -EINVAL;
- }
- desc.flags = 0;
- ret = crypto_shash_init(&desc);
-
- if (ret)
- return ret;
-
- for (i = 0; i < element_cnt ; i++)
- crypto_shash_update(&desc, addr[i], addr_len[i]);
-
- crypto_shash_final(&desc, hash);
- crypto_free_shash(desc.tfm);
- return 0;
+ return qdf_get_hmac_hash(type, NULL, 0, element_cnt,
+ addr, addr_len, hash);
}
int qdf_get_hmac_hash(uint8_t *type, uint8_t *key,
@@ -78,30 +59,20 @@ int qdf_get_hmac_hash(uint8_t *type, uint8_t *key,
uint8_t element_cnt, uint8_t *addr[], uint32_t *addr_len,
int8_t *hash)
{
- int i, ret;
- struct shash_desc desc;
-
- /* allocate crypto hash type */
- desc.tfm = crypto_alloc_shash(type, 0, CRYPTO_ALG_ASYNC);
+ int i;
+ size_t src_len[MAX_HMAC_ELEMENT_CNT];
- if (IS_ERR(desc.tfm)) {
- ret = PTR_ERR(desc.tfm);
+ if (element_cnt > MAX_HMAC_ELEMENT_CNT) {
+ QDF_TRACE(QDF_MODULE_ID_QDF, QDF_TRACE_LEVEL_ERROR,
+ FL("Invalid element count %d"), element_cnt);
return -EINVAL;
}
- desc.flags = 0;
- ret = crypto_shash_setkey(desc.tfm, key, keylen);
-
- crypto_shash_init(&desc);
-
- if (ret)
- return ret;
- for (i = 0; i < element_cnt ; i++)
- crypto_shash_update(&desc, addr[i], addr_len[i]);
+ for (i = 0; i < element_cnt; i++)
+ src_len[i] = addr_len[i];
- crypto_shash_final(&desc, hash);
- crypto_free_shash(desc.tfm);
- return 0;
+ return qdf_get_keyed_hash(type, key, keylen, (const uint8_t **)addr,
+ src_len, element_cnt, hash);
}
/* qdf_update_dbl from RFC 5297. Length of d is AES_BLOCK_SIZE (128 bits) */