diff options
| author | Srinivas Girigowda <sgirigow@qca.qualcomm.com> | 2014-09-05 18:04:55 -0700 |
|---|---|---|
| committer | AnjaneeDevi Kapparapu <c_akappa@qti.qualcomm.com> | 2014-09-10 10:36:08 +0530 |
| commit | a9586416e9f36828f7fee42a69dff80703f14130 (patch) | |
| tree | b0ad2ca260e33efa33df640d54a9b239995efd55 | |
| parent | 48d4cc86c47c0e1b5fbdde151a81d42b7eb3304e (diff) | |
qcacld: HDD: Fix typo in comments and logs
Fix typo in comments and logs
Change-Id: Id19d4620e3e203f29c99859ff36664fb0fce78d2
CRs-Fixed: 720503
31 files changed, 436 insertions, 409 deletions
diff --git a/CORE/HDD/inc/wlan_hdd_cfg.h b/CORE/HDD/inc/wlan_hdd_cfg.h index 75cb83eb514f..ab0f86ca625d 100644 --- a/CORE/HDD/inc/wlan_hdd_cfg.h +++ b/CORE/HDD/inc/wlan_hdd_cfg.h @@ -1338,10 +1338,11 @@ typedef enum #define CFG_QOS_WMM_TS_INFO_ACK_POLICY_MAX (0x01) #define CFG_QOS_WMM_TS_INFO_ACK_POLICY_DEFAULT (0x00) -#define CFG_SINGLE_TID_RC_NAME "SingleTIDRC" -#define CFG_SINGLE_TID_RC_MIN (0) // Seperate replay counter for all TID -#define CFG_SINGLE_TID_RC_MAX (1) // Single replay counter for all TID -#define CFG_SINGLE_TID_RC_DEFAULT (1) +#define CFG_SINGLE_TID_RC_NAME "SingleTIDRC" +#define CFG_SINGLE_TID_RC_MIN (0) /* Separate replay counter for all TID */ +#define CFG_SINGLE_TID_RC_MAX (1) /* Single replay counter for all TID */ +#define CFG_SINGLE_TID_RC_DEFAULT (1) + #define CFG_MCAST_BCAST_FILTER_SETTING_NAME "McastBcastFilter" #define CFG_MCAST_BCAST_FILTER_SETTING_MIN (0) #define CFG_MCAST_BCAST_FILTER_SETTING_MAX (3) @@ -1697,7 +1698,7 @@ typedef enum #define CFG_ACS_BAND_SWITCH_THRESHOLD "gACSBandSwitchThreshold" #define CFG_ACS_BAND_SWITCH_THRESHOLD_MIN (0) #define CFG_ACS_BAND_SWITCH_THRESHOLD_MAX (4444) -/* 2 BSS, maximus RSSI -90 */ +/* 2 BSS, maximum RSSI -90 */ #define CFG_ACS_BAND_SWITCH_THRESHOLD_DEFAULT (296) /*BMPS Logic @@ -3042,7 +3043,7 @@ typedef struct /* Wowl pattern */ char wowlPattern[1024]; - /* Control for Replay counetr. value 1 means + /* Control for Replay counter. value 1 means single replay counter for all TID*/ v_BOOL_t bSingleTidRc; v_U8_t mcastBcastFilterSetting; @@ -3411,14 +3412,18 @@ typedef struct mbssid_sap_dyn_ini_config { #define VAR_FLAGS_RANGE_CHECK_ASSUME_MINMAX ( VAR_FLAGS_RANGE_CHECK ) -#define VAR_FLAGS_RANGE_CHECK_ASSUME_DEFAULT ( 1 << 2 ) // bit 2 is range checking that assumes the DEFAULT value - // If less than MIN, assume DEFAULT, - // If grateer than MAX, assume DEFAULT. +/* + * bit 2 is range checking that assumes the DEFAULT value + * If less than MIN, assume DEFAULT, + * If greater than MAX, assume DEFAULT. + */ +#define VAR_FLAGS_RANGE_CHECK_ASSUME_DEFAULT ( 1 << 2 ) -#define VAR_FLAGS_DYNAMIC_CFG ( 1 << 3 ) // Bit 3 indicates that - // the config item can be - // modified dynamicially - // on a running system +/* + * Bit 3 indicates that the config item can be modified dynamically + * on a running system + */ +#define VAR_FLAGS_DYNAMIC_CFG ( 1 << 3 ) typedef enum { @@ -3496,7 +3501,7 @@ static __inline unsigned long utilMin( unsigned long a, unsigned long b ) } /*--------------------------------------------------------------------------- - Function declarations and documenation + Function declarations and documentation -------------------------------------------------------------------------*/ VOS_STATUS hdd_parse_config_ini(hdd_context_t *pHddCtx); VOS_STATUS hdd_update_mac_config(hdd_context_t *pHddCtx); diff --git a/CORE/HDD/inc/wlan_hdd_cfg80211.h b/CORE/HDD/inc/wlan_hdd_cfg80211.h index 93a69b7e53ee..79e4cab47ff4 100644 --- a/CORE/HDD/inc/wlan_hdd_cfg80211.h +++ b/CORE/HDD/inc/wlan_hdd_cfg80211.h @@ -388,7 +388,7 @@ enum qca_wlan_vendor_attr_extscan_results /* Unsigned 64-bit value; age of sample at the time of retrieval */ QCA_WLAN_VENDOR_ATTR_EXTSCAN_RESULTS_SCAN_RESULT_TIME_STAMP, - /* 33 x unsiged 8-bit value; NULL terminated SSID */ + /* 33 x unsigned 8-bit value; NULL terminated SSID */ QCA_WLAN_VENDOR_ATTR_EXTSCAN_RESULTS_SCAN_RESULT_SSID, /* An array of 6 x Unsigned 8-bit value */ QCA_WLAN_VENDOR_ATTR_EXTSCAN_RESULTS_SCAN_RESULT_BSSID, diff --git a/CORE/HDD/inc/wlan_hdd_dp_utils.h b/CORE/HDD/inc/wlan_hdd_dp_utils.h index 0165c9fa33cb..f052823529a9 100644 --- a/CORE/HDD/inc/wlan_hdd_dp_utils.h +++ b/CORE/HDD/inc/wlan_hdd_dp_utils.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013 The Linux Foundation. All rights reserved. + * Copyright (c) 2013-2014 The Linux Foundation. All rights reserved. * * Previously licensed under the ISC license by Qualcomm Atheros, Inc. * @@ -78,7 +78,7 @@ typedef struct //FIXME Need a helper function to cleanup skbs in a queue. Required for cleanup/shutdown /**----------------------------------------------------------------------------- - Function declarations and documenation + Function declarations and documentation ----------------------------------------------------------------------------*/ VOS_INLINE_FN v_VOID_t hdd_list_init( hdd_list_t *pList, v_SIZE_t max_size) { diff --git a/CORE/HDD/inc/wlan_hdd_main.h b/CORE/HDD/inc/wlan_hdd_main.h index b51075bed7ed..332630dc0a36 100644 --- a/CORE/HDD/inc/wlan_hdd_main.h +++ b/CORE/HDD/inc/wlan_hdd_main.h @@ -245,11 +245,11 @@ typedef v_U8_t tWlanHddMacAddr[HDD_MAC_ADDR_LEN]; * wait forever (or at least for a long time) for the response to be * received and for the completion variable to be set. However in * most cases these HDD APIs are being invoked in the context of a - * userspace thread which has invoked either a cfg80211 API or a + * user space thread which has invoked either a cfg80211 API or a * wireless extensions ioctl and which has taken the kernel rtnl_lock. * Since this lock is used to synchronize many of the kernel tasks, we * do not want to hold it for a long time. In addition we do not want - * to block userspace threads (such as the wpa supplicant's main + * to block user space threads (such as the wpa supplicant's main * thread) for an extended time. Therefore we only block for a short * time waiting for the response before we timeout. This means that * it is possible for the HDD API to timeout, and for the callback to @@ -478,7 +478,7 @@ enum _KEY_DIRECTION typedef enum _KEY_DIRECTION WAPI_KEY_DIRECTION; -/** WAPI KEY stucture definition */ +/* WAPI KEY structure definition */ struct WLAN_WAPI_KEY { WAPIKeyType keyType; @@ -501,7 +501,7 @@ typedef struct WLAN_WAPI_KEY *pWLAN_WAPI_KEY; #define WAPI_PSK_AKM_SUITE 0x02721400 #define WAPI_CERT_AKM_SUITE 0x01721400 -/** WAPI BKID List stucture definition */ +/* WAPI BKID List structure definition */ struct _WLAN_BKID_LIST { v_U32_t length; @@ -513,7 +513,7 @@ typedef struct _WLAN_BKID_LIST WLAN_BKID_LIST; typedef struct _WLAN_BKID_LIST *pWLAN_BKID_LIST; -/** WAPI Information stucture definition */ +/* WAPI Information structure definition */ struct hdd_wapi_info_s { v_U32_t nWapiMode; @@ -833,7 +833,7 @@ typedef struct multicast_addr_list #ifdef FEATURE_WLAN_BATCH_SCAN -/*Batch scan repsonse AP info*/ +/* Batch scan response AP info */ typedef struct { /*Batch ID*/ @@ -1048,8 +1048,8 @@ struct hdd_adapter_s tSirStopBatchScanInd hddStopBatchScanInd; /*HDD get batch scan request*/ tSirTriggerBatchScanResultInd hddTriggerBatchScanResultInd; - /*Batched scan reponse queue: new batch scan results added at the tail - and old batch scan results are deleted from head*/ + /* Batched scan response queue: new batch scan results added at the tail + and old batch scan results are deleted from head */ tHddBatchScanRsp *pBatchScanRsp; /*No of scans in batch scan rsp(MSCAN)*/ v_U32_t numScanList; @@ -1308,7 +1308,7 @@ struct hdd_context_s spinlock_t filter_lock; - /* Lock to avoid race condtion during start/stop bss*/ + /* Lock to avoid race condition during start/stop bss */ struct mutex sap_lock; /** ptt Process ID*/ @@ -1501,7 +1501,7 @@ struct hdd_context_s }; /*--------------------------------------------------------------------------- - Function declarations and documenation + Function declarations and documentation -------------------------------------------------------------------------*/ #ifdef FEATURE_WLAN_MCC_TO_SCC_SWITCH void wlan_hdd_check_sta_ap_concurrent_ch_intf(void *sta_pAdapter); diff --git a/CORE/HDD/inc/wlan_hdd_mib.h b/CORE/HDD/inc/wlan_hdd_mib.h index 1c134e64f219..baceec8b3a80 100644 --- a/CORE/HDD/inc/wlan_hdd_mib.h +++ b/CORE/HDD/inc/wlan_hdd_mib.h @@ -201,7 +201,7 @@ typedef struct sHddMib_s eMib_DevicePowerState mibDevicePowerState; // dot11NICPowerState is really the on/off state of the PHY. This can be - // mamipulated through OIDs like a software control for radio on/off. + /* Manipulated through OIDs like a software control for radio on/off. */ eMib_dot11NICPowerState mibDot11NICPowerState; // Hardware PHY state is the on/off state of the hardware PHY. diff --git a/CORE/HDD/inc/wlan_hdd_oemdata.h b/CORE/HDD/inc/wlan_hdd_oemdata.h index e4b232cc68cb..1d0709d2ebd8 100644 --- a/CORE/HDD/inc/wlan_hdd_oemdata.h +++ b/CORE/HDD/inc/wlan_hdd_oemdata.h @@ -63,7 +63,7 @@ typedef enum /* OEM App is not registered */ OEM_ERR_APP_NOT_REGISTERED, - /* Inavalid signature */ + /* Invalid signature */ OEM_ERR_INVALID_SIGNATURE, /* Invalid message type */ @@ -91,7 +91,7 @@ typedef PACKED_PRE struct PACKED_POST typedef PACKED_PRE struct PACKED_POST { - /* Signature of chipset vendor, e.g. QUALCOMM */ + /* Signature of chip set vendor, e.g. QUALCOMM */ tANI_U8 oem_target_signature[OEM_TARGET_SIGNATURE_LEN]; tANI_U32 oem_target_type; /* Chip type */ tANI_U32 oem_fw_version; /* FW version */ @@ -113,7 +113,7 @@ typedef PACKED_PRE struct PACKED_POST /* reserved0 */ tANI_U32 reserved0; - /* primary 20 MHz channel frequency in mhz */ + /* Primary 20 MHz channel frequency in MHz */ tANI_U32 mhz; /* Center frequency 1 in MHz */ diff --git a/CORE/HDD/inc/wlan_hdd_power.h b/CORE/HDD/inc/wlan_hdd_power.h index 97f1d9c09b1e..417e46229a79 100644 --- a/CORE/HDD/inc/wlan_hdd_power.h +++ b/CORE/HDD/inc/wlan_hdd_power.h @@ -57,7 +57,7 @@ //gEnableDriverStop = 1 implies map driver stop to standby #define WLAN_MAP_DRIVER_STOP_TO_STANDBY 1 - //gEnableDriverStop = 2 implies map sriver stop to deep sleep + /* gEnableDriverStop = 2 implies map driver stop to deep sleep */ #define WLAN_MAP_DRIVER_STOP_TO_DEEP_SLEEP 2 //Maximum time (ms) to wait for standby to complete diff --git a/CORE/HDD/inc/wlan_hdd_softap_tx_rx.h b/CORE/HDD/inc/wlan_hdd_softap_tx_rx.h index c5fddd676a51..5497a42da90b 100644 --- a/CORE/HDD/inc/wlan_hdd_softap_tx_rx.h +++ b/CORE/HDD/inc/wlan_hdd_softap_tx_rx.h @@ -61,7 +61,7 @@ -------------------------------------------------------------------------*/ /*--------------------------------------------------------------------------- - Function declarations and documenation + Function declarations and documentation -------------------------------------------------------------------------*/ /**============================================================================ @@ -72,7 +72,7 @@ @param dev : [in] pointer to Libra softap network device @return : NET_XMIT_DROP if packets are dropped - : NET_XMIT_SUCCESS if packet is enqueued succesfully + : NET_XMIT_SUCCESS if packet is enqueued successfully ===========================================================================*/ extern int hdd_softap_hard_start_xmit(struct sk_buff *skb, struct net_device *dev); @@ -129,8 +129,8 @@ extern VOS_STATUS hdd_softap_deinit_tx_rx( hdd_adapter_t *pAdapter ); extern VOS_STATUS hdd_softap_init_tx_rx_sta( hdd_adapter_t *pAdapter, v_U8_t STAId, v_MACADDR_t *pmacAddrSTA); /**============================================================================ - @brief hdd_softap_deinit_tx_rx_sta() - Deinit function to clean up a statioin in Tx/RX - modules in HDD + @brief hdd_softap_deinit_tx_rx_sta() - Deinit function to clean up a station + in Tx/RX modules in HDD @param pAdapter : [in] pointer to adapter context @param STAId : [in] Station ID to deinit @@ -152,7 +152,7 @@ extern VOS_STATUS hdd_softap_disconnect_tx_rx( hdd_adapter_t *pAdapter ); /**============================================================================ @brief hdd_tx_complete_cbk() - Callback function invoked by TL to indicate that a packet has been transmitted across the SDIO bus - succesfully. OS packet resources can be released after this cbk. + successfully. OS packet resources can be released after this cbk. @param vosContext : [in] pointer to VOS context @param pVosPacket : [in] pointer to VOS packet (containing skb) @@ -223,7 +223,7 @@ extern VOS_STATUS hdd_softap_rx_packet_cbk(v_VOID_t *vosContext, @param vosContext : [in] pointer to VOS context @param rx_buf_list : [in] pointer to rx adf_nbuf linked list - @param staId : [in] Station Id (Adress 1 Index) + @param staId : [in] Station Id (Address 1 Index) @return : VOS_STATUS_E_FAILURE if any errors encountered, : VOS_STATUS_SUCCESS otherwise @@ -329,7 +329,7 @@ extern VOS_STATUS hdd_softap_GetConnectedStaId( hdd_adapter_t *pAdapter, v_U8_t /**========================================================================== \brief hdd_start_trafficMonitor() - - This function dynamically enable traffic monitor functonality + This function dynamically enable traffic monitor functionality the command iwpriv wlanX setTrafficMon <value>. @param pAdapter : [in] pointer to adapter context @@ -341,7 +341,7 @@ VOS_STATUS hdd_start_trafficMonitor( hdd_adapter_t *pAdapter ); /**========================================================================== \brief hdd_stop_trafficMonitor() - - This function dynamically disable traffic monitor functonality + This function dynamically disable traffic monitor functionality the command iwpriv wlanX setTrafficMon <value>. @param pAdapter : [in] pointer to adapter context diff --git a/CORE/HDD/inc/wlan_hdd_tx_rx.h b/CORE/HDD/inc/wlan_hdd_tx_rx.h index d970bb4e105a..7d325393caaa 100644 --- a/CORE/HDD/inc/wlan_hdd_tx_rx.h +++ b/CORE/HDD/inc/wlan_hdd_tx_rx.h @@ -80,7 +80,7 @@ -------------------------------------------------------------------------*/ /*--------------------------------------------------------------------------- - Function declarations and documenation + Function declarations and documentation -------------------------------------------------------------------------*/ /**============================================================================ @@ -91,7 +91,7 @@ @param dev : [in] pointer to Libra network device @return : NET_XMIT_DROP if packets are dropped - : NET_XMIT_SUCCESS if packet is enqueued succesfully + : NET_XMIT_SUCCESS if packet is enqueued successfully ===========================================================================*/ extern int hdd_hard_start_xmit(struct sk_buff *skb, struct net_device *dev); @@ -247,9 +247,10 @@ extern v_BOOL_t hdd_IsEAPOLPacket( vos_pkt_t *pVosPacket ); void hdd_mon_tx_mgmt_pkt(hdd_adapter_t* pAdapter); /**============================================================================ - @brief hdd_mon_tx_work_queue() - workqueue handler for transmitting mgmt packets.. + @brief hdd_mon_tx_work_queue() - work queue handler for transmitting + mgmt packets. - @param work: [in] workqueue structure. + @param work: [in] work queue structure. ===========================================================================*/ void hdd_mon_tx_work_queue(struct work_struct *work); diff --git a/CORE/HDD/inc/wlan_hdd_wext.h b/CORE/HDD/inc/wlan_hdd_wext.h index 69e12046b395..b522f830fa95 100644 --- a/CORE/HDD/inc/wlan_hdd_wext.h +++ b/CORE/HDD/inc/wlan_hdd_wext.h @@ -129,11 +129,11 @@ typedef enum // some internal failure like memory allocation failure, etc, sync HDD_WLAN_WMM_STATUS_INTERNAL_FAILURE = 19, - // U-APSD failed during setup but OTA setup (whether TSPEC exchnage or - // re-assoc) was done so app should release this QoS, async + /* U-APSD failed during setup but OTA setup (whether TSPEC exchange or + re-assoc) was done so app should release this QoS, async */ HDD_WLAN_WMM_STATUS_SETUP_UAPSD_SET_FAILED = 20, - // U-APSD failed during modify, but OTA setup (whether TSPEC exchnage or - // re-assoc) was done so app should release this QoS, async + /* U-APSD failed during modify, but OTA setup (whether TSPEC exchange or + re-assoc) was done so app should release this QoS, async */ HDD_WLAN_WMM_STATUS_MODIFY_UAPSD_SET_FAILED = 21 } hdd_wlan_wmm_status_e; diff --git a/CORE/HDD/inc/wlan_hdd_wmm.h b/CORE/HDD/inc/wlan_hdd_wmm.h index 4326d2f924ed..dea928f0dc27 100644 --- a/CORE/HDD/inc/wlan_hdd_wmm.h +++ b/CORE/HDD/inc/wlan_hdd_wmm.h @@ -38,7 +38,7 @@ QoS (QoS here refers to a TSPEC). The setup QoS comes in two flavors: an explicit application invoked and an internal HDD invoked. The implicit QoS is for applications that do NOT call the custom QCT WLAN OIDs for QoS but - which DO mark their traffic for priortization. It also has logic to start, + which DO mark their traffic for prioritization. It also has logic to start, update and stop the U-APSD trigger frame generation. It also has logic to read WMM related config parameters from the registry. @@ -160,9 +160,11 @@ typedef struct // has implicit QoS negotiation already succeeded? v_BOOL_t wmmAcAccessGranted; - // is access to this AC allowed, either because we are not doing - // WMM, we are not doing implicit QoS, implict QoS has completed, - // or explicit QoS has completed? + /* + * Is access to this AC allowed, either because we are not doing + * WMM, we are not doing implicit QoS, implicit QoS has completed, + * or explicit QoS has completed? + */ v_BOOL_t wmmAcAccessAllowed; // is the wmmAcTspecInfo valid? @@ -207,7 +209,7 @@ extern const v_U8_t hddLinuxUpToAcMap[]; #define WLAN_HDD_MAX_DSCP 0x3f /**============================================================================ - @brief hdd_wmm_init() - Function which will initialize the WMM configuation + @brief hdd_wmm_init() - Function which will initialize the WMM configuration and status to an initial state. The configuration can later be overwritten via application APIs @@ -220,13 +222,13 @@ extern const v_U8_t hddLinuxUpToAcMap[]; VOS_STATUS hdd_wmm_init ( hdd_adapter_t *pAdapter ); /**============================================================================ - @brief hdd_wmm_adapter_init() - Function which will initialize the WMM configuation - and status to an initial state. The configuration can later be overwritten - via application APIs + @brief hdd_wmm_adapter_init() - Function which will initialize the WMM + configuration and status to an initial state. + The configuration can later be overwritten via application APIs @param pAdapter : [in] pointer to Adapter context - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ @@ -238,7 +240,7 @@ VOS_STATUS hdd_wmm_adapter_init( hdd_adapter_t *pAdapter ); @param pAdapter : [in] pointer to adapter context - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ @@ -246,18 +248,18 @@ VOS_STATUS hdd_wmm_adapter_close ( hdd_adapter_t* pAdapter ); /**============================================================================ @brief hdd_wmm_select_queue() - Function which will classify an OS packet - into linux Qdisc expectation + into Linux Qdisc expectation @param dev : [in] pointer to net_device structure @param skb : [in] pointer to OS packet (sk_buff) - @return : queue_index/linux AC value. + @return : queue_index/Linux AC value. ===========================================================================*/ v_U16_t hdd_wmm_select_queue(struct net_device * dev, struct sk_buff *skb); /**============================================================================ @brief hdd_hostapd_select_queue() - Function which will classify the packet - according to linux qdisc expectation. + according to Linux qdisc expectation. @param dev : [in] pointer to net_device structure @@ -295,7 +297,7 @@ v_VOID_t hdd_wmm_classify_pkt ( hdd_adapter_t* pAdapter, @param pGranted : [out] pointer to boolean flag when indicates if access has been granted or not - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_acquire_access( hdd_adapter_t* pAdapter, @@ -310,7 +312,7 @@ VOS_STATUS hdd_wmm_acquire_access( hdd_adapter_t* pAdapter, @param pRoamInfo: [in] pointer to roam information @param eBssType : [in] type of BSS - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_assoc( hdd_adapter_t* pAdapter, @@ -325,7 +327,7 @@ VOS_STATUS hdd_wmm_assoc( hdd_adapter_t* pAdapter, @param pRoamInfo: [in] pointer to roam information @param eBssType : [in] type of BSS - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_connect( hdd_adapter_t* pAdapter, @@ -339,7 +341,7 @@ VOS_STATUS hdd_wmm_connect( hdd_adapter_t* pAdapter, @param pAdapter : [in] pointer to adapter context @param pUapsdMask: [in] pointer to where the UAPSD Mask is to be stored - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_get_uapsd_mask( hdd_adapter_t* pAdapter, @@ -398,7 +400,7 @@ hdd_wlan_wmm_status_e hdd_wmm_checkts( hdd_adapter_t* pAdapter, of all ACs @param pAdapter : [in] pointer to adapter context - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_adapter_clear( hdd_adapter_t *pAdapter ); diff --git a/CORE/HDD/inc/wlan_hdd_wowl.h b/CORE/HDD/inc/wlan_hdd_wowl.h index 96b9ea639a5b..398a2425bc5d 100644 --- a/CORE/HDD/inc/wlan_hdd_wowl.h +++ b/CORE/HDD/inc/wlan_hdd_wowl.h @@ -67,11 +67,11 @@ 2) Unicast Pattern However note that WoWL will not be enabled by default by HDD. WoWL needs to - enabled explcitly by exercising the iwpriv command. + enabled explicitly by exercising the iwpriv command. HDD will expose an API that accepts patterns as Hex string in the following - format: "PatternSize:PatternMaskSize:PatternMask:Pattern". Mutliple patterns - can be specified by deleimiting each pattern with the ';' token. + format: "PatternSize:PatternMaskSize:PatternMask:Pattern". Multiple patterns + can be specified by delimiting each pattern with the ';' token. "PatternSize1:PatternMaskSize1:PatternMask1:Pattern1;PatternSize2:...." Patterns can be configured dynamically via iwpriv cmd or statically via @@ -79,15 +79,15 @@ PBM (when enabled) can perform filtering on unicast data or broadcast data or both. These configurations are part of factory defaults (cfg.dat) and - the deafult behavior is to perform filtering on both unicast and data frames. + the default behavior is to perform filtering on both unicast and data frames. MP filtering (when enabled) is performed ALWAYS on both unicast and broadcast data frames. - Mangement frames are not subjected to WoWL filtering and are discarded when + Management frames are not subjected to WoWL filtering and are discarded when WoWL is enabled. - Whenever a patern match succeeds, RX path is restored and packets (both + Whenever a pattern match succeeds, RX path is restored and packets (both management and data) will be pushed to the host from that point onwards. Therefore, exit from WoWL is implicit and happens automatically when the first packet match succeeds. @@ -187,7 +187,7 @@ v_BOOL_t hdd_exit_wowl (hdd_adapter_t*pAdapter); /**============================================================================ @brief hdd_init_wowl() - Init function which will initialize the WoWL module - and perform any required intial configuration + and perform any required initial configuration @return : FALSE if any errors encountered : TRUE otherwise diff --git a/CORE/HDD/src/wlan_hdd_assoc.c b/CORE/HDD/src/wlan_hdd_assoc.c index e3311a0e6378..94f1a3487452 100644 --- a/CORE/HDD/src/wlan_hdd_assoc.c +++ b/CORE/HDD/src/wlan_hdd_assoc.c @@ -198,27 +198,6 @@ eCsrBand hdd_connGetConnectedBand( hdd_station_ctx_t *pHddStaCtx ) return eCSR_BAND_ALL; } - -//TODO - Not used anyhwere. Can be removed. -#if 0 -// -v_BOOL_t hdd_connIsConnectedInfra( hdd_adapter_t *pAdapter ) -{ - v_BOOL_t fConnectedInfra = FALSE; - eConnectionState connState; - - if ( hdd_connGetConnectionState( WLAN_HDD_GET_STATION_CTX_PTR(pAdapter), &connState ) ) - { - if ( eConnectionState_Associated == connState ) - { - fConnectedInfra = TRUE; - } - } - - return( fConnectedInfra ); -} -#endif - static inline v_BOOL_t hdd_connGetConnectedCipherAlgo( hdd_station_ctx_t *pHddStaCtx, eCsrEncryptionType *pConnectedCipherAlgo ) { v_BOOL_t fConnected = VOS_FALSE; @@ -317,7 +296,7 @@ void hdd_connSaveConnectInfo( hdd_adapter_t *pAdapter, tCsrRoamInfo *pRoamInfo, // Get Multicast Encryption Type encryptType = pRoamInfo->u.pConnectedProfile->mcEncryptionType; pHddStaCtx->conn_info.mcEncryptionType = encryptType; - // Get Unicast Encrytion Type + /* Get Unicast Encryption Type */ encryptType = pRoamInfo->u.pConnectedProfile->EncryptionType; pHddStaCtx->conn_info.ucEncryptionType = encryptType; @@ -834,7 +813,7 @@ void hdd_connRemoveConnectInfo( hdd_station_ctx_t *pHddStaCtx ) vos_mem_zero( &pHddStaCtx->conn_info.SSID, sizeof( tCsrSSIDInfo ) ); } -/* TODO Revist this function. and data path */ +/* TODO Revisit this function. and data path */ static VOS_STATUS hdd_roamDeregisterSTA( hdd_adapter_t *pAdapter, tANI_U8 staId ) { VOS_STATUS vosStatus; @@ -990,10 +969,12 @@ static eHalStatus hdd_DisConnectHandler( hdd_adapter_t *pAdapter, tCsrRoamInfo * // and the P2P Client is Connected //Enable BMPS - // In case of JB, as Change-Iface may or maynot be called for p2p0 - // Enable BMPS/IMPS in case P2P_CLIENT disconnected - // If power save offload is enabled, Fw will take care - // of power save in case of concurrency. + /* + * In case of JB, as Change-Iface may or may not be called for p2p0 + * Enable BMPS/IMPS in case P2P_CLIENT disconnected + * If power save offload is enabled, Fw will take care + * of power save in case of concurrency. + */ if((VOS_STATUS_SUCCESS == hdd_issta_p2p_clientconnected(pHddCtx)) && !pHddCtx->cfg_ini->enablePowersaveOffload) { @@ -1102,7 +1083,7 @@ static VOS_STATUS hdd_roamRegisterSTA( hdd_adapter_t *pAdapter, { return VOS_STATUS_E_FAILURE; } - // Get the Station ID from the one saved during the assocation. + /* Get the Station ID from the one saved during the association */ staDesc.ucSTAId = staId; if ( pHddStaCtx->conn_info.connDot11DesiredBssType == eMib_dot11DesiredBssType_infrastructure) @@ -1118,10 +1099,13 @@ static VOS_STATUS hdd_roamRegisterSTA( hdd_adapter_t *pAdapter, // for an IBSS 'connect', setup the Station Descriptor for TL. staDesc.wSTAType = WLAN_STA_IBSS; - // Note that for IBSS, the STA MAC address and BSSID are goign to be different where - // in infrastructure, they are the same (BSSID is the MAC address of the AP). So, - // for IBSS we have a second field to pass to TL in the STA descriptor that we don't - // pass when making an Infrastructure connection. + /* + * Note that for IBSS, the STA MAC address and BSSID are going to be + * different where in infrastructure, they are the same (BSSID is the + * MAC address of the AP). So, for IBSS we have a second field to pass + * to TL in the STA descriptor that we don't pass when making an + * Infrastructure connection. + */ vos_mem_copy( staDesc.vSTAMACAddress.bytes, pPeerMacAddress->bytes,sizeof(pPeerMacAddress->bytes) ); vos_mem_copy( staDesc.vBSSIDforIBSS.bytes, pHddStaCtx->conn_info.bssId,6 ); } @@ -1440,7 +1424,7 @@ static eHalStatus hdd_AssociationCompletionHandler( hdd_adapter_t *pAdapter, tCs } #endif /* FEATURE_WLAN_WAPI */ - // indicate 'connect' status to userspace + /* Indicate 'connect' status to user space */ hdd_SendAssociationEvent(dev,pRoamInfo); // Initialize the Linkup event completion variable @@ -1503,7 +1487,7 @@ static eHalStatus hdd_AssociationCompletionHandler( hdd_adapter_t *pAdapter, tCs wlan_hdd_check_sta_ap_concurrent_ch_intf, (void *)pAdapter); adf_os_sched_work(0, &pHddCtx->sta_ap_intf_check_work); VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO, - "Checking for Concurrent Channge interference"); + "Checking for Concurrent Change interference"); } #endif @@ -1804,9 +1788,11 @@ static eHalStatus hdd_AssociationCompletionHandler( hdd_adapter_t *pAdapter, tCs // and the P2P Client is Connected //Enable BMPS - // In case of JB, as Change-Iface may or maynot be called for p2p0 - // Enable BMPS/IMPS in case P2P_CLIENT disconnected - // If ps offload is enabled, fw will take care in case of concurrency. + /* + * In case of JB, as Change-Iface may or may not be called for p2p0 + * Enable BMPS/IMPS in case P2P_CLIENT disconnected + * If ps offload is enabled, fw will take care in case of concurrency. + */ if(((WLAN_HDD_INFRA_STATION == pAdapter->device_mode) || (WLAN_HDD_P2P_CLIENT == pAdapter->device_mode)) && (vos_concurrent_open_sessions_running()) && @@ -2223,11 +2209,13 @@ static eHalStatus hdd_RoamSetKeyCompleteHandler( hdd_adapter_t *pAdapter, tCsrRo } else { - // TODO: Considering getting a state machine in HDD later. - // This routine is invoked twice. 1)set PTK 2)set GTK. - // The folloing if statement will be TRUE when setting GTK. - // At this time we don't handle the state in detail. - // Related CR: 174048 - TL not in authenticated state + /* + * TODO: Considering getting a state machine in HDD later. + * This routine is invoked twice. 1)set PTK 2)set GTK. + * The following if statement will be TRUE when setting GTK. + * At this time we don't handle the state in detail. + * Related CR: 174048 - TL not in authenticated state + */ vosStatus = WLANTL_ChangeSTAState(pHddCtx->pvosContext, pHddStaCtx->conn_info.staId[0], WLANTL_STA_AUTHENTICATED, @@ -2506,7 +2494,7 @@ VOS_STATUS hdd_roamRegisterTDLSSTA( hdd_adapter_t *pAdapter, /* * TDLS sta in BSS should be set as STA type TDLS and STA MAC should - * be peer MAC, here we are wokrking on direct Link + * be peer MAC, here we are working on direct Link */ staDesc.ucSTAId = staId ; diff --git a/CORE/HDD/src/wlan_hdd_cfg.c b/CORE/HDD/src/wlan_hdd_cfg.c index cffc7e6e4f89..17a6ae22e13b 100644 --- a/CORE/HDD/src/wlan_hdd_cfg.c +++ b/CORE/HDD/src/wlan_hdd_cfg.c @@ -3952,7 +3952,7 @@ REG_TABLE_ENTRY mbssid_sap_dyn_ini_reg_table[] = #endif /* - * This function returns a pointer to the character after the occurence + * This function returns a pointer to the character after the occurrence * of a new line character. It also modifies the original string by replacing * the '\n' character with the null character. * Function returns NULL if no new line character was found before end of @@ -4663,7 +4663,7 @@ static void update_mac_from_string(hdd_context_t *pHddCtx, tCfgIniEntry *macTabl } /* - * This function tries to update macaddress from cfg file. + * This function tries to update mac address from cfg file. * It overwrites the MAC address if config file exist. */ VOS_STATUS hdd_update_mac_config(hdd_context_t *pHddCtx) @@ -5236,8 +5236,8 @@ VOS_STATUS hdd_string_to_u8_array( char *str, tANI_U8 *intArray, tANI_U8 *len, while ( (s != NULL) && (*len < intArrayMaxLen) ) { int val; - //Increment length only if sscanf succesfully extracted one element. - //Any other return value means error. Ignore it. + /* Increment length only if sscanf successfully extracted one element. + Any other return value means error. Ignore it. */ if( sscanf(s, "%d", &val ) == 1 ) { intArray[*len] = (tANI_U8) val; @@ -6266,7 +6266,7 @@ VOS_STATUS hdd_set_sme_config( hdd_context_t *pHddCtx ) pHddCtx->cfg_ini->acsScanBandPreference; #ifdef FEATURE_WLAN_SCAN_PNO - /* Update PNO offoad status */ + /* Update PNO offload status */ smeConfig->pnoOffload = pHddCtx->cfg_ini->PnoOffload; #endif diff --git a/CORE/HDD/src/wlan_hdd_cfg80211.c b/CORE/HDD/src/wlan_hdd_cfg80211.c index 569ed3e588d6..48dd8c55f5d8 100644 --- a/CORE/HDD/src/wlan_hdd_cfg80211.c +++ b/CORE/HDD/src/wlan_hdd_cfg80211.c @@ -713,7 +713,7 @@ static struct index_vht_data_rate_type supported_vht_mcs_rate_nss2[] = }; #endif /* WLAN_FEATURE_11AC */ -/*array index ponints to MCS and array value points respective rssi*/ +/* Array index points to MCS and array value points respective rssi */ static int rssiMcsTbl[][10] = { /*MCS 0 1 2 3 4 5 6 7 8 9*/ @@ -802,7 +802,7 @@ wlan_hdd_extscan_results_policy[QCA_WLAN_VENDOR_ATTR_EXTSCAN_RESULTS_MAX + 1] = /* * FUNCTION: wlan_hdd_send_avoid_freq_event * This is called when wlan driver needs to send vendor specific - * avoid frequency range event to userspace + * avoid frequency range event to user space */ int wlan_hdd_send_avoid_freq_event(hdd_context_t *pHddCtx, tHddAvoidFreqList *pAvoidFreqList) @@ -1475,7 +1475,7 @@ static int wlan_hdd_cfg80211_extscan_set_significant_change( hddLog(VOS_TRACE_LEVEL_INFO, FL("Lost AP sample size (%u)"), pReqMsg->lostApSampleSize); - /* Parse and fetch AP min breacing */ + /* Parse and fetch AP min breaching */ if (!tb[QCA_WLAN_VENDOR_ATTR_EXTSCAN_SIGNIFICANT_CHANGE_PARAMS_MIN_BREACHING]) { hddLog(VOS_TRACE_LEVEL_ERROR, FL("attr AP min breaching")); @@ -3688,8 +3688,8 @@ int wlan_hdd_cfg80211_init(struct device *dev, #endif } - /* Before registering we need to update the ht capabilitied based - * on ini values*/ + /* Before registering we need to update the HT capability based + * on ini values */ if( !pCfg->ShortGI20MhzEnable ) { wlan_hdd_band_2_4_GHZ.ht_cap.cap &= ~IEEE80211_HT_CAP_SGI_20; @@ -3854,17 +3854,19 @@ void wlan_hdd_cfg80211_update_wiphy_caps(struct wiphy *wiphy) #endif } -/* In this function we are updating channel list when, - regulatory domain is FCC and country code is US. - Here In FCC standard 5GHz UNII-1 Bands are indoor only. - As per FCC smart phone is not a indoor device. - GO should not opeate on indoor channels */ +/* + * In this function we are updating channel list when, + * regulatory domain is FCC and country code is US. + * Here In FCC standard 5GHz UNII-1 Bands are indoor only. + * As per FCC smart phone is not a indoor device. + * GO should not operate on indoor channels. + */ void wlan_hdd_cfg80211_update_reg_info(struct wiphy *wiphy) { int j; hdd_context_t *pHddCtx = wiphy_priv(wiphy); tANI_U8 defaultCountryCode[3] = SME_INVALID_COUNTRY_CODE; - //Default counrtycode from NV at the time of wiphy initialization. + /* Default country code from NV at the time of wiphy initialization. */ if (eHAL_STATUS_SUCCESS != sme_GetDefaultCountryCodeFrmNv(pHddCtx->hHal, &defaultCountryCode[0])) { @@ -3998,7 +4000,7 @@ void wlan_hdd_cfg80211_set_key_wapi(hdd_adapter_t* pAdapter, u8 key_index, vos_mem_zero(&setKey, sizeof(tCsrRoamSetKey)); setKey.keyId = key_index; // Store Key ID setKey.encType = eCSR_ENCRYPT_TYPE_WPI; // SET WAPI Encryption - setKey.keyDirection = eSIR_TX_RX; // Key Directionn both TX and RX + setKey.keyDirection = eSIR_TX_RX; /* Key Direction both TX and RX */ setKey.paeRole = 0 ; // the PAE role if (!mac_addr || is_broadcast_ether_addr(mac_addr)) { @@ -5265,9 +5267,9 @@ static int wlan_hdd_cfg80211_start_bss(hdd_adapter_t *pHostapdAdapter, else pConfig->SapHw_mode = eSAP_DOT11_MODE_11ac; - /*If ACS disable and selected channel <= 14 + /* If ACS disable and selected channel <= 14 OR - ACS enabled and ACS operating band is choosen as 2.4 + ACS enabled and ACS operating band is chosen as 2.4 AND VHT in 2.4G Disabled THEN @@ -5520,7 +5522,7 @@ static int wlan_hdd_cfg80211_start_bss(hdd_adapter_t *pHostapdAdapter, return -EINVAL; } - //Succesfully started Bss update the state bit. + /* Successfully started Bss update the state bit. */ set_bit(SOFTAP_BSS_STARTED, &pHostapdAdapter->event_flags); wlan_hdd_incr_active_session(pHddCtx, pHostapdAdapter->device_mode); @@ -6070,7 +6072,7 @@ static int wlan_hdd_cfg80211_change_bss (struct wiphy *wiphy, return ret; } /* FUNCTION: wlan_hdd_change_country_code_cd -* to wait for contry code completion +* to wait for country code completion */ void* wlan_hdd_change_country_code_cb(void *pAdapter) { @@ -6609,7 +6611,7 @@ static int wlan_hdd_tdls_add_station(struct wiphy *wiphy, if ( eHAL_STATUS_SUCCESS != pAdapter->tdlsAddStaStatus) { VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR, - "%s: Add Station is unsucessful", __func__); + "%s: Add Station is unsuccessful", __func__); return -EPERM; } @@ -6720,14 +6722,15 @@ static int wlan_hdd_change_station(struct wiphy *wiphy, StaParams.supported_rates_len = params->supported_rates_len; - /* Note : The Maximum sizeof supported_rates sent by the Supplicant is 32. - * The supported_rates array , for all the structures propogating till Add Sta - * to the firmware has to be modified , if the supplicant (ieee80211) is - * modified to send more rates. + /* + * Note : The Maximum sizeof supported_rates sent by the Supplicant + * is 32. The supported_rates array, for all the structures + * propagating till Add Sta to the firmware has to be modified, + * if the supplicant (ieee80211) is modified to send more rates. */ - /* To avoid Data Currption , set to max length to SIR_MAC_MAX_SUPP_RATES - */ + /* To avoid Data Corruption, set to max length + to SIR_MAC_MAX_SUPP_RATES */ if (StaParams.supported_rates_len > SIR_MAC_MAX_SUPP_RATES) StaParams.supported_rates_len = SIR_MAC_MAX_SUPP_RATES; @@ -7083,7 +7086,7 @@ static int __wlan_hdd_cfg80211_add_key( struct wiphy *wiphy, /* in case of IBSS as there was no information available about WEP keys during - * IBSS join, group key intialized with NULL key, so re-initialize group key + * IBSS join, group key initialized with NULL key, so re-initialize group key * with correct value*/ if ( (eCSR_BSS_TYPE_START_IBSS == pWextState->roamProfile.BSSType) && !( ( IW_AUTH_KEY_MGMT_802_1X @@ -7435,11 +7438,13 @@ static int __wlan_hdd_cfg80211_set_default_key( struct wiphy *wiphy, if (Keys->KeyLength[key_index] == CSR_WEP40_KEY_LEN && pWextState->roamProfile.EncryptionType.encryptionType[0] == eCSR_ENCRYPT_TYPE_WEP104) { - /* In the case of dynamic wep supplicant hardcodes DWEP type + /* + * In the case of dynamic wep supplicant hardcodes DWEP type * to eCSR_ENCRYPT_TYPE_WEP104 even though ap is configured for - * WEP-40 encryption. In this canse the key length is 5 but the - * encryption type is 104 hence checking the key langht(5) and - * encryption type(104) and switching encryption type to 40*/ + * WEP-40 encryption. In this case the key length is 5 but the + * encryption type is 104 hence checking the key length(5) and + * encryption type(104) and switching encryption type to 40. + */ pWextState->roamProfile.EncryptionType.encryptionType[0] = eCSR_ENCRYPT_TYPE_WEP40; pWextState->roamProfile.mcEncryptionType.encryptionType[0] = @@ -7668,7 +7673,7 @@ wlan_hdd_cfg80211_inform_bss_frame( hdd_adapter_t *pAdapter, memcpy(mgmt->bssid, bss_desc->bssId, ETH_ALEN); #ifdef CONFIG_CNSS - /* Android does not want the timestamp from the frame. + /* Android does not want the time stamp from the frame. Instead it wants a monotonic increasing value */ cnss_get_monotonic_boottime(&ts); mgmt->u.probe_resp.timestamp = @@ -7719,24 +7724,25 @@ wlan_hdd_cfg80211_inform_bss_frame( hdd_adapter_t *pAdapter, } chan = __ieee80211_get_channel(wiphy, freq); - /* When the band is changed on the fly using the GUI, three things are done + /* + * When the band is changed on the fly using the GUI, three things are done * 1. scan abort * 2. flush scan results from cache * 3. update the band with the new band user specified (refer to the * hdd_setBand_helper function) as part of the scan abort, message will be - * queued to PE and we proceed with flushing and changinh the band. + * queued to PE and we proceed with flushing and changing the band. * PE will stop the scanning further and report back the results what ever * it had till now by calling the call back function. * if the time between update band and scandone call back is sufficient * enough the band change reflects in SME, SME validates the channels - * and discards the channels correponding to previous band and calls back + * and discards the channels corresponding to previous band and calls back * with zero bss results. but if the time between band update and scan done * callback is very small then band change will not reflect in SME and SME - * reports to HDD all the channels correponding to previous band.this is due - * to race condition.but those channels are invalid to the new band and so - * this function __ieee80211_get_channel will return NULL.Each time we - * report scan result with this pointer null warning kernel trace is printed. - * if the scan results contain large number of APs continuosly kernel + * reports to HDD all the channels corresponding to previous band.this is + * due to race condition.but those channels are invalid to the new band and + * so this function __ieee80211_get_channel will return NULL.Each time we + * report scan result with this pointer null warning kernel trace is printed + * if the scan results contain large number of APs continuously kernel * warning trace is printed and it will lead to apps watch dog bark. * So drop the bss and continue to next bss. */ @@ -8168,7 +8174,7 @@ allow_suspend: hdd_allow_suspend(); /* Acquire wakelock to handle the case where APP's tries to suspend - * immediatly after the driver gets connect request(i.e after scan) + * immediately after the driver gets connect request(i.e after scan) * from supplicant, this result in app's is suspending and not able * to process the connect request to AP */ hdd_prevent_suspend_timeout(1000); @@ -8267,7 +8273,7 @@ v_BOOL_t hdd_isConnectionInProgress( hdd_context_t *pHddCtx ) /* * FUNCTION: __wlan_hdd_cfg80211_scan * this scan respond to scan trigger and update cfg80211 scan database - * later, scan dump command can be used to recieve scan results + * later, scan dump command can be used to receive scan results */ int __wlan_hdd_cfg80211_scan( struct wiphy *wiphy, #if (LINUX_VERSION_CODE < KERNEL_VERSION(3,6,0)) @@ -8509,9 +8515,9 @@ int __wlan_hdd_cfg80211_scan( struct wiphy *wiphy, */ /* Supplicant does single channel scan after 8-way handshake - * and in that case driver shoudnt flush scan results. If + * and in that case driver shouldn't flush scan results. If * driver flushes the scan results here and unfortunately if - * the AP doesnt respond to our probe req then association + * the AP doesn't respond to our probe req then association * fails which is not desired */ @@ -8776,7 +8782,7 @@ int wlan_hdd_cfg80211_connect_start( hdd_adapter_t *pAdapter, pRoamProfile->BSSIDs.numOfBSSIDs = 1; vos_mem_copy((void *)(pRoamProfile->BSSIDs.bssid), bssid, VOS_MAC_ADDR_SIZE); - /* Save BSSID in seperate variable as well, as RoamProfile + /* Save BSSID in separate variable as well, as RoamProfile BSSID is getting zeroed out in the association process. And in case of join failure we should send valid BSSID to supplicant */ @@ -8896,7 +8902,7 @@ int wlan_hdd_cfg80211_connect_start( hdd_adapter_t *pAdapter, * enhancements, the supplicant is not issuing the scan command now. * So the unicast frames which are sent from the host are not having * the additional IEs. If it is P2P CLIENT and there is no additional - * IE present in roamProfile, then use the addtional IE form scan_info + * IE present in roamProfile, then use the additional IE form scan_info */ if ((pAdapter->device_mode == WLAN_HDD_P2P_CLIENT) && @@ -9262,7 +9268,7 @@ int wlan_hdd_cfg80211_set_ie( hdd_adapter_t *pAdapter, pWextState->roamProfile.nAddIEAssocLength = pWextState->assocAddIE.length; } #endif - /* Appending HS 2.0 Indication Element in Assiciation Request */ + /* Appending HS 2.0 Indication Element in Association Request */ else if ( (0 == memcmp(&genie[0], HS20_OUI_TYPE, HS20_OUI_TYPE_SIZE)) ) { @@ -9283,7 +9289,7 @@ int wlan_hdd_cfg80211_set_ie( hdd_adapter_t *pAdapter, pWextState->roamProfile.pAddIEAssoc = pWextState->assocAddIE.addIEdata; pWextState->roamProfile.nAddIEAssocLength = pWextState->assocAddIE.length; } - /* Appending OSEN Information Element in Assiciation Request */ + /* Appending OSEN Information Element in Association Request */ else if ( (0 == memcmp(&genie[0], OSEN_OUI_TYPE, OSEN_OUI_TYPE_SIZE)) ) { @@ -9511,7 +9517,7 @@ int wlan_hdd_cfg80211_set_privacy( hdd_adapter_t *pAdapter, pWextState->roamProfile.MFPEnabled = (req->mfp == NL80211_MFP_REQUIRED); #endif - /*parse WPA/RSN IE, and set the correspoing fileds in Roam profile*/ + /* Parse WPA/RSN IE, and set the corresponding fields in Roam profile */ if (req->ie_len) { status = wlan_hdd_cfg80211_set_ie(pAdapter, req->ie, req->ie_len); @@ -9656,7 +9662,7 @@ static int __wlan_hdd_cfg80211_connect( struct wiphy *wiphy, * by setting the third bit in flags in case of Secure connection * so if the supplicant does not support this then LFR3.0 shall * be disabled.if supplicant indicates support for offload - * of key managament then we shall enable LFR3.0.Note that + * of key management then we shall enable LFR3.0.Note that * supplicant set the bit in flags means driver already indicated * its capability to handle the key management and LFR3.0 is * enabled in INI and FW also has the capability to handle @@ -10061,7 +10067,7 @@ static int wlan_hdd_cfg80211_set_privacy_ibss( if (params->privacy) { /* Security enabled IBSS, At this time there is no information available - * about the security paramters, so initialise the encryption type to + * about the security parameters, so initialise the encryption type to * eCSR_ENCRYPT_TYPE_WEP40_STATICKEY. * The correct security parameters will be updated later in * wlan_hdd_cfg80211_add_key */ @@ -10834,7 +10840,7 @@ static int __wlan_hdd_cfg80211_get_station(struct wiphy *wiphy, else mode = 0; - /* VHT80 rate has seperate rate table */ + /* VHT80 rate has separate rate table */ if (rate_flags & (eHAL_TX_RATE_VHT20|eHAL_TX_RATE_VHT40|eHAL_TX_RATE_VHT80)) { ccmCfgGetInt(WLAN_HDD_GET_HAL_CTX(pAdapter), WNI_CFG_VHT_TX_MCS_MAP, &vht_mcs_map); @@ -11753,7 +11759,7 @@ static int __wlan_hdd_cfg80211_sched_scan_start(struct wiphy *wiphy, ret = wlan_hdd_scan_abort(pAdapter); if(ret < 0){ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR, - "%s: aborting the existing scan is unsuccessfull", __func__); + "%s: aborting the existing scan is unsuccessful", __func__); return -EBUSY; } } @@ -11892,9 +11898,9 @@ static int __wlan_hdd_cfg80211_sched_scan_start(struct wiphy *wiphy, pPnoRequest->us5GProbeTemplateLen); } - /* Driver gets only one time interval which is hardcoded in + /* Driver gets only one time interval which is hard coded in * supplicant for 10000ms. Taking power consumption into account 6 timers - * will be used, Timervalue is increased exponentially i.e 10,20,40, + * will be used, Timer value is increased exponentially i.e 10,20,40, * 80,160,320 secs. And number of scan cycle for each timer * is configurable through INI param gPNOScanTimerRepeatValue. * If it is set to 0 only one timer will be used and PNO scan cycle @@ -12166,7 +12172,7 @@ static int wlan_hdd_cfg80211_tdls_mgmt(struct wiphy *wiphy, struct net_device *d { /* supplicant still sends tdls_mgmt(SETUP_REQ) even after we return error code at 'add_station()'. Hence we have this - check again in addtion to add_station(). + check again in addition to add_station(). Anyway, there is no hard to double-check. */ if (SIR_MAC_TDLS_SETUP_REQ == action_code) { @@ -12441,8 +12447,11 @@ static int __wlan_hdd_cfg80211_tdls_oper(struct wiphy *wiphy, wlan_hdd_tdls_timer_restart(pAdapter, &pTdlsPeer->initiatorWaitTimeoutTimer, WAIT_TIME_TDLS_INITIATOR); - /* suspend initiator TX until it receives direct packet from the - reponder or WAIT_TIME_TDLS_INITIATOR timer expires */ + /* + * Suspend initiator TX until it receives direct + * packet from the responder or + * WAIT_TIME_TDLS_INITIATOR timer expires + */ WLANTL_SuspendDataTx( (WLAN_HDD_GET_CTX(pAdapter))->pvosContext, &staId, NULL); } @@ -12708,7 +12717,7 @@ int wlan_hdd_cfg80211_send_tdls_discover_req(struct wiphy *wiphy, #ifdef WLAN_FEATURE_GTK_OFFLOAD /* * FUNCTION: wlan_hdd_cfg80211_update_replayCounterCallback - * Callback rountine called upon receiving response for + * Callback routine called upon receiving response for * get offload info */ void wlan_hdd_cfg80211_update_replayCounterCallback(void *callbackContext, @@ -12831,7 +12840,7 @@ int __wlan_hdd_cfg80211_set_rekey_data(struct wiphy *wiphy, hddLog(LOGE, FL("sme_SetGTKOffload failed, status(%d)"), status); return -EINVAL; } - hddLog(LOG1, FL("sme_SetGTKOffload successfull")); + hddLog(LOG1, FL("sme_SetGTKOffload successful")); } else { hddLog(LOG1, FL("wlan not suspended GTKOffload request is stored")); } @@ -13365,7 +13374,7 @@ int __wlan_hdd_cfg80211_resume_wlan(struct wiphy *wiphy) hddLog(LOG1, FL("Return resume is not due to PNO indication")); return 0; } - /* Reset flag to avoid updatating cfg80211 data old results again */ + /* Reset flag to avoid updating cfg80211 data old results again */ pHddCtx->isSchedScanUpdatePending = FALSE; spin_unlock(&pHddCtx->schedScan_lock); @@ -13379,7 +13388,7 @@ int __wlan_hdd_cfg80211_resume_wlan(struct wiphy *wiphy) hddLog(LOGW, FL("NO SCAN result")); } else { /* Acquire wakelock to handle the case where APP's tries to - * suspend immediately after updating the scan results. Whis + * suspend immediately after updating the scan results. This * results in app's is in suspended state and not able to * process the connect request to AP */ diff --git a/CORE/HDD/src/wlan_hdd_dev_pwr.c b/CORE/HDD/src/wlan_hdd_dev_pwr.c index 395fd0e137ff..8d9c7ef376b8 100644 --- a/CORE/HDD/src/wlan_hdd_dev_pwr.c +++ b/CORE/HDD/src/wlan_hdd_dev_pwr.c @@ -71,7 +71,7 @@ * 10 frame means 2seconds TX operation */ static const hdd_tmLevelAction_t thermalMigrationAction[WLAN_HDD_TM_LEVEL_MAX] = { - /* TM Level 0, Do nothing, just normal operaton */ + /* TM Level 0, Do nothing, just normal operation */ {1, 0, 0, 0, 0xFFFFF}, /* Tm Level 1, disable TX AMPDU */ {0, 0, 0, 0, 0xFFFFF}, diff --git a/CORE/HDD/src/wlan_hdd_dp_utils.c b/CORE/HDD/src/wlan_hdd_dp_utils.c index a58d068fd58a..a570e3c566c8 100644 --- a/CORE/HDD/src/wlan_hdd_dp_utils.c +++ b/CORE/HDD/src/wlan_hdd_dp_utils.c @@ -49,7 +49,7 @@ ----------------------------------------------------------------------------*/ /**----------------------------------------------------------------------------- - Function declarations and documenation + Function declarations and documentation ----------------------------------------------------------------------------*/ diff --git a/CORE/HDD/src/wlan_hdd_early_suspend.c b/CORE/HDD/src/wlan_hdd_early_suspend.c index f32bc2b73a54..e9e6329ce3c7 100644 --- a/CORE/HDD/src/wlan_hdd_early_suspend.c +++ b/CORE/HDD/src/wlan_hdd_early_suspend.c @@ -1232,7 +1232,7 @@ static void hdd_conf_resume_ind(hdd_adapter_t *pAdapter) #ifdef WLAN_FEATURE_PACKET_FILTERING - /* Filer was applied during suspend inditication + /* Filter was applied during suspend indication * clear it when we resume. */ wlan_hdd_set_mc_addr_list(pAdapter, FALSE); @@ -1385,7 +1385,7 @@ static void hdd_PowerStateChangedCB /* Android framework can send resume request when the WCN chip is * in IMPS mode. When the chip exits IMPS mode the firmware will * restore all the registers to the state they were before the chip - * entered IMPS and so our hardware filter settings confgured by the + * entered IMPS and so our hardware filter settings configured by the * resume request will be lost. So reconfigure the filters on detecting * a change in the power state of the WCN chip. */ @@ -1498,7 +1498,7 @@ void hdd_conf_gtk_offload(hdd_adapter_t *pAdapter, v_BOOL_t fenable) } VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO, - "%s: sme_SetGTKOffload successfull", __func__); + "%s: sme_SetGTKOffload successful", __func__); } } @@ -1528,7 +1528,7 @@ void hdd_conf_gtk_offload(hdd_adapter_t *pAdapter, v_BOOL_t fenable) "%s: sme_GetGTKOffload successful", __func__); - /* Sending GTK offload dissable */ + /* Sending GTK offload disable */ memcpy(&hddGtkOffloadReqParams, &pHddStaCtx->gtkOffloadReqParams, sizeof (tSirGtkOffloadParams)); hddGtkOffloadReqParams.ulFlags = GTK_OFFLOAD_DISABLE; @@ -1537,12 +1537,12 @@ void hdd_conf_gtk_offload(hdd_adapter_t *pAdapter, v_BOOL_t fenable) if (eHAL_STATUS_SUCCESS != ret) { VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR, - "%s: failed to dissable GTK offload, returned %d", + "%s: failed to disable GTK offload, returned %d", __func__, ret); return; } VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_INFO, - "%s: successfully dissabled GTK offload request to HAL", + "%s: successfully disabled GTK offload request to HAL", __func__); } } @@ -1690,7 +1690,7 @@ VOS_STATUS hdd_wlan_reset_initialization(void) /* - * Based on the ioctl command recieved by HDD, put WLAN driver + * Based on the ioctl command received by HDD, put WLAN driver * into the quiet mode. This is the same as the early suspend * notification that driver used to listen */ diff --git a/CORE/HDD/src/wlan_hdd_ftm.c b/CORE/HDD/src/wlan_hdd_ftm.c index c69dd28a1f43..72139202f967 100644 --- a/CORE/HDD/src/wlan_hdd_ftm.c +++ b/CORE/HDD/src/wlan_hdd_ftm.c @@ -379,7 +379,7 @@ static VOS_STATUS wlan_ftm_vos_open( v_CONTEXT_t pVosContext, v_SIZE_t hddContex goto err_wda_close; } - /* If we arrive here, both threads dispacthing messages correctly */ + /* If we arrive here, both threads dispatching messages correctly */ /* Now proceed to open the MAC */ @@ -711,8 +711,9 @@ int wlan_hdd_ftm_open(hdd_context_t *pHddCtx) goto err_vos_status_failure; } - /* - For Integrated SOC, only needed to start WDA, whihc happens in wlan_hdd_ftm_start() + /* + * For Integrated SOC, only needed to start WDA, + * which happens in wlan_hdd_ftm_start() */ /* Save the hal context in Adapter */ pHddCtx->hHal = (tHalHandle)vos_get_context(VOS_MODULE_ID_SME, pVosContext ); diff --git a/CORE/HDD/src/wlan_hdd_hostapd.c b/CORE/HDD/src/wlan_hdd_hostapd.c index 3f07e4c682f6..b925ea5e3c60 100644 --- a/CORE/HDD/src/wlan_hdd_hostapd.c +++ b/CORE/HDD/src/wlan_hdd_hostapd.c @@ -104,7 +104,7 @@ extern int process_wma_set_command(int sessid, int paramid, (IS_UP((_ic)->ic_dev) && (_ic)->ic_roaming == IEEE80211_ROAMING_AUTO) #define WE_WLAN_VERSION 1 #define WE_GET_STA_INFO_SIZE 30 -/* WEXT limition: MAX allowed buf len for any * +/* WEXT limitation: MAX allowed buf len for any * * IW_PRIV_TYPE_CHAR is 2Kbytes * */ #define WE_SAP_MAX_STA_INFO 0x7FF @@ -132,7 +132,7 @@ extern int process_wma_set_command(int sessid, int paramid, --------------------------------------------------------------------------*/ void hdd_hostapd_channel_wakelock_init(hdd_context_t *pHddCtx) { - /* Iniitialize the wakelock */ + /* Initialize the wakelock */ vos_wake_lock_init(&pHddCtx->sap_dfs_wakelock, "sap_dfs_wakelock"); atomic_set(&pHddCtx->sap_dfs_ref_cnt, 0); } @@ -326,7 +326,7 @@ static void hdd_hostapd_uninit (struct net_device *dev) @param dev : [in] pointer to Libra network device @return : NET_XMIT_DROP if packets are dropped - : NET_XMIT_SUCCESS if packet is enqueued succesfully + : NET_XMIT_SUCCESS if packet is enqueued successfully ===========================================================================*/ int hdd_hostapd_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) { @@ -398,7 +398,7 @@ static int hdd_hostapd_driver_command(hdd_adapter_t *pAdapter, { /* * command should be a string having format - * SET_SAP_CHANNEL_LIST <num channels> <channels seperated by spaces> + * SET_SAP_CHANNEL_LIST <num channels> <channels separated by spaces> */ hddLog(VOS_TRACE_LEVEL_INFO, "%s: Received Command to Set Preferred Channels for SAP", @@ -577,7 +577,7 @@ void hdd_restart_softap(hdd_context_t *pHddCtx, \brief hdd_hostapd_set_mac_address() - This function sets the user specified mac address using - the command ifconfig wlanX hw ether <mac adress>. + the command ifconfig wlanX hw ether <mac address>. \param - dev - Pointer to the net device. - addr - Pointer to the sockaddr. @@ -1052,12 +1052,14 @@ VOS_STATUS hdd_hostapd_SAPEventCB( tpSap_Event pSapEvent, v_PVOID_t usrDataForCa break; case eSAP_STA_SET_KEY_EVENT: - //TODO: forward the message to hostapd once implementtation is done for now just print + /* TODO: forward the message to hostapd once implementation + is done for now just print */ hddLog(LOG1, FL("SET Key: configured status = %s"),pSapEvent->sapevt.sapStationSetKeyCompleteEvent.status ? "eSAP_STATUS_FAILURE" : "eSAP_STATUS_SUCCESS"); return VOS_STATUS_SUCCESS; case eSAP_STA_DEL_KEY_EVENT: - //TODO: forward the message to hostapd once implementtation is done for now just print + /* TODO: forward the message to hostapd once implementation + is done for now just print */ hddLog(LOG1, FL("Event received %s"),"eSAP_STA_DEL_KEY_EVENT"); return VOS_STATUS_SUCCESS; case eSAP_STA_MIC_FAILURE_EVENT: @@ -1550,7 +1552,7 @@ stopbss : if (eSAP_STOP_BSS_EVENT == sapEvent) vos_event_set(&pHostapdState->vosEvent); - /* notify userspace that the BSS has stopped */ + /* Notify user space that the BSS has stopped */ memset(&we_custom_event, '\0', sizeof(we_custom_event)); memcpy(&we_custom_event, stopBssEvent, event_len); memset(&wrqu, 0, sizeof(wrqu)); @@ -3039,7 +3041,7 @@ static iw_display_data_path_snapshot(struct net_device *dev, union iwreq_data *wrqu, char *extra) { - /* Function intitiating dumping states of + /* Function initiating dumping states of * HDD(WMM Tx Queues) * TL State (with Per Client infor) * DXE Snapshot (Called at the end of TL Snapshot) @@ -3084,7 +3086,7 @@ static iw_softap_set_tx_power(struct net_device *dev, /**--------------------------------------------------------------------------- \brief iw_softap_set_trafficmonitor() - - This function dynamically enable/disable traffic monitor functonality + This function dynamically enable/disable traffic monitor functionality the command iwpriv wlanX setTrafficMon <value>. \param - dev - Pointer to the net device. @@ -3113,25 +3115,25 @@ static iw_softap_getassoc_stamacaddr(struct net_device *dev, int cnt = 0; int left; int ret = 0; - /* maclist_index must be u32 to match userspace */ + /* maclist_index must be u32 to match user space */ u32 maclist_index; /* * NOTE WELL: this is a "get" ioctl but it uses an even ioctl * number, and even numbered iocts are supposed to have "set" * semantics. Hence the wireless extensions support in the kernel - * won't correctly copy the result to userspace, so the ioctl + * won't correctly copy the result to user space, so the ioctl * handler itself must copy the data. Output format is 32-bit * record length, followed by 0 or more 6-byte STA MAC addresses. * * Further note that due to the incorrect semantics, the "iwpriv" - * userspace application is unable to correctly invoke this API, + * user space application is unable to correctly invoke this API, * hence it is not registered in the hostapd_private_args. This * API can only be invoked by directly invoking the ioctl() system * call. */ - /* make sure userspace allocated a reasonable buffer size */ + /* Make sure user space allocated a reasonable buffer size */ if (wrqu->data.length < sizeof(maclist_index)) { hddLog(LOG1, "%s: invalid userspace buffer", __func__); return -EINVAL; @@ -3491,7 +3493,7 @@ static int iw_set_ap_encodeext(struct net_device *dev, } if(!ext->key_len) { #if 0 - /*Set the encrytion type to NONE*/ + /*Set the encryption type to NONE*/ #if 0 pRoamProfile->EncryptionType.encryptionType[0] = eCSR_ENCRYPT_TYPE_NONE; #endif diff --git a/CORE/HDD/src/wlan_hdd_ipa.c b/CORE/HDD/src/wlan_hdd_ipa.c index fc53fbd23e27..42f45d8f1d8c 100644 --- a/CORE/HDD/src/wlan_hdd_ipa.c +++ b/CORE/HDD/src/wlan_hdd_ipa.c @@ -1273,7 +1273,7 @@ static void hdd_ipa_rm_notify(void *user_data, enum ipa_rm_event event, #endif /* IPA_UC_OFFLOAD */ break; default: - HDD_IPA_LOG(VOS_TRACE_LEVEL_ERROR, "Unknow RM Evt: %d", event); + HDD_IPA_LOG(VOS_TRACE_LEVEL_ERROR, "Unknown RM Evt: %d", event); break; } } @@ -3162,7 +3162,7 @@ VOS_STATUS hdd_ipa_cleanup(hdd_context_t *hdd_ctx) adf_os_spinlock_destroy(&hdd_ipa->pm_lock); - /* destory the interface lock */ + /* Destroy the interface lock */ for (i = 0; i < HDD_IPA_MAX_IFACE; i++) { iface_context = &hdd_ipa->iface_context[i]; adf_os_spinlock_destroy(&iface_context->interface_lock); diff --git a/CORE/HDD/src/wlan_hdd_main.c b/CORE/HDD/src/wlan_hdd_main.c index aef77a2e8647..39cf55188aff 100755 --- a/CORE/HDD/src/wlan_hdd_main.c +++ b/CORE/HDD/src/wlan_hdd_main.c @@ -222,7 +222,7 @@ static VOS_STATUS hdd_parse_ese_beacon_req(tANI_U8 *pValue, #define WLAN_HDD_DRIVER_MIRACAST_CFG_MAX_VAL 2 /* - * When ever we need to print IBSSPEERINFOALL for morethan 16 STA + * When ever we need to print IBSSPEERINFOALL for more than 16 STA * we will split the printing. */ #define NUM_OF_STA_DATA_TO_PRINT 16 @@ -754,10 +754,10 @@ void hdd_register_mcast_bcast_filter(hdd_context_t *pHddCtx); static int con_mode; #ifndef MODULE /* current con_mode - used only for statically linked driver - * con_mode is changed by userspace to indicate a mode change which will + * con_mode is changed by user space to indicate a mode change which will * result in calling the module exit and init functions. The module * exit function will clean up based on the value of con_mode prior to it - * being changed by userspace. So curr_con_mode records the current con_mode + * being changed by user space. So curr_con_mode records the current con_mode * for exit when con_mode becomes the next mode for init */ static int curr_con_mode; @@ -1074,11 +1074,11 @@ VOS_STATUS hdd_setIbssPowerSaveParams(hdd_adapter_t *pAdapter) \param - base Base for string to int conversion(10 for decimal 16 for hex) \param - pOutPtr Pointer to variable in which extracted integer needs to be assigned - \param - pLastArg to tell whether it is last arguement in input string or + \param - pLastArg to tell whether it is last argument in input string or not \return - NULL for failure cases - pointer to next arguement in input string for success cases + pointer to next argument in input string for success cases --------------------------------------------------------------------------*/ static tANI_U8 * hdd_extract_assigned_int_from_str @@ -1144,11 +1144,11 @@ hdd_extract_assigned_int_from_str \param - pInPtr Pointer to input string \param - pOutPtr Pointer to variable in which extracted char needs to be assigned - \param - pLastArg to tell whether it is last arguement in input string or + \param - pLastArg to tell whether it is last argument in input string or not \return - NULL for failure cases - pointer to next arguement in input string for success cases + pointer to next argument in input string for success cases --------------------------------------------------------------------------*/ static tANI_U8 * hdd_extract_assigned_char_from_str @@ -1189,7 +1189,7 @@ hdd_extract_assigned_char_from_str \brief hdd_parse_set_batchscan_command () - HDD parse set batch scan command This function parses set batch scan command in below format: - WLS_BATCHING_SET <space> followed by below arguements + WLS_BATCHING_SET <space> followed by below arguments "SCANFREQ=XX" : Optional defaults to 30 sec "MSCAN=XX" : Required number of scans to attempt to batch "BESTN=XX" : Best Network (RSSI) defaults to 16 @@ -1202,7 +1202,7 @@ hdd_extract_assigned_char_from_str For example input commands: 1) WLS_BATCHING_SET SCANFREQ=60 MSCAN=10 BESTN=20 CHANNEL=A RTT=0 -> This is translated into set batch scan with following parameters: - a) Frequence 60 seconds + a) Frequency 60 seconds b) Batch 10 scans together c) Best RSSI to be 20 d) 5GHz band only @@ -1634,7 +1634,7 @@ static void hdd_batch_scan_result_ind_callback } mutex_lock(&pAdapter->hdd_batch_scan_lock); - /*store batch scan repsonse in hdd queue*/ + /*store batch scan response in hdd queue*/ hdd_populate_batch_scan_rsp_queue(pAdapter, pApMetaInfo, pScanList->scanId, isLastAp); mutex_unlock(&pAdapter->hdd_batch_scan_lock); @@ -1694,28 +1694,34 @@ hdd_format_batch_scan_rsp tANI_U8 temp[HDD_BATCH_SCAN_AP_META_INFO_SIZE]; tANI_U8 *pTemp = temp; - /*Batch scan reponse needs to be returned to user space in - following format: - "scancount=X\n" where X is the number of scans in current batch - batch - "trunc\n" optional present if current scan truncated - "bssid=XX:XX:XX:XX:XX:XX\n" - "ssid=XXXX\n" - "freq=X\n" frequency in Mhz - "level=XX\n" - "age=X\n" ms - "dist=X\n" cm (-1 if not available) - "errror=X\n" (-1if not available) - "====\n" (end of ap marker) - "####\n" (end of scan marker) - "----\n" (end of results)*/ - /*send scan result in above format to user space based on - available length*/ - /*The GET response may have more data than the driver can return in its - buffer. In that case the buffer should be filled to the nearest complete - scan, ending with "%%%%".Subsequent callsshould return the remaining data - starting with the next scan (optional .trunc\n., .apcount=X\n., etc). - The final buffer should end with "----\n"*/ + /* + * Batch scan response needs to be returned to user space in + * following format: + * "scancount=X\n" where X is the number of scans in current batch + * batch + * "trunc\n" optional present if current scan truncated + * "bssid=XX:XX:XX:XX:XX:XX\n" + * "ssid=XXXX\n" + * "freq=X\n" frequency in Mhz + * "level=XX\n" + * "age=X\n" ms + * "dist=X\n" cm (-1 if not available) + * "errror=X\n" (-1if not available) + * "====\n" (end of ap marker) + * "####\n" (end of scan marker) + * "----\n" (end of results) + * + * Send scan result in above format to user space based on + * available length. + */ + + /* + * The GET response may have more data than the driver can return in its + * buffer. In that case the buffer should be filled to the nearest complete + * scan, ending with "%%%%".Subsequent calls should return the remaining + * data starting with the next scan (optional .trunc\n., .apcount=X\n., etc) + * The final buffer should end with "----\n" + */ /*sanity*/ if (cur_len > tot_len) @@ -2294,7 +2300,7 @@ exit: #if defined (WLAN_FEATURE_VOWIFI_11R) || defined (FEATURE_WLAN_ESE) || defined(FEATURE_WLAN_LFR) /* - \brief hdd_reassoc() - perform a userspace-directed reassoc + \brief hdd_reassoc() - perform a user space-directed reassoc \param - pAdapter - Adapter upon which the command was received \param - bssid - BSSID with which to reassociate @@ -2470,7 +2476,7 @@ hdd_parse_reassoc(hdd_adapter_t *pAdapter, const char *command) #if defined (WLAN_FEATURE_VOWIFI_11R) || defined (FEATURE_WLAN_ESE) || defined(FEATURE_WLAN_LFR) /* - \brief hdd_sendactionframe() - send a userspace-supplied action frame + \brief hdd_sendactionframe() - send a user space supplied action frame \param - pAdapter - Adapter upon which the command was received \param - bssid - BSSID target of the action frame @@ -4034,9 +4040,9 @@ static int hdd_driver_command(hdd_adapter_t *pAdapter, } /* - command should be a string having format - SET_SAP_CHANNEL_LIST <num of channels> <the channels seperated by spaces> - */ + * Command should be a string having format + * SET_SAP_CHANNEL_LIST <num of channels> <channels separated by spaces> + */ else if (strncmp(command, "SET_SAP_CHANNEL_LIST", 20) == 0) { tANI_U8 *ptr = command; @@ -4332,7 +4338,8 @@ static int hdd_driver_command(hdd_adapter_t *pAdapter, tANI_U8 len = 0; /* - * roamMode value shall be inverted because the sementics is different. + * roamMode value shall be inverted because the semantics is + * different. */ if (CFG_LFR_FEATURE_ENABLED_MIN == roamMode) roamMode = CFG_LFR_FEATURE_ENABLED_MAX; @@ -5546,7 +5553,7 @@ static int hdd_driver_command(hdd_adapter_t *pAdapter, rateUpdateParams->ucastDataRate = -1; /* - * Fill the user specifieed RMC rate param + * Fill the user specified RMC rate param * and the derived tx flags. */ rateUpdateParams->nss = (pConfig->enable2x2 == 0) ? 0 : 1; @@ -6388,7 +6395,7 @@ void hdd_getBand_helper(hdd_context_t *pHddCtx, int *pBand) * i) The mac address of the first interface is just the actual hw mac address. * ii) MSM 3 or 4 bits of byte5 of the actual mac address are used to * define the mac address for the remaining interfaces and locally - * admistered bit is set. INTF_MACADDR_MASK is based on the number of + * administered bit is set. INTF_MACADDR_MASK is based on the number of * supported virtual interfaces, right now this is 0x07 (meaning 8 interface). * Byte[3] of second interface will be hw_macaddr[3](bit5..7) + 1, * for third interface it will be hw_macaddr[3](bit5..7) + 2, etc. @@ -6580,7 +6587,7 @@ static void hdd_update_tgt_ht_cap(hdd_context_t *hdd_ctx, val32, NULL, eANI_BOOLEAN_FALSE); if (status != eHAL_STATUS_SUCCESS) VOS_TRACE(VOS_MODULE_ID_VOSS, VOS_TRACE_LEVEL_FATAL, - "%s: could not set HT capabilty to CCM", + "%s: could not set HT capability to CCM", __func__); #define WLAN_HDD_RX_MCS_ALL_NSTREAM_RATES 0xff value = SIZE_OF_SUPPORTED_MCS_SET; @@ -6824,7 +6831,7 @@ static void hdd_update_tgt_vht_cap(hdd_context_t *hdd_ctx, } } - /* check and update SU BEAMFORMEE capabality*/ + /* check and update SU BEAMFORMEE capability*/ if (pconfig->enableTxBF && !cfg->vht_su_bformee) pconfig->enableTxBF = cfg->vht_su_bformee; @@ -7802,12 +7809,12 @@ static void hdd_uninit (struct net_device *dev) } /**--------------------------------------------------------------------------- - \brief hdd_full_pwr_cbk() - HDD full power callbackfunction + \brief hdd_full_pwr_cbk() - HDD full power callback function This is the function invoked by SME to inform the result of a full power request issued by HDD - \param - callbackcontext - Pointer to cookie + \param - callback context - Pointer to cookie status - result of request \return - None @@ -7831,7 +7838,7 @@ void hdd_full_pwr_cbk(void *callbackContext, eHalStatus status) This is the function invoked by SME to inform the result of BMPS request issued by HDD - \param - callbackcontext - Pointer to cookie + \param - callback context - Pointer to cookie status - result of request \return - None @@ -8182,7 +8189,7 @@ static eHalStatus hdd_smeCloseSessionCallback(void *pContext) !defined (WLAN_OPEN_SOURCE) /* need to make sure all of our scheduled work has completed. * This callback is called from MC thread context, so it is safe to - * to call below flush workqueue API from here. + * to call below flush work queue API from here. * * Even though this is called from MC thread context, if there is a faulty * work item in the system, that can hang this call forever. So flushing @@ -8198,7 +8205,7 @@ static eHalStatus hdd_smeCloseSessionCallback(void *pContext) * flushed, and the adapter structure can potentially be freed, in * which case the magic will have been reset. So make sure the * magic is still good, and hence the adapter structure is still - * valid, before signaling completion */ + * valid, before signalling completion */ if (WLAN_HDD_ADAPTER_MAGIC == pAdapter->magic) { complete(&pAdapter->session_close_comp_var); @@ -8902,7 +8909,7 @@ hdd_adapter_t* hdd_open_adapter( hdd_context_t *pHddCtx, tANI_U8 session_type, pAdapter->sessionCtx.monitor.pAdapterForTx = hdd_get_adapter(pAdapter->pHddCtx, WLAN_HDD_P2P_GO); } - /* This workqueue will be used to transmit management packet over + /* This work queue will be used to transmit management packet over * monitor interface. */ if (NULL == pAdapter->sessionCtx.monitor.pAdapterForTx) { hddLog(VOS_TRACE_LEVEL_ERROR,"%s:Failed:hdd_get_adapter",__func__); @@ -10249,7 +10256,7 @@ void wlan_hdd_set_monitor_tx_adapter( hdd_context_t *pHddCtx, hdd_adapter_t *pAd \param - pHddCtx - Pointer to the HDD context. - mode - Device mode for which operating channel is required - suported modes - WLAN_HDD_INFRA_STATION, WLAN_HDD_P2P_CLIENT + supported modes - WLAN_HDD_INFRA_STATION, WLAN_HDD_P2P_CLIENT WLAN_HDD_SOFTAP, WLAN_HDD_P2P_GO. \return - channel number. "0" id the requested device is not found OR it is not connected. --------------------------------------------------------------------------*/ @@ -10440,7 +10447,7 @@ void hdd_wlan_initial_scan(hdd_adapter_t *pAdapter) This is the function invoked by SME to inform the result of a full power request issued by HDD - \param - callbackcontext - Pointer to cookie + \param - callback context - Pointer to cookie \param - status - result of request \return - None @@ -10611,19 +10618,21 @@ void hdd_wlan_exit(hdd_context_t *pHddCtx) hddLog(VOS_TRACE_LEVEL_FATAL,"%s: hddDevTmUnregisterNotifyCallback failed",__func__); } - // Cancel any outstanding scan requests. We are about to close all - // of our adapters, but an adapter structure is what SME passes back - // to our callback function. Hence if there are any outstanding scan - // requests then there is a race condition between when the adapter - // is closed and when the callback is invoked. We try to resolve that - // race condition here by canceling any outstanding scans before we - // close the adapters. - // Note that the scans may be cancelled in an asynchronous manner, so - // ideally there needs to be some kind of synchronization. Rather than - // introduce a new synchronization here, we will utilize the fact that - // we are about to Request Full Power, and since that is synchronized, - // the expectation is that by the time Request Full Power has completed, - // all scans will be cancelled. + /* + * Cancel any outstanding scan requests. We are about to close all + * of our adapters, but an adapter structure is what SME passes back + * to our callback function. Hence if there are any outstanding scan + * requests then there is a race condition between when the adapter + * is closed and when the callback is invoked. We try to resolve that + * race condition here by cancelling any outstanding scans before we + * close the adapters. + * Note that the scans may be cancelled in an asynchronous manner, so + * ideally there needs to be some kind of synchronization. Rather than + * introduce a new synchronization here, we will utilize the fact that + * we are about to Request Full Power, and since that is synchronized, + * the expectation is that by the time Request Full Power has completed, + * all scans will be cancelled. + */ hdd_abort_mac_scan_all_adapters(pHddCtx); /* Stop the traffic monitor timer */ @@ -11547,14 +11556,15 @@ int hdd_wlan_startup(struct device *dev, v_VOID_t *hif_sc) } } - /* If SNR Monitoring is enabled, FW has to parse all beacons - * for calcaluting and storing the average SNR, so set Nth beacon - * filter to 1 to enable FW to parse all the beaocons + /* + * If SNR Monitoring is enabled, FW has to parse all beacons + * for calculating and storing the average SNR, so set Nth beacon + * filter to 1 to enable FW to parse all the beacons */ if (1 == pHddCtx->cfg_ini->fEnableSNRMonitoring) { /* The log level is deliberately set to WARN as overriding - * nthBeaconFilter to 1 will increase power cosumption and this + * nthBeaconFilter to 1 will increase power consumption and this * might just prove helpful to detect the power issue. */ hddLog(VOS_TRACE_LEVEL_WARN, @@ -11868,7 +11878,8 @@ int hdd_wlan_startup(struct device *dev, v_VOID_t *hif_sc) } - /* target hw version/revision would only be retrieved after firmware donwload */ + /* Target hw version/revision would only be retrieved after + firmware download */ hif_get_hw_info(hif_sc, &pHddCtx->target_hw_version, &pHddCtx->target_hw_revision); @@ -12302,7 +12313,7 @@ success: \brief hdd_driver_init() - Core Driver Init Function - This is the driver entry point - called in different timeline depending + This is the driver entry point - called in different time line depending on whether the driver is statically or dynamically linked \param - None @@ -12466,7 +12477,7 @@ static int __init hdd_module_init ( void) \brief hdd_driver_exit() - Exit function This is the driver exit point (invoked when module is unloaded using rmmod - or con_mode was changed by userspace) + or con_mode was changed by user space) \param - None @@ -12591,8 +12602,8 @@ static int con_mode_handler(const char *kmessage, This is the driver entry point - delayed driver initialization when driver is statically linked - - invoked when module parameter fwpath is modified from userspace to signal - initializing the WLAN driver or when con_mode is modified from userspace + - invoked when module parameter fwpath is modified from user space to signal + initializing the WLAN driver or when con_mode is modified from user space to signal a switch in operating mode \return - 0 for success, non zero for failure @@ -12642,7 +12653,7 @@ static int fwpath_changed_handler(const char *kmessage, \brief con_mode_handler() - - Handler function for module param con_mode when it is changed by userspace + Handler function for module param con_mode when it is changed by user space Dynamically linked - do nothing Statically linked - exit and init driver, as in rmmod and insmod @@ -12991,7 +13002,7 @@ void wlan_hdd_decr_active_session(hdd_context_t *pHddCtx, tVOS_CON_MODE mode) * * \brief wlan_hdd_restart_init * - * This function initalizes restart timer/flag. An internal function. + * This function initializes restart timer/flag. An internal function. * * \param - pHddCtx * @@ -13062,7 +13073,7 @@ static VOS_STATUS wlan_hdd_framework_restart(hdd_context_t *pHddCtx) int len = (sizeof (struct ieee80211_mgmt)); struct ieee80211_mgmt *mgmt = NULL; - /* Prepare the DEAUTH managment frame with reason code */ + /* Prepare the DEAUTH management frame with reason code */ mgmt = kzalloc(len, GFP_KERNEL); if(mgmt == NULL) { @@ -13188,7 +13199,7 @@ VOS_STATUS hdd_issta_p2p_clientconnected(hdd_context_t *pHddCtx) \param - freq input frequency with order of MHz \return - corresponding channel number. - incannot find correct channel number, return 0 + if cannot find correct channel number, return 0 --------------------------------------------------------------------------*/ v_U16_t hdd_freq_to_chn @@ -13214,7 +13225,7 @@ v_U16_t hdd_freq_to_chn \brief hdd_ch_avoid_cb() - Avoid channel notification from FW handler. - FW will send un-safe channle list to avoid overwrapping. + FW will send un-safe channel list to avoid over wrapping. hostapd should not use notified channel \param - pAdapter HDD adapter pointer @@ -13751,7 +13762,7 @@ void wlan_hdd_auto_shutdown_enable(hdd_context_t *hdd_ctx, v_BOOL_t enable) return; } - /* To enable shutdown timer check conncurrency */ + /* To enable shutdown timer check concurrency */ if (vos_concurrent_open_sessions_running()) { status = hdd_get_front_adapter ( hdd_ctx, &pAdapterNode ); diff --git a/CORE/HDD/src/wlan_hdd_oemdata.c b/CORE/HDD/src/wlan_hdd_oemdata.c index 408eb75dbd3f..bfa49a85baea 100644 --- a/CORE/HDD/src/wlan_hdd_oemdata.c +++ b/CORE/HDD/src/wlan_hdd_oemdata.c @@ -73,20 +73,14 @@ static eHalStatus hdd_OemDataReqCallback(tHalHandle hHal, //now if the status is success, then send an event up //so that the application can request for the data //else no need to send the event up - if(oemDataReqStatus == eOEM_DATA_REQ_FAILURE) - { + if (oemDataReqStatus == eOEM_DATA_REQ_FAILURE) { snprintf(buffer, IW_CUSTOM_MAX, "QCOM: OEM-DATA-REQ-FAILED"); hddLog(LOGW, "%s: oem data req %d failed", __func__, oemDataReqID); - } - else if(oemDataReqStatus == eOEM_DATA_REQ_INVALID_MODE) - { + } else if(oemDataReqStatus == eOEM_DATA_REQ_INVALID_MODE) { snprintf(buffer, IW_CUSTOM_MAX, "QCOM: OEM-DATA-REQ-INVALID-MODE"); hddLog(LOGW, "%s: oem data req %d failed because the driver is in invalid mode (IBSS|BTAMP|AP)", __func__, oemDataReqID); - } - else - { + } else { snprintf(buffer, IW_CUSTOM_MAX, "QCOM: OEM-DATA-REQ-SUCCESS"); - //everything went alright } wrqu.data.pointer = buffer; @@ -376,7 +370,7 @@ int iw_get_oem_data_cap( \brief send_oem_reg_rsp_nlink_msg() - send oem registration response - This function sends oem message to registetred application process + This function sends oem message to registered application process \param - - none @@ -522,7 +516,7 @@ void send_oem_err_rsp_nlink_msg(v_SINT_t app_pid, tANI_U8 error_code) \brief send_oem_data_rsp_msg() - send oem data response - This function sends oem data rsp message to registetred application process + This function sends oem data rsp message to registered application process over the netlink socket. \param - @@ -879,7 +873,7 @@ void hdd_SendPeerStatusIndToOemApp(v_MACADDR_t *peerMac, an OEM application process. \param - - - pAdapter - ponter to HDD adapter + - pAdapter - pointer to HDD adapter \return - 0 for success, non zero for failure @@ -1000,7 +994,7 @@ int oem_msg_callback(struct sk_buff *skb) { /* either oem app is not registered yet or pid is different */ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR, - "%s: OEM DataReq: app not regsitered(%d) or incorrect pid(%d)", + "%s: OEM DataReq: app not registered(%d) or incorrect pid(%d)", __func__, pHddCtx->oem_app_registered, nlh->nlmsg_pid); send_oem_err_rsp_nlink_msg(nlh->nlmsg_pid, OEM_ERR_APP_NOT_REGISTERED); @@ -1032,7 +1026,7 @@ int oem_msg_callback(struct sk_buff *skb) { /* either oem app is not registered yet or pid is different */ VOS_TRACE(VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR, - "%s: Chan InfoReq: app not regsitered(%d) or incorrect pid(%d)", + "%s: Chan InfoReq: app not registered(%d) or incorrect pid(%d)", __func__, pHddCtx->oem_app_registered, nlh->nlmsg_pid); send_oem_err_rsp_nlink_msg(nlh->nlmsg_pid, OEM_ERR_APP_NOT_REGISTERED); diff --git a/CORE/HDD/src/wlan_hdd_p2p.c b/CORE/HDD/src/wlan_hdd_p2p.c index 556983f693a5..92b33b103db9 100644 --- a/CORE/HDD/src/wlan_hdd_p2p.c +++ b/CORE/HDD/src/wlan_hdd_p2p.c @@ -533,7 +533,7 @@ static int wlan_hdd_request_remain_on_channel( struct wiphy *wiphy, /* When P2P-GO and if we are trying to unload the driver then * wlan driver is keep on receiving the remain on channel command * and which is resulting in crash. So not allowing any remain on - * channel requets when Load/Unload is in progress*/ + * channel request when Load/Unload is in progress*/ if (((hdd_context_t*)pAdapter->pHddCtx)->isLoadInProgress || ((hdd_context_t*)pAdapter->pHddCtx)->isUnloadInProgress || hdd_isConnectionInProgress((hdd_context_t *)pAdapter->pHddCtx)) @@ -591,7 +591,7 @@ static int wlan_hdd_request_remain_on_channel( struct wiphy *wiphy, if (vos_status != VOS_STATUS_SUCCESS) { hddLog(VOS_TRACE_LEVEL_ERROR, - "%s: Not able to initalize remain_on_chan timer",__func__); + "%s: Not able to initialize remain_on_chan timer",__func__); } mutex_lock(&cfgState->remain_on_chan_ctx_lock); @@ -1532,7 +1532,7 @@ void hdd_sendActionCnf( hdd_adapter_t *pAdapter, tANI_BOOLEAN actionSendSuccess * *FUNCTION: * This function is called from hdd_hostapd_ioctl function when Driver - * get P2P_SET_NOA comand from wpa_supplicant using private ioctl + * get P2P_SET_NOA command from wpa_supplicant using private ioctl * *LOGIC: * Fill NoA Struct According to P2P Power save Option and Pass it to SME layer @@ -1616,7 +1616,7 @@ int hdd_setP2pNoa( struct net_device *dev, tANI_U8 *command ) * *FUNCTION: * This function is called from hdd_hostapd_ioctl function when Driver - * get P2P_SET_PS comand from wpa_supplicant using private ioctl + * get P2P_SET_PS command from wpa_supplicant using private ioctl * *LOGIC: * Fill NoA Struct According to P2P Power save Option and Pass it to SME layer @@ -1646,7 +1646,7 @@ int hdd_setP2pOpps( struct net_device *dev, tANI_U8 *command ) if (param == NULL) { VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_ERROR, - "%s: strnchr failed to find delimeter", __func__); + "%s: strnchr failed to find delimiter", __func__); return -EINVAL; } param++; @@ -2089,7 +2089,7 @@ void hdd_indicateMgmtFrame( hdd_adapter_t *pAdapter, &pbFrames[WLAN_HDD_80211_FRM_DA_OFFSET]); if (NULL == pAdapter) { - /* Under assumtion that we don't receive any action frame + /* Under assumption that we don't receive any action frame * with BCST as destination we dropping action frame */ hddLog(VOS_TRACE_LEVEL_FATAL,"pAdapter for action frame is NULL Macaddr = " diff --git a/CORE/HDD/src/wlan_hdd_scan.c b/CORE/HDD/src/wlan_hdd_scan.c index e5c5760a2984..6b1657149f5c 100644 --- a/CORE/HDD/src/wlan_hdd_scan.c +++ b/CORE/HDD/src/wlan_hdd_scan.c @@ -1059,7 +1059,7 @@ int iw_set_cscan(struct net_device *dev, struct iw_request_info *info, /* next two offsets contain min and max channel time */ if( WEXT_CSCAN_PASV_DWELL_SECTION == (str_ptr[i]) ) { - /* No SSID specified, num_ssid == 0, then start paasive scan */ + /* No SSID specified, num_ssid == 0, then start passive scan */ if (!num_ssid || (eSIR_PASSIVE_SCAN == pAdapter->scan_info.scan_mode)) { scanRequest.scanType = eSIR_PASSIVE_SCAN; diff --git a/CORE/HDD/src/wlan_hdd_softap_tx_rx.c b/CORE/HDD/src/wlan_hdd_softap_tx_rx.c index 85925a430634..76b5b3ca9bca 100644 --- a/CORE/HDD/src/wlan_hdd_softap_tx_rx.c +++ b/CORE/HDD/src/wlan_hdd_softap_tx_rx.c @@ -62,7 +62,7 @@ -------------------------------------------------------------------------*/ /*--------------------------------------------------------------------------- - Function definitions and documenation + Function definitions and documentation -------------------------------------------------------------------------*/ #if 0 static void hdd_softap_dump_sk_buff(struct sk_buff * skb) @@ -88,8 +88,8 @@ extern void hdd_set_wlan_suspend_mode(bool suspend); /**============================================================================ @brief hdd_softap_traffic_monitor_timeout_handler() - - SAP/P2P GO traffin monitor timeout handler function - If no traffic during programmed time, trigger suspand mode + SAP/P2P GO traffic monitor timeout handler function + If no traffic during programmed time, trigger suspend mode @param pUsrData : [in] pointer to hdd context @return : NONE @@ -151,7 +151,7 @@ VOS_STATUS hdd_start_trafficMonitor( hdd_adapter_t *pAdapter ) pHddCtx->traffic_monitor.isInitialized = 1; pHddCtx->traffic_monitor.lastFrameTs = 0; /* Start traffic monitor timer here - * If no AP assoc, immediatly go into suspend */ + * If no AP assoc, immediately go into suspend */ VOS_TRACE( VOS_MODULE_ID_HDD_SAP_DATA, VOS_TRACE_LEVEL_INFO, "%s Start Traffic Monitor Timer", __func__); vos_timer_start(&pHddCtx->traffic_monitor.trafficTimer, @@ -360,7 +360,7 @@ int hdd_softap_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) #endif /* QCA_PKT_PROTO_TRACE */ ++pAdapter->hdd_stats.hddTxRxStats.txXmitCalled; - /* Prevent this funtion to be called during SSR since TL context may + /* Prevent this function to be called during SSR since TL context may not be reinitialized at this time which will lead crash. */ if (pHddCtx->isLogpInProgress) { @@ -526,7 +526,7 @@ drop_pkt: @param up : [in] User Priority @return : NET_XMIT_DROP if packets are dropped - : NET_XMIT_SUCCESS if packet is enqueued succesfully + : NET_XMIT_SUCCESS if packet is enqueued successfully ===========================================================================*/ VOS_STATUS hdd_softap_sta_2_sta_xmit(struct sk_buff *skb, struct net_device *dev, @@ -584,7 +584,7 @@ VOS_STATUS hdd_softap_sta_2_sta_xmit(struct sk_buff *skb, { VOS_TRACE( VOS_MODULE_ID_HDD_SAP_DATA, VOS_TRACE_LEVEL_WARN, "%s: station %d ac %d queue over limit %d", __func__, STAId, ac, pktListSize); - /* TODO:Rx Flowchart should be trigerred here to SUPEND SSC on RX side. + /* TODO:Rx Flowchart should be triggered here to SUPEND SSC on RX side. * SUSPEND should be done based on Threshold. RESUME would be * triggered in fetch cbk after recovery. */ @@ -734,7 +734,7 @@ VOS_STATUS hdd_softap_init_tx_rx( hdd_adapter_t *pAdapter ) if (VOS_STATUS_SUCCESS != hdd_start_trafficMonitor(pAdapter)) { VOS_TRACE( VOS_MODULE_ID_HDD_SAP_DATA, VOS_TRACE_LEVEL_ERROR, - "%s: failed to start Traffic Monito timer ", __func__ ); + "%s: failed to start Traffic Monitor timer ", __func__ ); return VOS_STATUS_E_INVAL; } return status; @@ -755,7 +755,7 @@ VOS_STATUS hdd_softap_deinit_tx_rx( hdd_adapter_t *pAdapter ) if (VOS_STATUS_SUCCESS != hdd_stop_trafficMonitor(pAdapter)) { VOS_TRACE( VOS_MODULE_ID_HDD_SAP_DATA, VOS_TRACE_LEVEL_ERROR, - "%s: Fail to Stop Traffic Monito timer", __func__ ); + "%s: Fail to Stop Traffic Monitor timer", __func__ ); return VOS_STATUS_E_INVAL; } @@ -848,7 +848,7 @@ VOS_STATUS hdd_softap_init_tx_rx_sta( hdd_adapter_t *pAdapter, v_U8_t STAId, v_M } /**============================================================================ - @brief hdd_softap_deinit_tx_rx_sta() - Deinit function to clean up a statioin in Tx/RX + @brief hdd_softap_deinit_tx_rx_sta() - Deinit function to clean up a station in Tx/RX modules in HDD @param pAdapter : [in] pointer to adapter context @@ -941,7 +941,7 @@ VOS_STATUS hdd_softap_disconnect_tx_rx( hdd_adapter_t *pAdapter ) /**============================================================================ @brief hdd_softap_tx_complete_cbk() - Callback function invoked by TL to indicate that a packet has been transmitted across the bus - succesfully. OS packet resources can be released after this cbk. + successfully. OS packet resources can be released after this cbk. @param vosContext : [in] pointer to VOS context @param pVosPacket : [in] pointer to VOS packet (containing skb) @@ -1218,8 +1218,7 @@ VOS_STATUS hdd_softap_tx_fetch_packet_cbk( v_VOID_t *vosContext, pPktMetaInfo->ucIsEapol = 1; } } - -//xg: @@@@: temporarily disble these. will revisit later + /* xg: @@@@: temporarily disable these. will revisit later */ { pPktMetaInfo->ucUP = pktNode->userPriority; pPktMetaInfo->ucTID = pPktMetaInfo->ucUP; @@ -1338,7 +1337,7 @@ VOS_STATUS hdd_softap_tx_low_resource_cbk( vos_pkt_t *pVosPacket, @param vosContext : [in] pointer to VOS context @param rxBuf : [in] pointer to rx adf_nbuf - @param staId : [in] Station Id (Adress 1 Index) + @param staId : [in] Station Id (Address 1 Index) @return : VOS_STATUS_E_FAILURE if any errors encountered, : VOS_STATUS_SUCCESS otherwise @@ -1441,7 +1440,7 @@ VOS_STATUS hdd_softap_rx_packet_cbk(v_VOID_t *vosContext, @param vosContext : [in] pointer to VOS context @param rx_buf_list : [in] pointer to rx adf_nbuf linked list - @param staId : [in] Station Id (Adress 1 Index) + @param staId : [in] Station Id (Address 1 Index) @return : VOS_STATUS_E_FAILURE if any errors encountered, : VOS_STATUS_SUCCESS otherwise @@ -1461,7 +1460,7 @@ VOS_STATUS hdd_softap_rx_mul_packet_cbk(v_VOID_t *vosContext, if(!VOS_IS_STATUS_SUCCESS(status)) { VOS_TRACE(VOS_MODULE_ID_HDD_SAP_DATA, VOS_TRACE_LEVEL_ERROR, - "%s: RX fail, satus %d", __func__, status); + "%s: RX fail, status %d", __func__, status); return status; } buf = next_buf; @@ -1548,7 +1547,7 @@ VOS_STATUS hdd_softap_RegisterSTA( hdd_adapter_t *pAdapter, hdd_softap_DeregisterSTA( pAdapter, staId ); } - // Get the Station ID from the one saved during the assocation. + /* Get the Station ID from the one saved during the association */ staDesc.ucSTAId = staId; diff --git a/CORE/HDD/src/wlan_hdd_tdls.c b/CORE/HDD/src/wlan_hdd_tdls.c index 6b10f8d915e8..eaec77f0cbdd 100644 --- a/CORE/HDD/src/wlan_hdd_tdls.c +++ b/CORE/HDD/src/wlan_hdd_tdls.c @@ -678,7 +678,7 @@ void wlan_hdd_tdls_exit(hdd_adapter_t *pAdapter) wlan_hdd_tdls_free_scan_request(&pHddCtx->tdls_scan_ctxt); - /* No need to post message during driver unlaod because MC thread is + /* No need to post message during driver unload because MC thread is already shutdown */ if ( !pHddCtx->isUnloadInProgress) { @@ -1018,8 +1018,10 @@ int wlan_hdd_tdls_recv_discovery_resp(hdd_adapter_t *pAdapter, u8 *mac) if (eTDLS_LINK_DISCOVERING == curr_peer->link_status) { - /* Since we are here, it means Throughput threshold is alredy met. Make sure RSSI - threshold is also met before setting up TDLS link*/ + /* + * Since we are here, it means Throughput threshold is already met. + * Make sure RSSI threshold is also met before setting up TDLS link + */ if ((tANI_S32) curr_peer->rssi > (tANI_S32) pHddTdlsCtx->threshold_config.rssi_trigger_threshold) { curr_peer->link_status = eTDLS_LINK_DISCOVERED; @@ -2413,7 +2415,7 @@ int wlan_hdd_tdls_scan_callback (hdd_adapter_t *pAdapter, else if (eTDLS_SUPPORT_ENABLED == pHddCtx->tdls_mode || eTDLS_SUPPORT_EXPLICIT_TRIGGER_ONLY == pHddCtx->tdls_mode) { - /* disable implicit trigger logic & tdls operatoin */ + /* Disable implicit trigger logic & tdls operation */ wlan_hdd_tdls_set_mode(pHddCtx, eTDLS_SUPPORT_DISABLED, FALSE); /* indicate the teardown all connected to peer */ connectedTdlsPeers = wlan_hdd_tdlsConnectedPeers(pAdapter); diff --git a/CORE/HDD/src/wlan_hdd_tx_rx.c b/CORE/HDD/src/wlan_hdd_tx_rx.c index 18195a7996f2..f203f5f8dd76 100644 --- a/CORE/HDD/src/wlan_hdd_tx_rx.c +++ b/CORE/HDD/src/wlan_hdd_tx_rx.c @@ -83,7 +83,7 @@ static struct sk_buff* hdd_mon_tx_fetch_pkt(hdd_adapter_t* pAdapter); -------------------------------------------------------------------------*/ /*--------------------------------------------------------------------------- - Function definitions and documenation + Function definitions and documentation -------------------------------------------------------------------------*/ #ifdef DATA_PATH_UNIT_TEST @@ -205,7 +205,7 @@ static VOS_STATUS hdd_flush_tx_queues( hdd_adapter_t *pAdapter ) break; } spin_unlock_bh(&pAdapter->wmm_tx_queue[i].lock); - // backpressure is no longer in effect + /* Back pressure is no longer in effect */ pAdapter->isTxSuspended[i] = VOS_FALSE; } @@ -217,7 +217,7 @@ static VOS_STATUS hdd_flush_tx_queues( hdd_adapter_t *pAdapter ) in IBSS mode @param pAdapter : [in] pointer to adapter context - : [in] Staion Id + : [in] Station Id @return : VOS_STATUS_E_FAILURE if any errors encountered : VOS_STATUS_SUCCESS otherwise ===========================================================================*/ @@ -337,7 +337,8 @@ static struct sk_buff* hdd_mon_tx_fetch_pkt(hdd_adapter_t* pAdapter) return NULL; } - // if we are in a backpressure situation see if we can turn the hose back on + /* If we are in a back pressure situation see if we can turn the + hose back on */ if ( (pAdapter->isTxSuspended[ac]) && (size <= HDD_TX_QUEUE_LOW_WATER_MARK) ) { @@ -475,7 +476,8 @@ int hdd_mon_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) goto fail; /* too short to be possibly valid */ } - /* check if toal skb length is greater then radio tab header length of not */ + /* Check if total skb length is greater then radio tap + header length of not */ if (unlikely(skb->len < sizeof(struct ieee80211_radiotap_header))) goto fail; /* too short to be possibly valid */ @@ -486,7 +488,7 @@ int hdd_mon_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) /*Strip off the radio tap header*/ rt_hdr_len = ieee80211_get_radiotap_len(skb->data); - /* check if skb length if greator then total radio tap header length ot not*/ + /* Check if skb length if greater then total radio tap header length ot not*/ if (unlikely(skb->len < rt_hdr_len)) goto fail; @@ -509,7 +511,7 @@ int hdd_mon_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) hdr = (struct ieee80211_hdr *)skb->data; /* Send data frames through the normal Data path. In this path we will - * conver rcvd 802.11 packet to 802.3 packet */ + * convert rcvd 802.11 packet to 802.3 packet */ if ( (hdr->frame_control & HDD_FRAME_TYPE_MASK) == HDD_FRAME_TYPE_DATA) { v_U8_t da[6]; @@ -594,11 +596,11 @@ int hdd_mon_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) return NETDEV_TX_OK; } - if ( pktListSize == 1 ) - { - /* In this context we cannot acquire any mutex etc. And to transmit + if (pktListSize == 1) { + /* + * In this context we cannot acquire any mutex etc. And to transmit * this packet we need to call SME API. So to take care of this we will - * schedule a workqueue + * schedule a work queue */ schedule_work(&pPgBkAdapter->monTxWorkQueue); } @@ -621,7 +623,7 @@ fail: If Blocked OS Q is not resumed during timeout period, to prevent permanent stall, resume OS Q forcefully. - @param adapter_context : [in] pointer to vdev apdapter + @param adapter_context : [in] pointer to vdev adapter @return : NONE ===========================================================================*/ @@ -643,7 +645,7 @@ void hdd_tx_resume_timer_expired_handler(void *adapter_context) @brief hdd_tx_resume_cb() - Resume OS TX Q. Q was stopped due to WLAN TX path low resource condition - @param adapter_context : [in] pointer to vdev apdapter + @param adapter_context : [in] pointer to vdev adapter @param tx_resume : [in] TX Q resume trigger @return : NONE @@ -701,7 +703,7 @@ void hdd_tx_resume_cb(void *adapter_context, @param dev : [in] pointer to network device @return : NET_XMIT_DROP if packets are dropped - : NET_XMIT_SUCCESS if packet is enqueued succesfully + : NET_XMIT_SUCCESS if packet is enqueued successfully ===========================================================================*/ int hdd_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) { @@ -828,7 +830,7 @@ int hdd_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) if (!granted) { bool isDefaultAc = VOS_FALSE; /* ADDTS request for this AC is sent, for now - * send this packet through next avaiable lower + * send this packet through next available lower * Access category until ADDTS negotiation completes. */ while (!likely(pAdapter->hddWmmStatus.wmmAcStatus[ac].wmmAcAccessAllowed)) { @@ -1145,7 +1147,7 @@ v_BOOL_t hdd_IsWAIPacket( vos_pkt_t *pVosPacket ) /**============================================================================ @brief hdd_tx_complete_cbk() - Callback function invoked by TL to indicate that a packet has been transmitted across the SDIO bus - succesfully. OS packet resources can be released after this cbk. + successfully. OS packet resources can be released after this cbk. @param vosContext : [in] pointer to VOS context @param pVosPacket : [in] pointer to VOS packet (containing skb) @@ -1485,7 +1487,8 @@ VOS_STATUS hdd_tx_fetch_packet_cbk( v_VOID_t *vosContext, - // if we are in a backpressure situation see if we can turn the hose back on + /* If we are in a back pressure situation see if we can turn the + hose back on */ if ( (pAdapter->isTxSuspended[ac]) && (size <= HDD_TX_QUEUE_LOW_WATER_MARK) ) { @@ -1756,7 +1759,7 @@ void hdd_tx_rx_pkt_cnt_stat_timer_handler( void *phddctx) @param vosContext : [in] pointer to VOS context @param rx_buf_list : [in] pointer to rx adf_nbuf linked list - @param staId : [in] Station Id (Adress 1 Index) + @param staId : [in] Station Id (Address 1 Index) @return : VOS_STATUS_E_FAILURE if any errors encountered, : VOS_STATUS_SUCCESS otherwise diff --git a/CORE/HDD/src/wlan_hdd_wext.c b/CORE/HDD/src/wlan_hdd_wext.c index 1548d06b57d4..113d4a822623 100644 --- a/CORE/HDD/src/wlan_hdd_wext.c +++ b/CORE/HDD/src/wlan_hdd_wext.c @@ -190,7 +190,7 @@ static const hdd_freq_chan_map_t freq_chan_map[] = { {2412, 1}, {2417, 2}, #define WE_SET_MAX_TX_POWER_2_4 42 #define WE_SET_MAX_TX_POWER_5_0 43 #define WE_SET_POWER_GATING 44 -/* Private ioctl for packet powe save */ +/* Private ioctl for packet power save */ #define WE_PPS_PAID_MATCH 45 #define WE_PPS_GID_MATCH 46 #define WE_PPS_EARLY_TIM_CLEAR 47 @@ -617,7 +617,7 @@ void *mem_alloc_copy_from_user_helper(const void *wrqu_data, size_t len) Helper function to get compatible struct iw_point passed to ioctl \param - p_priv_data - pointer to iw_point struct to be filled - wrqu - Pointer to IOCTL Data received from userspace + wrqu - Pointer to IOCTL Data received from user space \return - 0 if p_priv_data successfully filled error otherwise @@ -2695,7 +2695,7 @@ VOS_STATUS wlan_hdd_get_classAstats(hdd_adapter_t *pAdapter) if (NULL == pAdapter) { - hddLog(VOS_TRACE_LEVEL_ERROR, "%s: Padapter is NULL", __func__); + hddLog(VOS_TRACE_LEVEL_ERROR, "%s: pAdapter is NULL", __func__); return VOS_STATUS_E_FAULT; } if ((WLAN_HDD_GET_CTX(pAdapter))->isLogpInProgress) @@ -2827,7 +2827,7 @@ VOS_STATUS wlan_hdd_get_station_stats(hdd_adapter_t *pAdapter) if (NULL == pAdapter) { - hddLog(VOS_TRACE_LEVEL_ERROR, "%s: Padapter is NULL", __func__); + hddLog(VOS_TRACE_LEVEL_ERROR, "%s: pAdapter is NULL", __func__); return VOS_STATUS_SUCCESS; } @@ -3936,7 +3936,7 @@ static int iw_set_encodeext(struct net_device *dev, } if(!ext->key_len) { - /*Set the encrytion type to NONE*/ + /* Set the encryption type to NONE */ pRoamProfile->EncryptionType.encryptionType[0] = eCSR_ENCRYPT_TYPE_NONE; return status; } @@ -4416,7 +4416,8 @@ int wlan_hdd_update_phymode(struct net_device *net, tHalHandle hal, } } break; - /* UMAC doesnt have option to set MODE_11NA/MODE_11NG as phymode + /* + * UMAC doesn't have option to set MODE_11NA/MODE_11NG as phymode * so setting phymode as eCSR_DOT11_MODE_11n and updating the band * and channel bonding in configuration to reflect MODE_11NA/MODE_11NG */ @@ -6984,7 +6985,7 @@ static int iw_get_char_setnone(struct net_device *dev, struct iw_request_info *i buf = extra; /** * Maximum channels = WNI_CFG_VALID_CHANNEL_LIST_LEN. Maximum buffer - * needed = 5 * number of channels. Check ifsufficient + * needed = 5 * number of channels. Check if sufficient * buffer is available and then proceed to fill the buffer. */ if(WE_MAX_STR_LEN < (5 * WNI_CFG_VALID_CHANNEL_LIST_LEN)) @@ -7158,7 +7159,7 @@ static int iw_setnone_getnone(struct net_device *dev, struct iw_request_info *in * the number of get and set args is 0. in this specific case the * logic in iwpriv places the sub_cmd in the data.flags portion of * the iwreq. unfortunately the location of this field will be - * different between 32-bit and 64-bit userspace, and the standard + * different between 32-bit and 64-bit user space, and the standard * compat support in the kernel does not handle this case. so we * need to explicitly handle it here. */ if (is_compat_task()) { @@ -7320,7 +7321,7 @@ void hdd_wmm_tx_snapshot(hdd_adapter_t *pAdapter) /* * Function to display HDD WMM information * for Tx Queues. - * Prints globala as well as per client depending + * Prints global as well as per client depending * whether the clients are registered or not. */ int i = 0, j = 0; @@ -7597,10 +7598,12 @@ static int iw_add_tspec(struct net_device *dev, struct iw_request_info *info, v_U32_t handle; struct iw_point s_priv_data; - // make sure the application is sufficiently priviledged - // note that the kernel will do this for "set" ioctls, but since - // this ioctl wants to return status to user space it must be - // defined as a "get" ioctl + /* + * Make sure the application is sufficiently privileged + * note that the kernel will do this for "set" ioctls, but since + * this ioctl wants to return status to user space it must be + * defined as a "get" ioctl. + */ if (!capable(CAP_NET_ADMIN)) { return -EPERM; @@ -7751,10 +7754,12 @@ static int iw_del_tspec(struct net_device *dev, struct iw_request_info *info, hdd_wlan_wmm_status_e *pStatus = (hdd_wlan_wmm_status_e *)extra; v_U32_t handle; - // make sure the application is sufficiently priviledged - // note that the kernel will do this for "set" ioctls, but since - // this ioctl wants to return status to user space it must be - // defined as a "get" ioctl + /* + * Make sure the application is sufficiently privileged + * note that the kernel will do this for "set" ioctls, but since + * this ioctl wants to return status to user space it must be + * defined as a "get" ioctl. + */ if (!capable(CAP_NET_ADMIN)) { return -EPERM; @@ -8304,9 +8309,9 @@ int wlan_hdd_setIPv6Filter(hdd_context_t *pHddCtx, tANI_U8 filterType, * 2 filters, one for MC and one for UC. * The Filter ID shouldn't be swapped, which results in making * UC Filter ineffective. - * We have Hardcode all the values + * We have hard coded all the values * - * Reason for a seperate UC filter is because, driver need to + * Reason for a separate UC filter is because, driver need to * specify the FW that the specific filter is for unicast * otherwise FW will not pass the unicast frames by default * through the filter. This is required to avoid any performance @@ -8347,7 +8352,7 @@ int wlan_hdd_setIPv6Filter(hdd_context_t *pHddCtx, tANI_U8 filterType, &packetFilterSetReq, sessionId)) { hddLog(VOS_TRACE_LEVEL_ERROR, - "%s: Failure to execute Set IPv6 Mulicast Filter", + "%s: Failure to execute Set IPv6 Multicast Filter", __func__); return -EINVAL; } @@ -8490,7 +8495,7 @@ void wlan_hdd_set_mc_addr_list(hdd_adapter_t *pAdapter, v_U8_t set) if (set) { - /* Following pre-conditions should be satisfied before wei + /* Following pre-conditions should be satisfied before we * configure the MC address list. */ if (((pAdapter->device_mode == WLAN_HDD_INFRA_STATION) || @@ -8846,7 +8851,7 @@ VOS_STATUS iw_set_pno(struct net_device *dev, struct iw_request_info *info, SSID bcast type is unknown (directed probe will be sent if AP not found) and must meet -40dBm RSSI - test2 - with auth and enrytption type 4/4 + test2 - with auth and encryption type 4/4 that can be found on 6 channels 1, 2, 3, 4, 5 and 6 bcast type is non-bcast (directed probe will be sent) and must not meet any RSSI threshold @@ -9376,7 +9381,7 @@ VOS_STATUS iw_set_power_params(struct net_device *dev, struct iw_request_info *i ----------------------------- 1 - Ignore DTIM 2 - Listen Interval - 3 - Broadcast Multicas Filter + 3 - Broadcast Multicast Filter 4 - Beacon Early Termination 5 - Beacon Early Termination Interval -----------------------------------------------------------------------*/ @@ -10826,8 +10831,7 @@ int hdd_validate_mcc_config(hdd_adapter_t *pAdapter, v_UINT_t staId, v_UINT_t ar break; default : - hddLog(LOGE, "%s : Uknown / Not allowed to configure parameter : %d", - __FUNCTION__,arg1); + hddLog(LOGE, FL("Unknown / Not allowed to configure parameter : %d"), arg1); break; } return 0; diff --git a/CORE/HDD/src/wlan_hdd_wmm.c b/CORE/HDD/src/wlan_hdd_wmm.c index 4dd638e2701b..d3e1e79d85f8 100644 --- a/CORE/HDD/src/wlan_hdd_wmm.c +++ b/CORE/HDD/src/wlan_hdd_wmm.c @@ -35,7 +35,7 @@ QoS (QoS here refers to a TSPEC). The setup QoS comes in two flavors: an explicit application invoked and an internal HDD invoked. The implicit QoS is for applications that do NOT call the custom QCT WLAN OIDs for QoS but - which DO mark their traffic for priortization. It also has logic to start, + which DO mark their traffic for prioritization. It also has logic to start, update and stop the U-APSD trigger frame generation. It also has logic to read WMM related config parameters from the registry. @@ -615,7 +615,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, else { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -669,7 +669,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, else { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -710,7 +710,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, else { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -719,11 +719,13 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, hdd_wmm_notify_app(pQosContext); } - /* Setting up QoS Failed, QoS context can be released. - * SME is releasing this flow information and if HDD doen't release this context, - * next time if application uses the same handle to set-up QoS, HDD (as it has - * QoS context for this handle) will issue Modify QoS request to SME but SME will - * reject as no it has no information for this flow. + /* + * Setting up QoS Failed, QoS context can be released. + * SME is releasing this flow information and if HDD doesn't release this + * context, next time if application uses the same handle to set-up QoS, + * HDD (as it has QoS context for this handle) will issue Modify QoS + * request to SME but SME will reject as no it has no information + * for this flow. */ hdd_wmm_free_context(pQosContext); break; @@ -763,7 +765,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, else { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -779,7 +781,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, if (!HDD_WMM_HANDLE_IMPLICIT == pQosContext->handle) { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -810,7 +812,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, if (HDD_WMM_HANDLE_IMPLICIT != pQosContext->handle) { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -851,7 +853,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, else { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -900,7 +902,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, else { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -952,7 +954,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, if (HDD_WMM_HANDLE_IMPLICIT != pQosContext->handle) { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -973,7 +975,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, if (HDD_WMM_HANDLE_IMPLICIT != pQosContext->handle) { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -1005,7 +1007,7 @@ static eHalStatus hdd_wmm_sme_callback (tHalHandle hHal, else { VOS_TRACE(VOS_MODULE_ID_HDD, WMM_TRACE_LEVEL_INFO_LOW, - "%s: Explicit Qos, notifying userspace", + "%s: Explicit Qos, notifying user space", __func__); // this was triggered by an application @@ -1448,7 +1450,7 @@ static void hdd_wmm_do_implicit_qos(struct work_struct *work) } /**============================================================================ - @brief hdd_wmm_init() - Function which will initialize the WMM configuation + @brief hdd_wmm_init() - Function which will initialize the WMM configuration and status to an initial state. The configuration can later be overwritten via application APIs @@ -1483,13 +1485,13 @@ VOS_STATUS hdd_wmm_init ( hdd_adapter_t *pAdapter ) } /**============================================================================ - @brief hdd_wmm_adapter_init() - Function which will initialize the WMM configuation - and status to an initial state. The configuration can later be overwritten - via application APIs + @brief hdd_wmm_adapter_init() - Function which will initialize the WMM + configuration and status to an initial state. + The configuration can later be overwritten via application APIs @param pAdapter : [in] pointer to Adapter context - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ @@ -1529,7 +1531,7 @@ VOS_STATUS hdd_wmm_adapter_init( hdd_adapter_t *pAdapter ) @param pAdapter : [in] pointer to Adapter context - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ @@ -1560,7 +1562,7 @@ VOS_STATUS hdd_wmm_adapter_clear( hdd_adapter_t *pAdapter ) @param pAdapter : [in] pointer to adapter context - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ @@ -1792,7 +1794,7 @@ v_VOID_t hdd_wmm_classify_pkt ( hdd_adapter_t* pAdapter, /**============================================================================ @brief hdd_hostapd_select_quueue() - Function which will classify the packet - according to linux qdisc expectation. + according to Linux qdisc expectation. @param dev : [in] pointer to net_device structure @@ -1855,7 +1857,7 @@ done: /**============================================================================ @brief hdd_wmm_select_quueue() - Function which will classify the packet - according to linux qdisc expectation. + according to Linux qdisc expectation. @param dev : [in] pointer to net_device structure @@ -1895,8 +1897,10 @@ v_U16_t hdd_wmm_select_queue(struct net_device * dev, struct sk_buff *skb) goto done; } } - // if we don't want QoS or the AP doesn't support Qos - // All traffic will get equal opportuniy to transmit data frames. + /* + * If we don't want QoS or the AP doesn't support Qos + * All traffic will get equal opportunity to transmit data frames. + */ if( hdd_wmm_is_active(pAdapter) ) { /* Get the user priority from IP header & corresponding AC */ hdd_wmm_classify_pkt (pAdapter, skb, &ac, &up); @@ -1965,7 +1969,7 @@ void hdd_wmm_acquire_access_required(hdd_adapter_t *pAdapter, @param pGranted : [out] pointer to boolean flag when indicates if access has been granted or not - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_acquire_access( hdd_adapter_t* pAdapter, @@ -2080,7 +2084,7 @@ VOS_STATUS hdd_wmm_acquire_access( hdd_adapter_t* pAdapter, @param pRoamInfo: [in] pointer to roam information @param eBssType : [in] type of BSS - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_assoc( hdd_adapter_t* pAdapter, @@ -2214,7 +2218,7 @@ static const v_U8_t acmMaskBit[WLANTL_MAX_AC] = @param pRoamInfo: [in] pointer to roam information @param eBssType : [in] type of BSS - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_connect( hdd_adapter_t* pAdapter, @@ -2297,7 +2301,7 @@ VOS_STATUS hdd_wmm_connect( hdd_adapter_t* pAdapter, @param pAdapter : [in] pointer to adapter context @param pUapsdMask: [in] pointer to where the UAPSD Mask is to be stored - @return : VOS_STATUS_SUCCESS if succssful + @return : VOS_STATUS_SUCCESS if successful : other values if failure ===========================================================================*/ VOS_STATUS hdd_wmm_get_uapsd_mask( hdd_adapter_t* pAdapter, @@ -2513,8 +2517,10 @@ hdd_wlan_wmm_status_e hdd_wmm_addts( hdd_adapter_t* pAdapter, hdd_wmm_free_context(pQosContext); return HDD_WLAN_WMM_STATUS_SETUP_FAILED_BAD_PARAM; case SME_QOS_STATUS_SETUP_FAILURE_RSP: - // we can't tell the difference between when a request fails because - // AP rejected it versus when SME encounterd an internal error + /* + * We can't tell the difference between when a request fails because + * AP rejected it versus when SME encountered an internal error + */ hdd_wmm_free_context(pQosContext); return HDD_WLAN_WMM_STATUS_SETUP_FAILED; case SME_QOS_STATUS_SETUP_NOT_QOS_AP_RSP: diff --git a/CORE/HDD/src/wlan_hdd_wowl.c b/CORE/HDD/src/wlan_hdd_wowl.c index af1dc841aaa9..0b33988b00b0 100644 --- a/CORE/HDD/src/wlan_hdd_wowl.c +++ b/CORE/HDD/src/wlan_hdd_wowl.c @@ -207,7 +207,7 @@ v_BOOL_t hdd_add_wowl_ptrn (hdd_adapter_t *pAdapter, const char * ptrn) goto next_ptrn; } - //compute the end of pattern sring + /* Compute the end of pattern string */ offset = offset + 2*localPattern.ucPatternMaskSize; if(offset+1 != len) //offset begins with 0 { @@ -230,7 +230,7 @@ v_BOOL_t hdd_add_wowl_ptrn (hdd_adapter_t *pAdapter, const char * ptrn) ptrn += 2; //skip to next byte } - ptrn++; // Skip over the ':' seperator after the pattern + ptrn++; /* Skip over the ':' separator after the pattern */ // Extract the pattern Mask for(i=0; i < localPattern.ucPatternMaskSize; i++) @@ -596,7 +596,7 @@ v_BOOL_t hdd_exit_wowl (hdd_adapter_t*pAdapter) /**============================================================================ @brief hdd_init_wowl() - Init function which will initialize the WoWL module - and perform any required intial configuration + and perform any required initial configuration @return : FALSE if any errors encountered : TRUE otherwise |