summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBala Venkatesh <bjavvaji@codeaurora.org>2019-09-20 16:22:29 +0530
committerGerrit - the friendly Code Review server <code-review@localhost>2019-09-20 03:54:05 -0700
commit90cd81e529145c33617ca8fa7b8bfecfa43d932b (patch)
tree2bab91186961a90ac5a1f55585b5c73c91019d6f
parentc0c45361fe16099508658e2813401cf349d47e13 (diff)
qcacld-3.0: Avoid NULL pointer dereference
In function hdd_is_connection_in_progress the arguments out_vdev_id and out_reason can be NULL. For device mode is SAP or P2P_GO possible NULL dereference can happen. Add NULL check for out_vdev_id and out_reason before dereference. Change-Id: I9c5c88f41f510483a01fe7b355538942360bd641 CRs-Fixed: 2531567
-rw-r--r--core/cds/src/cds_concurrency.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/core/cds/src/cds_concurrency.c b/core/cds/src/cds_concurrency.c
index 4a3445ccc0e2..d4e2a8fc6298 100644
--- a/core/cds/src/cds_concurrency.c
+++ b/core/cds/src/cds_concurrency.c
@@ -3036,8 +3036,11 @@ bool cds_is_connection_in_progress(uint8_t *session_id,
}
if (hdd_ctx->connection_in_progress) {
cds_debug("AP/GO: connection is in progress");
- *session_id = adapter->sessionId;
- *reason = eHDD_SAP_CONNECTION_IN_PROGRESS;
+ if (session_id && reason) {
+ *session_id = adapter->sessionId;
+ *reason =
+ eHDD_SAP_CONNECTION_IN_PROGRESS;
+ }
return true;
}
}