diff options
| author | krunal soni <ksoni@qca.qualcomm.com> | 2014-04-07 17:52:59 -0700 |
|---|---|---|
| committer | Akash Patel <c_akashp@qca.qualcomm.com> | 2014-04-10 07:12:44 -0700 |
| commit | 8dc84eb57ba18d01adf48dc4f6f32cd9edbf95f5 (patch) | |
| tree | 13fc855f46643f3329e568f099e6e534544edf21 | |
| parent | 23ae1f70ac75bb30e5330822de05eda5f4bfa63a (diff) | |
wlan: qcacld: fix static analysis issues in sme_Api.c
and wlan_hdd_cfg80211.c file.
'valid_ch' array elements were used uninitialized
and 'pstaParams' dereferenced by passing argument
to function 'csrTdlsChangePeerSta'
As a part of fix ,array 'valid_ch' is initialized
and a null check for 'StaParams' is introduced in
sme_ChangeTdlsPeerSta function.
CRs-Fixed: 646014
Change-Id: I65ee912ecca1bea4169fd8e4723eb7c7c3bbfd82
| -rw-r--r-- | CORE/HDD/src/wlan_hdd_cfg80211.c | 4 | ||||
| -rw-r--r-- | CORE/SME/src/sme_common/sme_Api.c | 6 |
2 files changed, 8 insertions, 2 deletions
diff --git a/CORE/HDD/src/wlan_hdd_cfg80211.c b/CORE/HDD/src/wlan_hdd_cfg80211.c index c36657b96dac..07837f173784 100644 --- a/CORE/HDD/src/wlan_hdd_cfg80211.c +++ b/CORE/HDD/src/wlan_hdd_cfg80211.c @@ -8709,8 +8709,8 @@ static int wlan_hdd_cfg80211_sched_scan_start(struct wiphy *wiphy, hdd_context_t *pHddCtx; tHalHandle hHal; v_U32_t i, indx, num_ch, tempInterval; - u8 valid_ch[WNI_CFG_VALID_CHANNEL_LIST_LEN]; - u8 channels_allowed[WNI_CFG_VALID_CHANNEL_LIST_LEN]; + u8 valid_ch[WNI_CFG_VALID_CHANNEL_LIST_LEN] = {0}; + u8 channels_allowed[WNI_CFG_VALID_CHANNEL_LIST_LEN] = {0}; v_U32_t num_channels_allowed = WNI_CFG_VALID_CHANNEL_LIST_LEN; eHalStatus status = eHAL_STATUS_FAILURE; int ret = 0; diff --git a/CORE/SME/src/sme_common/sme_Api.c b/CORE/SME/src/sme_common/sme_Api.c index 5891dc914cea..babf3dacbf83 100644 --- a/CORE/SME/src/sme_common/sme_Api.c +++ b/CORE/SME/src/sme_common/sme_Api.c @@ -10398,6 +10398,12 @@ VOS_STATUS sme_ChangeTdlsPeerSta(tHalHandle hHal, tANI_U8 sessionId, tSirMacAddr eHalStatus status = eHAL_STATUS_SUCCESS; tpAniSirGlobal pMac = PMAC_STRUCT(hHal); + if (NULL == pstaParams) + { + VOS_TRACE(VOS_MODULE_ID_SME, VOS_TRACE_LEVEL_ERROR, + "%s :pstaParams is NULL",__func__); + return eHAL_STATUS_FAILURE; + } status = sme_AcquireGlobalLock( &pMac->sme ); if ( HAL_STATUS_SUCCESS( status ) ) { |