summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYong Ding <yongding@codeaurora.org>2017-11-24 18:12:21 +0800
committerYong Ding <yongding@codeaurora.org>2017-12-18 18:41:11 +0800
commit8ad90a3cf781bb90e9e37abce320b49b37aec3f0 (patch)
treedeae416bea9f0ba53a291a0f0792fdcde7653de5
parentcd4b6d858fac589d92f2b6dc5a587ba6f76fd7b8 (diff)
soc: qcom: hab: add some code clean up
Add some code clean up for hab driver, including removing implicit type conversion, and etc. Change-Id: Ic2910f48063e22d1708972c1e0a5d23cbf179874 Signed-off-by: Yong Ding <yongding@codeaurora.org>
-rw-r--r--drivers/soc/qcom/hab/hab_mem_linux.c2
-rw-r--r--drivers/soc/qcom/hab/khab.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/soc/qcom/hab/hab_mem_linux.c b/drivers/soc/qcom/hab/hab_mem_linux.c
index 84709ed5c242..a69a7571a0f6 100644
--- a/drivers/soc/qcom/hab/hab_mem_linux.c
+++ b/drivers/soc/qcom/hab/hab_mem_linux.c
@@ -269,7 +269,7 @@ long habmem_imp_hyp_map(void *imp_ctx,
uint32_t userflags)
{
struct page **pages;
- struct compressed_pfns *pfn_table = impdata;
+ struct compressed_pfns *pfn_table = (struct compressed_pfns *)impdata;
struct pages_list *pglist;
struct importer_context *priv = imp_ctx;
unsigned long pfn;
diff --git a/drivers/soc/qcom/hab/khab.c b/drivers/soc/qcom/hab/khab.c
index f7499773ae42..05e6aa2fa7ca 100644
--- a/drivers/soc/qcom/hab/khab.c
+++ b/drivers/soc/qcom/hab/khab.c
@@ -117,7 +117,7 @@ int32_t habmm_import(int32_t handle, void **buff_shared, uint32_t size_bytes,
param.flags = flags;
ret = hab_mem_import(hab_driver.kctx, &param, 1);
- if (!IS_ERR(ret))
+ if (!ret)
*buff_shared = (void *)(uintptr_t)param.kva;
return ret;