summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDustin Brown <dustinb@codeaurora.org>2018-04-18 11:28:15 -0700
committernshrivas <nshrivas@codeaurora.org>2018-04-19 11:21:28 -0700
commit85a0d174e29ca28ceb406926ceb0607922dfe77d (patch)
tree03fc4a9baa70a2f306f60fee9b718e0cf779c66a
parentfabd0a1e85159df5586833406c094af1c4b1117c (diff)
qcacld-3.0: Avoid info leak in hdd_driver_rxfilter_comand_handler
In hdd_driver_rxfilter_comand_handler(), when kstrtou8() fails to parse the input string, the value of an uninitialized @type local is logged. To avoid leaking stack memory, avoid logging the value of @type if the parsing fails. Change-Id: I46b21cdb138927b3edc406014450447c58a0d977 CRs-Fixed: 2221085
-rw-r--r--core/hdd/src/wlan_hdd_ioctl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/core/hdd/src/wlan_hdd_ioctl.c b/core/hdd/src/wlan_hdd_ioctl.c
index e0f17d3ac797..cd7136842651 100644
--- a/core/hdd/src/wlan_hdd_ioctl.c
+++ b/core/hdd/src/wlan_hdd_ioctl.c
@@ -6303,7 +6303,7 @@ static int hdd_driver_rxfilter_comand_handler(uint8_t *command,
value = command + 13;
ret = kstrtou8(value, 10, &type);
if (ret < 0) {
- hdd_err("kstrtou8 failed invalid input value %d", type);
+ hdd_err("kstrtou8 failed invalid input value");
return -EINVAL;
}