diff options
| author | Nishank Aggarwal <naggar@codeaurora.org> | 2017-01-17 15:35:30 +0530 |
|---|---|---|
| committer | qcabuildsw <qcabuildsw@localhost> | 2017-01-20 23:47:38 -0800 |
| commit | 7a8192dad440b0d4aa6e3983aa22474cf6cb5b9f (patch) | |
| tree | 3908e7f0b6e2560b002264a17d293b33a4b35155 | |
| parent | a7242a876b77c9541678eed8cc75eb4f6fed94ec (diff) | |
qcacld-3.0: Avoid calling skb_put twice
The change in commit If578d66eada17784eef7daafa7351df95fc74f5a
is removing skb_put from switch case which missed during
propagation. Currently in function “wlan_hdd_send_svc_nlink_msg”
skb_put is calling twice in single code flow is leading to skb_tail
overflow crash.
Fix is to remove skb_put in switch case.
Change-Id: Icea19d92b5f7625d6a39f734bbb2fa01fa1ce2cf
CRs-Fixed: 1112350
| -rw-r--r-- | core/hdd/src/wlan_hdd_main.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/core/hdd/src/wlan_hdd_main.c b/core/hdd/src/wlan_hdd_main.c index da0b31fdfe01..ded0fff8bda8 100644 --- a/core/hdd/src/wlan_hdd_main.c +++ b/core/hdd/src/wlan_hdd_main.c @@ -8770,7 +8770,6 @@ void wlan_hdd_send_svc_nlink_msg(int radio, int type, void *data, int len) case WLAN_SVC_WLAN_AUTO_SHUTDOWN_CANCEL_IND: ani_hdr->length = 0; nlh->nlmsg_len = NLMSG_LENGTH((sizeof(tAniMsgHdr))); - skb_put(skb, NLMSG_SPACE(sizeof(tAniMsgHdr))); break; case WLAN_SVC_WLAN_STATUS_IND: case WLAN_SVC_WLAN_VERSION_IND: @@ -8785,7 +8784,6 @@ void wlan_hdd_send_svc_nlink_msg(int radio, int type, void *data, int len) nlh->nlmsg_len = NLMSG_LENGTH((sizeof(tAniMsgHdr) + len)); nl_data = (char *)ani_hdr + sizeof(tAniMsgHdr); memcpy(nl_data, data, len); - skb_put(skb, NLMSG_SPACE(sizeof(tAniMsgHdr) + len)); break; default: |