diff options
| author | Deepak Kumar <dkumar@codeaurora.org> | 2016-06-07 15:32:15 +0530 |
|---|---|---|
| committer | Carter Cooper <ccooper@codeaurora.org> | 2016-08-03 10:34:04 -0600 |
| commit | 7996822bbce7a8fe70eeca22baa52eb4eaeeabbe (patch) | |
| tree | 6b073b6cf0968b30c8288327ab06e25fe23bcfaa | |
| parent | da3193916d5e4526d659c950f3f0dea92273bc5a (diff) | |
msm: kgsl: Correct dma_buf_get function return value check
Check the return value of dma_buf_get function using
IS_ERR_OR_NULL as dma_buf_get function can return
ERR_PTR(-EINVAL) which won't be caught by simple NULL
check. This will avoid kernel panic due to invalid
pointer access.
CRs-Fixed: 1008517
Change-Id: I11ebf618edd25a251d3fb8bb7fbbb886e10d788f
Signed-off-by: Deepak Kumar <dkumar@codeaurora.org>
| -rw-r--r-- | drivers/gpu/msm/kgsl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/msm/kgsl.c b/drivers/gpu/msm/kgsl.c index 7dcb4df9607d..66c8755939a1 100644 --- a/drivers/gpu/msm/kgsl.c +++ b/drivers/gpu/msm/kgsl.c @@ -2144,8 +2144,8 @@ static int kgsl_setup_dmabuf_useraddr(struct kgsl_device *device, } up_read(¤t->mm->mmap_sem); - if (dmabuf == NULL) - return -ENODEV; + if (IS_ERR_OR_NULL(dmabuf)) + return dmabuf ? PTR_ERR(dmabuf) : -ENODEV; ret = kgsl_setup_dma_buf(device, pagetable, entry, dmabuf); if (ret) { |