summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJorgen Hansen <jhansen@vmware.com>2016-04-18 23:58:52 -0700
committerAlistair Strachan <astrachan@google.com>2019-01-15 17:08:34 -0800
commit7103ea77d35bce09975d07b3bafa9e70c189eacb (patch)
tree9e3e8cb77a180c60e42703657c298cbfa0ad838e
parent4c634053305d57cb88880a3d6cddb4f3dcafaa27 (diff)
UPSTREAM: VSOCK: Only check error on skb_recv_datagram when skb is NULL
If skb_recv_datagram returns an skb, we should ignore the err value returned. Otherwise, datagram receives will return EAGAIN when they have to wait for a datagram. Acked-by: Adit Ranadive <aditr@vmware.com> Signed-off-by: Jorgen Hansen <jhansen@vmware.com> Signed-off-by: David S. Miller <davem@davemloft.net> (cherry picked from commit 9c995cc9a206a008699da82f6cd01e9b2615649a) Bug: 121166534 Test: Ran cuttlefish with android-4.4 + VSOCKETS, VMWARE_VMCI_VSOCKETS Signed-off-by: Cody Schuffelen <schuffelen@google.com> Change-Id: I69d487529656cb2fe8be9c2cef0db440d4db5cac
-rw-r--r--net/vmw_vsock/vmci_transport.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c
index d24773552b64..20667a13bb23 100644
--- a/net/vmw_vsock/vmci_transport.c
+++ b/net/vmw_vsock/vmci_transport.c
@@ -1767,11 +1767,8 @@ static int vmci_transport_dgram_dequeue(struct vsock_sock *vsk,
/* Retrieve the head sk_buff from the socket's receive queue. */
err = 0;
skb = skb_recv_datagram(&vsk->sk, flags, noblock, &err);
- if (err)
- return err;
-
if (!skb)
- return -EAGAIN;
+ return err;
dg = (struct vmci_datagram *)skb->data;
if (!dg)
@@ -2186,7 +2183,7 @@ module_exit(vmci_transport_exit);
MODULE_AUTHOR("VMware, Inc.");
MODULE_DESCRIPTION("VMCI transport for Virtual Sockets");
-MODULE_VERSION("1.0.3.0-k");
+MODULE_VERSION("1.0.4.0-k");
MODULE_LICENSE("GPL v2");
MODULE_ALIAS("vmware_vsock");
MODULE_ALIAS_NETPROTO(PF_VSOCK);