diff options
| author | Abhishek Singh <absingh@qti.qualcomm.com> | 2016-05-17 14:00:52 +0530 |
|---|---|---|
| committer | Anjaneedevi Kapparapu <akappa@codeaurora.org> | 2016-05-19 13:23:19 +0530 |
| commit | 6ed1a728bb0878b504caf6a7cc03237afe83d295 (patch) | |
| tree | 2913354d805fe91952d1e6e93d3d6fe5052535c5 | |
| parent | c50b50f7f0616b4536e7df998e98f9347562e680 (diff) | |
qcacld-2.0: Do not call pr_info while using spin_lock_irqsave
wlan_queue_logmsg_for_app is called while holding spin lock with
interrupts disabled. It may call pr_info to log if node is dropped
while sending to user space.
This may cause interrupts disabled for some time.
As part of fix remove all pr_info from wlan_queue_logmsg_for_app.
Change-Id: Iffa5d463ae4e807bb30ff6eec5f3949735663fd5
CRs-Fixed: 1005714
| -rw-r--r-- | CORE/SVC/src/logging/wlan_logging_sock_svc.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/CORE/SVC/src/logging/wlan_logging_sock_svc.c b/CORE/SVC/src/logging/wlan_logging_sock_svc.c index b458e17fc629..1dd4dc0a2e86 100644 --- a/CORE/SVC/src/logging/wlan_logging_sock_svc.c +++ b/CORE/SVC/src/logging/wlan_logging_sock_svc.c @@ -316,14 +316,6 @@ static int wlan_queue_logmsg_for_app(void) gwlan_logging.pcur_node = (struct log_msg *)(gwlan_logging.filled_list.next); ++gwlan_logging.drop_count; - /* print every 64th drop count */ - if (vos_is_multicast_logging() && - (!(gwlan_logging.drop_count % 0x40))) { - pr_info("%s: drop_count = %u index = %d filled_length = %d\n", - __func__, gwlan_logging.drop_count, - gwlan_logging.pcur_node->index, - gwlan_logging.pcur_node->filled_length); - } list_del_init(gwlan_logging.filled_list.next); ret = 1; } @@ -417,11 +409,9 @@ int wlan_log_to_user(VOS_TRACE_LEVEL log_level, char *to_be_sent, int length) * Continue and copy logs to the available length and * discard the rest. */ - if (MAX_LOGMSG_LENGTH < (sizeof(tAniNlHdr) + total_log_len)) { - VOS_ASSERT(0); + if (MAX_LOGMSG_LENGTH < (sizeof(tAniNlHdr) + total_log_len)) total_log_len = MAX_LOGMSG_LENGTH - sizeof(tAniNlHdr) - 2; - } memcpy(&ptr[*pfilled_length], tbuf, tlen); memcpy(&ptr[*pfilled_length + tlen], to_be_sent, |