diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2019-09-26 22:36:25 -0700 |
|---|---|---|
| committer | Michael Bestas <mkbestas@lineageos.org> | 2020-02-02 01:40:57 +0200 |
| commit | 6a98f85fe047f6e19f5372812e3f1caea0db8854 (patch) | |
| tree | 5712d87f4e5c4fcfd0d2dd15b52603cc4586e63a | |
| parent | a10ab757b9d8de4905a5593df7fa25354015b94c (diff) | |
msm: camera: Remove pointless NULL checks in msm_camera_{get,put}_clk_info
Clang warns:
../drivers/media/platform/msm/camera_v2/common/cam_soc_api.c:208:23:
warning: address of 'pdev->dev' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!pdev || !&pdev->dev || !clk_info || !clk_ptr || !num_clk)
~ ~~~~~~^~~
../drivers/media/platform/msm/camera_v2/common/cam_soc_api.c:510:23:
warning: address of 'pdev->dev' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!pdev || !&pdev->dev || !clk_info || !clk_ptr)
~ ~~~~~~^~~
2 warnings generated.
Fixes: a4663702036e ("msm: camera: sensor: Updating soc layer clock API for i2c drivers")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
| -rw-r--r-- | drivers/media/platform/msm/camera_v2/common/cam_soc_api.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/platform/msm/camera_v2/common/cam_soc_api.c b/drivers/media/platform/msm/camera_v2/common/cam_soc_api.c index a0c606ce9a29..d87f6a504d28 100644 --- a/drivers/media/platform/msm/camera_v2/common/cam_soc_api.c +++ b/drivers/media/platform/msm/camera_v2/common/cam_soc_api.c @@ -205,7 +205,7 @@ int msm_camera_get_clk_info(struct platform_device *pdev, { int rc = 0; - if (!pdev || !&pdev->dev || !clk_info || !clk_ptr || !num_clk) + if (!pdev || !clk_info || !clk_ptr || !num_clk) return -EINVAL; rc = msm_camera_get_clk_info_internal(&pdev->dev, @@ -507,7 +507,7 @@ int msm_camera_put_clk_info(struct platform_device *pdev, { int rc = 0; - if (!pdev || !&pdev->dev || !clk_info || !clk_ptr) + if (!pdev || !clk_info || !clk_ptr) return -EINVAL; rc = msm_camera_put_clk_info_internal(&pdev->dev, |