summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBenjamin Chan <bkchan@codeaurora.org>2016-10-06 17:36:48 -0400
committerBenjamin Chan <bkchan@codeaurora.org>2016-10-07 10:47:01 -0400
commit4b7bbe3ad15ebdfc306e24c817695384d494ffec (patch)
tree97f5e57f5916c37097c8246a96776216d922b11c
parent3c7400dc73db9b1455032e8d6e7679f27869cd75 (diff)
msm: sde: Reject 0 size image for SDE rotator
Rotator HW cannot support 0 dimension of input and output image. During V4L2 validation, it must reject any 0 size image format setting. CRs-Fixed: 1073633 Change-Id: I503561677271c39894b7a6910fe8d9c5c25e9c28 Signed-off-by: Benjamin Chan <bkchan@codeaurora.org>
-rw-r--r--drivers/media/platform/msm/sde/rotator/sde_rotator_dev.c14
1 files changed, 14 insertions, 0 deletions
diff --git a/drivers/media/platform/msm/sde/rotator/sde_rotator_dev.c b/drivers/media/platform/msm/sde/rotator/sde_rotator_dev.c
index 930b18abd71b..b88f03ce89ae 100644
--- a/drivers/media/platform/msm/sde/rotator/sde_rotator_dev.c
+++ b/drivers/media/platform/msm/sde/rotator/sde_rotator_dev.c
@@ -1123,6 +1123,13 @@ static int sde_rotator_try_fmt_vid_cap(struct file *file,
struct sde_rotation_config config;
int ret;
+ if ((f->fmt.pix.width == 0) || (f->fmt.pix.height == 0)) {
+ SDEDEV_WARN(ctx->rot_dev->dev,
+ "Not supporting 0 width/height: %dx%d\n",
+ f->fmt.pix.width, f->fmt.pix.height);
+ return -EINVAL;
+ }
+
sde_rot_mgr_lock(rot_dev->mgr);
sde_rotator_get_config_from_ctx(ctx, &config);
config.output.format = f->fmt.pix.pixelformat;
@@ -1162,6 +1169,13 @@ static int sde_rotator_try_fmt_vid_out(struct file *file,
struct sde_rotation_config config;
int ret;
+ if ((f->fmt.pix.width == 0) || (f->fmt.pix.height == 0)) {
+ SDEDEV_WARN(ctx->rot_dev->dev,
+ "Not supporting 0 width/height: %dx%d\n",
+ f->fmt.pix.width, f->fmt.pix.height);
+ return -EINVAL;
+ }
+
sde_rot_mgr_lock(rot_dev->mgr);
sde_rotator_get_config_from_ctx(ctx, &config);
config.input.format = f->fmt.pix.pixelformat;