summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSahitya Tummala <stummala@codeaurora.org>2018-10-05 10:47:39 +0530
committerJaegeuk Kim <jaegeuk@kernel.org>2018-10-29 18:46:23 -0700
commit4aa5ef7fb109be395e9ebe06804d3d77c4bc8b68 (patch)
treebf272da123f6f5135ebfb65edb8f8ea25c5145c3
parent2dc22029a7e51dade5cddc06acc29bcec60263d2 (diff)
f2fs: do not update REQ_TIME in case of error conditions
The REQ_TIME should be updated only in case of success cases as followed at all other places in the file system. Signed-off-by: Sahitya Tummala <stummala@codeaurora.org> Reviewed-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
-rw-r--r--fs/f2fs/dir.c2
-rw-r--r--fs/f2fs/file.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
index a3302e2888dc..317820239111 100644
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
@@ -655,9 +655,9 @@ int f2fs_do_tmpfile(struct inode *inode, struct inode *dir)
f2fs_put_page(page, 1);
clear_inode_flag(inode, FI_NEW_INODE);
+ f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);
fail:
up_write(&F2FS_I(inode)->i_sem);
- f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);
return err;
}
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 834f87e75dff..040c9667347e 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -109,6 +109,7 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *vma,
SetPageUptodate(page);
f2fs_update_iostat(sbi, APP_MAPPED_IO, F2FS_BLKSIZE);
+ f2fs_update_time(sbi, REQ_TIME);
trace_f2fs_vm_page_mkwrite(page, DATA);
out_sem:
@@ -117,7 +118,6 @@ out_sem:
f2fs_balance_fs(sbi, dn.node_changed);
sb_end_pagefault(inode->i_sb);
- f2fs_update_time(sbi, REQ_TIME);
err:
return block_page_mkwrite_return(err);
}