summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTharun Kumar Merugu <mtharu@codeaurora.org>2017-03-22 16:28:40 +0530
committerGerrit - the friendly Code Review server <code-review@localhost>2017-03-22 05:33:09 -0700
commit3c2b633bb91e0f270e583af6d4ee6dffa12d298d (patch)
tree32a746d3910c57bc770d6558075e0d820cba59b6
parent630218f7109215471e1f43c2200f6bdc98f92f93 (diff)
sdm660: ADSPRPC: Null check file session ctx during mmap create
During fastrpc mmap create and mmap free, we are dereferencing file session context without checking for Null. Change-Id: I65fc2bb566e2e6e7914b86044e17577a96db6b4f Acked-by: Vishnu Karthik D <vikarthi@qti.qualcomm.com> Signed-off-by: Tharun Kumar Merugu <mtharu@codeaurora.org>
-rw-r--r--drivers/char/adsprpc.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/char/adsprpc.c b/drivers/char/adsprpc.c
index e0106a7e31fa..8261af23d03e 100644
--- a/drivers/char/adsprpc.c
+++ b/drivers/char/adsprpc.c
@@ -553,7 +553,7 @@ static void fastrpc_mmap_free(struct fastrpc_mmap *map)
if (!IS_ERR_OR_NULL(map->handle))
ion_free(fl->apps->client, map->handle);
- if (sess->smmu.enabled) {
+ if (sess && sess->smmu.enabled) {
if (map->size || map->phys)
msm_dma_unmap_sg(sess->smmu.dev,
map->table->sgl,
@@ -645,6 +645,9 @@ static int fastrpc_mmap_create(struct fastrpc_file *fl, int fd, unsigned attr,
else
sess = fl->sctx;
+ VERIFY(err, !IS_ERR_OR_NULL(sess));
+ if (err)
+ goto bail;
VERIFY(err, !IS_ERR_OR_NULL(map->buf = dma_buf_get(fd)));
if (err)
goto bail;