diff options
| author | gaurank kathpalia <gkathpal@codeaurora.org> | 2018-05-02 12:30:52 +0530 |
|---|---|---|
| committer | nshrivas <nshrivas@codeaurora.org> | 2018-05-07 06:26:37 -0700 |
| commit | 39c127849fedefa905037f2cf511bbb356bfbec7 (patch) | |
| tree | eb1ffa513c9b2e24394c3ab037f9066d1fb7c850 | |
| parent | 5e96d5a7eae5e1d77e09c3cb12d9e180c430b5ec (diff) | |
qcacld-3.0: Remove dead code from wma_tx_packet
In the API wma_tx_packet, host assigns downld_comp_required
to true/false according to tx_frm_download_comp_cb,
is_high_latency, tx_frm_ota_comp_cb, all the three
conditions to be true. Also the host checks
tx_frm_download_comp_cb, and assigns tx_frm_index
according to downld_comp_required, but in the else
case when tx_frm_download_comp_cb is false, the check
of downld_comp_required is void, as the downld_comp_required
cannot be true if prior tx_frm_download_comp_cb is false,
so the code in the else part which checks tx_frm_download_comp_cb
and assigns tx_frm_index is dead, and in any case cannot be
executed.
Fix is to remove the check of downld_comp_required in
the else case.
Change-Id: If1a376099234d541d508f18cee075dd0f1603294
CRs-Fixed: 2233558
| -rw-r--r-- | core/wma/src/wma_data.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/core/wma/src/wma_data.c b/core/wma/src/wma_data.c index 503ef9c64f2c..f199e29c7fe5 100644 --- a/core/wma/src/wma_data.c +++ b/core/wma/src/wma_data.c @@ -2890,12 +2890,8 @@ QDF_STATUS wma_tx_packet(void *wma_context, void *tx_frame, uint16_t frmLen, tx_frm_ota_comp_cb; } } else { - if (downld_comp_required) - tx_frm_index = - GENERIC_DOWNLD_COMP_NOACK_COMP_INDEX; - else - tx_frm_index = - GENERIC_NODOWNLD_NOACK_COMP_INDEX; + tx_frm_index = + GENERIC_NODOWNLD_NOACK_COMP_INDEX; } } |