summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMahesh A Saptasagar <c_msapta@qti.qualcomm.com>2015-06-11 14:43:53 +0530
committerAnjaneedevi Kapparapu <akappa@codeaurora.org>2015-12-30 12:26:22 +0530
commit2df47b02f0ddb3a190704a1e2af10d98754372c3 (patch)
tree3d04d1a0f750e03406f65eeba056b6cf64067f68
parentbf02f667f8bfb1ed35307f596305e27cd6e3a355 (diff)
wlan: Reduce unwanted netlink log messages
Reduce unwanted netlink log messages and modify the error value print format from hex to decimal. Change-Id: Ia94efe17b80d5f3c4a7006b914f4f0586360fded CRs-Fixed: 804176
-rw-r--r--CORE/SVC/src/logging/wlan_logging_sock_svc.c10
-rw-r--r--CORE/SVC/src/nlink/wlan_nlink_srv.c2
-rw-r--r--CORE/SVC/src/ptt/wlan_ptt_sock_svc.c8
3 files changed, 12 insertions, 8 deletions
diff --git a/CORE/SVC/src/logging/wlan_logging_sock_svc.c b/CORE/SVC/src/logging/wlan_logging_sock_svc.c
index a132a24356f3..2c01af76a508 100644
--- a/CORE/SVC/src/logging/wlan_logging_sock_svc.c
+++ b/CORE/SVC/src/logging/wlan_logging_sock_svc.c
@@ -150,11 +150,13 @@ static int wlan_send_sock_msg_to_app(tAniHdr *wmsg, int radio,
wnl = (tAniNlHdr *) nlh;
wnl->radio = radio;
memcpy(&wnl->wmsg, wmsg, wmsg_length);
- LOGGING_TRACE(VOS_TRACE_LEVEL_INFO,
- "%s: Sending Msg Type [0x%X] to pid[%d]\n",
- __func__, be16_to_cpu(wmsg->type), pid);
-
err = nl_srv_ucast(skb, pid, MSG_DONTWAIT);
+ if (err) {
+ LOGGING_TRACE(VOS_TRACE_LEVEL_INFO,
+ "%s: Failed sending Msg Type [0x%X] to pid[%d]\n",
+ __func__, wmsg->type, pid);
+ }
+
return err;
}
diff --git a/CORE/SVC/src/nlink/wlan_nlink_srv.c b/CORE/SVC/src/nlink/wlan_nlink_srv.c
index 9f36539b7e1d..9fc61ed08294 100644
--- a/CORE/SVC/src/nlink/wlan_nlink_srv.c
+++ b/CORE/SVC/src/nlink/wlan_nlink_srv.c
@@ -175,7 +175,7 @@ int nl_srv_ucast(struct sk_buff *skb, int dst_pid, int flag)
}
if (err < 0)
VOS_TRACE( VOS_MODULE_ID_HDD, VOS_TRACE_LEVEL_WARN,
- "NLINK: netlink_unicast to pid[%d] failed, ret[0x%X]", dst_pid, err);
+ "NLINK: netlink_unicast to pid[%d] failed, ret[%d]", dst_pid, err);
return err;
}
diff --git a/CORE/SVC/src/ptt/wlan_ptt_sock_svc.c b/CORE/SVC/src/ptt/wlan_ptt_sock_svc.c
index 69e18face235..b51fa3e16e5a 100644
--- a/CORE/SVC/src/ptt/wlan_ptt_sock_svc.c
+++ b/CORE/SVC/src/ptt/wlan_ptt_sock_svc.c
@@ -97,8 +97,6 @@ int ptt_sock_send_msg_to_app(tAniHdr *wmsg, int radio, int src_mod, int pid)
wnl = (tAniNlHdr *) nlh;
wnl->radio = radio;
memcpy(&wnl->wmsg, wmsg, wmsg_length);
- PTT_TRACE(VOS_TRACE_LEVEL_INFO, "%s: Sending Msg Type [0x%X] to pid[%d]\n",
- __func__, be16_to_cpu(wmsg->type), pid);
#ifdef PTT_SOCK_DEBUG_VERBOSE
ptt_sock_dump_buf((const unsigned char *)skb->data, skb->len);
#endif
@@ -108,7 +106,11 @@ int ptt_sock_send_msg_to_app(tAniHdr *wmsg, int radio, int src_mod, int pid)
} else {
err = nl_srv_bcast(skb);
}
-
+ if (err) {
+ PTT_TRACE(VOS_TRACE_LEVEL_INFO,
+ "%s:Failed sending Msg Type [0x%X] to pid[%d]\n",
+ __func__, be16_to_cpu(wmsg->type), pid);
+ }
return err;
}
/*