summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff Johnson <jjohnson@qca.qualcomm.com>2014-10-14 12:28:37 -0700
committerAnjaneeDevi Kapparapu <c_akappa@qti.qualcomm.com>2014-10-16 17:03:10 +0530
commit28668d011c60fa9cd60ef27e6ef99546e8b2d9d5 (patch)
tree22f39a2e11b73bde6b760b47862433c265ea9ab8
parent949ee800502e3033115d329a03a9b8307b4a1e71 (diff)
qcacld: sme: Remove obsolete support for TL AC Weights
qcacld inherited from the Prima driver support for the following TL APIs: WLANTL_SetACWeights() WLANTL_GetACWeights() The qcacld data path does not use the WFQ algorithm, so remove from SME support for these obsolete APIs. Change-Id: I99847be1c0f07532833e94364da156c5568050a4 CRs-fixed: 738817
-rw-r--r--CORE/SME/inc/csrInternal.h1
-rw-r--r--CORE/SME/src/csr/csrApiRoam.c90
2 files changed, 1 insertions, 90 deletions
diff --git a/CORE/SME/inc/csrInternal.h b/CORE/SME/inc/csrInternal.h
index 98da6500b1c3..ea45bc695c9b 100644
--- a/CORE/SME/inc/csrInternal.h
+++ b/CORE/SME/inc/csrInternal.h
@@ -1023,7 +1023,6 @@ typedef struct tagCsrRoamStruct
eCsrRoamLinkQualityInd vccLinkQuality;
tCsrLinkQualityIndInfo linkQualityIndInfo;
v_CONTEXT_t gVosContext; //used for interaction with TL
- v_U8_t ucACWeights[WLANTL_MAX_AC];
/* TODO : Upto here */
tCsrTimerInfo WaitForKeyTimerInfo;
tCsrRoamSession *roamSession;
diff --git a/CORE/SME/src/csr/csrApiRoam.c b/CORE/SME/src/csr/csrApiRoam.c
index 99aba1c39709..1495e064249e 100644
--- a/CORE/SME/src/csr/csrApiRoam.c
+++ b/CORE/SME/src/csr/csrApiRoam.c
@@ -85,11 +85,7 @@
#define CSR_MIN_GLOBAL_STAT_QUERY_PERIOD 500 //ms
#define CSR_MIN_GLOBAL_STAT_QUERY_PERIOD_IN_BMPS 2000 //ms
#define CSR_MIN_TL_STAT_QUERY_PERIOD 500 //ms
-//We use constant 4 here
-//This macro returns true when higher AC parameter is bigger than lower AC for a difference
-//The bigger the number, the less chance of TX
-//It must put lower AC as the first parameter.
-#define SME_DETECT_AC_WEIGHT_DIFF(loAC, hiAC) (v_BOOL_t)(((hiAC) > (loAC)) ? (((hiAC)-(loAC)) > 4) : 0)
+
//Flag to send/do not send disassoc frame over the air
#define CSR_DONT_SEND_DISASSOC_OVER_THE_AIR 1
#define RSSI_HACK_BMPS (-40)
@@ -681,8 +677,6 @@ eHalStatus csrReady(tpAniSirGlobal pMac)
{
csrScanStartResultCfgAgingTimer(pMac);
}
- //Store the AC weights in TL for later use
- WLANTL_GetACWeights(pMac->roam.gVosContext, pMac->roam.ucACWeights);
status = csrInitChannelList( pMac );
if ( ! HAL_STATUS_SUCCESS( status ) )
{
@@ -2805,14 +2799,6 @@ eHalStatus csrRoamIssueDisassociate( tpAniSirGlobal pMac, tANI_U32 sessionId,
return eHAL_STATUS_FAILURE;
}
- //Restore AC weight in case we change it
- if ( csrIsConnStateConnectedInfra( pMac, sessionId ) )
- {
- smsLog(pMac, LOG1, FL(" restore AC weights (%d-%d-%d-%d)"), pMac->roam.ucACWeights[0], pMac->roam.ucACWeights[1],
- pMac->roam.ucACWeights[2], pMac->roam.ucACWeights[3]);
- WLANTL_SetACWeights(pMac->roam.gVosContext, pMac->roam.ucACWeights);
- }
-
if ( fMICFailure )
{
reasonCode = eSIR_MAC_MIC_FAILURE_REASON;
@@ -5323,64 +5309,6 @@ static eHalStatus csrRoamSaveSecurityRspIE(tpAniSirGlobal pMac, tANI_U32 session
return (status);
}
-static void csrCheckAndUpdateACWeight( tpAniSirGlobal pMac, tDot11fBeaconIEs *pIEs )
-{
- v_U8_t bACWeights[WLANTL_MAX_AC];
- v_U8_t paramBk, paramBe, paramVi, paramVo;
- v_BOOL_t fWeightChange = VOS_FALSE;
- //Compare two ACs' EDCA parameters, from low to high (BK, BE, VI, VO)
- //The "formula" is, if lower AC's AIFSN+CWMin is bigger than a fixed amount
- //of the higher AC one, make the higher AC has the same weight as the lower AC.
- //This doesn't address the case where the lower AC needs a real higher weight
- if( pIEs->WMMParams.present )
- {
- //no change to the lowest ones
- bACWeights[WLANTL_AC_BK] = pMac->roam.ucACWeights[WLANTL_AC_BK];
- bACWeights[WLANTL_AC_BE] = pMac->roam.ucACWeights[WLANTL_AC_BE];
- bACWeights[WLANTL_AC_VI] = pMac->roam.ucACWeights[WLANTL_AC_VI];
- bACWeights[WLANTL_AC_VO] = pMac->roam.ucACWeights[WLANTL_AC_VO];
- paramBk = pIEs->WMMParams.acbk_aifsn + pIEs->WMMParams.acbk_acwmin;
- paramBe = pIEs->WMMParams.acbe_aifsn + pIEs->WMMParams.acbe_acwmin;
- paramVi = pIEs->WMMParams.acvi_aifsn + pIEs->WMMParams.acvi_acwmin;
- paramVo = pIEs->WMMParams.acvo_aifsn + pIEs->WMMParams.acvo_acwmin;
- if( SME_DETECT_AC_WEIGHT_DIFF(paramBk, paramBe) )
- {
- bACWeights[WLANTL_AC_BE] = bACWeights[WLANTL_AC_BK];
- fWeightChange = VOS_TRUE;
- }
- if( SME_DETECT_AC_WEIGHT_DIFF(paramBk, paramVi) )
- {
- bACWeights[WLANTL_AC_VI] = bACWeights[WLANTL_AC_BK];
- fWeightChange = VOS_TRUE;
- }
- else if( SME_DETECT_AC_WEIGHT_DIFF(paramBe, paramVi) )
- {
- bACWeights[WLANTL_AC_VI] = bACWeights[WLANTL_AC_BE];
- fWeightChange = VOS_TRUE;
- }
- if( SME_DETECT_AC_WEIGHT_DIFF(paramBk, paramVo) )
- {
- bACWeights[WLANTL_AC_VO] = bACWeights[WLANTL_AC_BK];
- fWeightChange = VOS_TRUE;
- }
- else if( SME_DETECT_AC_WEIGHT_DIFF(paramBe, paramVo) )
- {
- bACWeights[WLANTL_AC_VO] = bACWeights[WLANTL_AC_BE];
- fWeightChange = VOS_TRUE;
- }
- else if( SME_DETECT_AC_WEIGHT_DIFF(paramVi, paramVo) )
- {
- bACWeights[WLANTL_AC_VO] = bACWeights[WLANTL_AC_VI];
- fWeightChange = VOS_TRUE;
- }
- if(fWeightChange)
- {
- smsLog(pMac, LOGE, FL(" change AC weights (%d-%d-%d-%d)"), bACWeights[0], bACWeights[1],
- bACWeights[2], bACWeights[3]);
- WLANTL_SetACWeights(pMac->roam.gVosContext, bACWeights);
- }
- }
-}
#ifdef WLAN_FEATURE_VOWIFI_11R
//Returns whether the current association is a 11r assoc or not
tANI_BOOLEAN csrRoamIs11rAssoc(tpAniSirGlobal pMac, tANI_U8 sessionId)
@@ -5899,18 +5827,6 @@ static tANI_BOOLEAN csrRoamProcessResults( tpAniSirGlobal pMac, tSmeCmd *pComman
csrRoamCompletion(pMac, sessionId, NULL, pCommand, eCSR_ROAM_RESULT_NONE, eANI_BOOLEAN_TRUE);
// reset the PMKID candidate list
csrResetPMKIDCandidateList( pMac, sessionId );
- //Update TL's AC weight base on the current EDCA parameters
- /*
- * These parameters may change in the course of the connection,
- * that situation is not taken care here. This change is mainly
- * to address a WIFI WMM test where BE has a equal or
- * higher TX priority than VI.
- * We only do this for infra link
- */
- if( csrIsConnStateConnectedInfra(pMac, sessionId ) && pIes )
- {
- csrCheckAndUpdateACWeight(pMac, pIes);
- }
#ifdef FEATURE_WLAN_WAPI
// reset the BKID candidate list
csrResetBKIDCandidateList( pMac, sessionId );
@@ -7356,10 +7272,6 @@ eHalStatus csrRoamProcessDisassocDeauth( tpAniSirGlobal pMac, tSmeCmd *pCommand,
}
else if ( csrIsConnStateInfra( pMac, sessionId ) )
{
- smsLog(pMac, LOG1, FL(" restore AC weights (%d-%d-%d-%d)"), pMac->roam.ucACWeights[0], pMac->roam.ucACWeights[1],
- pMac->roam.ucACWeights[2], pMac->roam.ucACWeights[3]);
- //Restore AC weight in case we change it
- WLANTL_SetACWeights(pMac->roam.gVosContext, pMac->roam.ucACWeights);
/* In Infrastructure, we need to disassociate from the
Infrastructure network... */
NewSubstate = eCSR_ROAM_SUBSTATE_DISASSOC_FORCED;