diff options
| author | Paul Zhang <paulz@codeaurora.org> | 2018-04-25 10:48:02 +0800 |
|---|---|---|
| committer | Gerrit - the friendly Code Review server <code-review@localhost> | 2018-05-02 02:14:43 -0700 |
| commit | 2689efe5cafe75dc42b508dc9264dfec8c679244 (patch) | |
| tree | 1a34a2b0173014be0330f0068fac69d6c973985c | |
| parent | a5bcf0d85af805d463e74daab2c5461cb896d610 (diff) | |
qcacld-2.0: Avoid info disclose in hdd_driver_rxfilter_comand_handler
qcacld-3.0 to qcacld-2.0 propagation
In hdd_driver_rxfilter_comand_handler(), when kstrtou8() fails to parse
the input string, the value of an uninitialized @type local is logged.
To avoid disclosing stack memory, avoid logging the value of @type if the
parsing fails.
Change-Id: I46b21cdb138927b3edc406014450447c58a0d977
CRs-Fixed: 2230673
| -rw-r--r-- | CORE/HDD/src/wlan_hdd_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/CORE/HDD/src/wlan_hdd_main.c b/CORE/HDD/src/wlan_hdd_main.c index 543968c147e1..050482996113 100644 --- a/CORE/HDD/src/wlan_hdd_main.c +++ b/CORE/HDD/src/wlan_hdd_main.c @@ -5086,7 +5086,7 @@ static int hdd_driver_rxfilter_comand_handler(uint8_t *command, ret = kstrtou8(value, 10, &type); if (ret < 0) { hddLog(LOGE, - FL("kstrtou8 failed invalid input value %d"), type); + FL("kstrtou8 failed invalid input value")); return -EINVAL; } |