diff options
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2013-05-23 12:55:28 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-05-30 20:40:57 +0900 |
| commit | 1fc56e86e49c93e426937377fc485734a81870da (patch) | |
| tree | c90317963ad7e42163d90b079fa4822280706797 | |
| parent | 9838f532dc714011f236039e91f8d8654b3b4cc7 (diff) | |
staging: comedi: usbduxsigma: remove tidy_up() from (*auto_attach)
Comedi drivers do not need to cleanup allocations during the
(*auto_attach). If the (*auto_attach) fails the (*detach) will
automatically be called to handle the cleanup.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/comedi/drivers/usbduxsigma.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c index bdbcc4843c2f..b879965565ad 100644 --- a/drivers/staging/comedi/drivers/usbduxsigma.c +++ b/drivers/staging/comedi/drivers/usbduxsigma.c @@ -1834,10 +1834,8 @@ static int usbduxsigma_auto_attach(struct comedi_device *dev, } ret = usbduxsigma_alloc_usb_buffers(dev); - if (ret) { - tidy_up(devpriv); + if (ret) return ret; - } ret = comedi_load_firmware(dev, &usb->dev, FIRMWARE, usbduxsigma_firmware_upload, 0); |