summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnurag Chouhan <achouhan@codeaurora.org>2016-09-03 16:19:33 +0530
committerqcabuildsw <qcabuildsw@localhost>2016-09-10 19:06:04 -0700
commit1a77236aa515a8cbbaa7ade7410cb1597b5fd113 (patch)
tree8489d0579e36e82fcf1431f37b8cc25746a08356
parent43e0c7541b296b98a0c7ca4a52c0d2e52250bbde (diff)
qcacld-3.0: Reduce unwanted netlink log messages
qcacld-2.0 to qcacld-3.0 propagation Reduce unwanted netlink log messages and modify the error value print format from hex to decimal. Change-Id: Ia94efe17b80d5f3c4a7006b914f4f0586360fded CRs-Fixed: 804176 (cherry picked from commit f986a945d7124c5bcc962dc0b7f0642828b7687f)
-rw-r--r--core/utils/logging/src/wlan_logging_sock_svc.c7
-rw-r--r--core/utils/nlink/src/wlan_nlink_srv.c2
-rw-r--r--core/utils/ptt/src/wlan_ptt_sock_svc.c7
3 files changed, 9 insertions, 7 deletions
diff --git a/core/utils/logging/src/wlan_logging_sock_svc.c b/core/utils/logging/src/wlan_logging_sock_svc.c
index aedbd3dd3ce6..810416d76666 100644
--- a/core/utils/logging/src/wlan_logging_sock_svc.c
+++ b/core/utils/logging/src/wlan_logging_sock_svc.c
@@ -147,11 +147,12 @@ static int wlan_send_sock_msg_to_app(tAniHdr *wmsg, int radio,
wnl = (tAniNlHdr *) nlh;
wnl->radio = radio;
memcpy(&wnl->wmsg, wmsg, wmsg_length);
- LOGGING_TRACE(QDF_TRACE_LEVEL_INFO,
- "%s: Sending Msg Type [0x%X] to pid[%d]\n",
- __func__, be16_to_cpu(wmsg->type), pid);
err = nl_srv_ucast(skb, pid, MSG_DONTWAIT);
+ if (err)
+ LOGGING_TRACE(QDF_TRACE_LEVEL_INFO,
+ "%s: Failed sending Msg Type [0x%X] to pid[%d]\n",
+ __func__, wmsg->type, pid);
return err;
}
diff --git a/core/utils/nlink/src/wlan_nlink_srv.c b/core/utils/nlink/src/wlan_nlink_srv.c
index 49bc0812a61a..1eda52172abb 100644
--- a/core/utils/nlink/src/wlan_nlink_srv.c
+++ b/core/utils/nlink/src/wlan_nlink_srv.c
@@ -352,7 +352,7 @@ int nl_srv_ucast(struct sk_buff *skb, int dst_pid, int flag)
if (err < 0)
QDF_TRACE(QDF_MODULE_ID_HDD, QDF_TRACE_LEVEL_WARN,
- "NLINK: netlink_unicast to pid[%d] failed, ret[0x%X]",
+ "NLINK: netlink_unicast to pid[%d] failed, ret[%d]",
dst_pid, err);
return err;
diff --git a/core/utils/ptt/src/wlan_ptt_sock_svc.c b/core/utils/ptt/src/wlan_ptt_sock_svc.c
index fe81e8c2d7c7..75dd66f5d7ae 100644
--- a/core/utils/ptt/src/wlan_ptt_sock_svc.c
+++ b/core/utils/ptt/src/wlan_ptt_sock_svc.c
@@ -116,9 +116,6 @@ int ptt_sock_send_msg_to_app(tAniHdr *wmsg, int radio, int src_mod, int pid)
wnl = (tAniNlHdr *) nlh;
wnl->radio = radio;
memcpy(&wnl->wmsg, wmsg, wmsg_length);
- PTT_TRACE(QDF_TRACE_LEVEL_INFO,
- "%s: Sending Msg Type [0x%X] to pid[%d]\n", __func__,
- be16_to_cpu(wmsg->type), pid);
#ifdef PTT_SOCK_DEBUG_VERBOSE
ptt_sock_dump_buf((const unsigned char *)skb->data, skb->len);
#endif
@@ -128,6 +125,10 @@ int ptt_sock_send_msg_to_app(tAniHdr *wmsg, int radio, int src_mod, int pid)
else
err = nl_srv_bcast(skb);
+ if (err)
+ PTT_TRACE(QDF_TRACE_LEVEL_INFO,
+ "%s:Failed sending Msg Type [0x%X] to pid[%d]\n",
+ __func__, be16_to_cpu(wmsg->type), pid);
return err;
}