summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiachao Wu <jiacwu@codeaurora.org>2017-11-21 10:43:27 +0800
committersnandini <snandini@codeaurora.org>2017-11-23 05:16:58 -0800
commit04aed411926911e4e3ba10798d6ea9482d106798 (patch)
treeea7dde82ce21840dd4e42848697eb2487b3f4ab7
parentab1223d6ce977ec31d2ec5ac284b99e5c3bddd5c (diff)
qcacld-3.0: Fix a memory leak in hdd_assoc handler
Function wlan_hdd_cfg80211_update_bss_db will return pointer of struct cfg80211_bss. Caller should invoke cfg80211_put_bss to free resource in pointer. In some case those resource not be free. Change-Id: I7fa55a09fcc3515361e9568cf87966e4533085e4 CRs-Fixed: 2146717
-rw-r--r--core/hdd/src/wlan_hdd_assoc.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/core/hdd/src/wlan_hdd_assoc.c b/core/hdd/src/wlan_hdd_assoc.c
index d2f7b1a1f79e..eb5a2297a30d 100644
--- a/core/hdd/src/wlan_hdd_assoc.c
+++ b/core/hdd/src/wlan_hdd_assoc.c
@@ -2618,6 +2618,10 @@ static QDF_STATUS hdd_association_completion_handler(hdd_adapter_t *pAdapter,
eCSR_DISCONNECT_REASON_UNSPECIFIED);
}
return QDF_STATUS_E_FAILURE;
+ } else {
+ cfg80211_put_bss(
+ pHddCtx->wiphy,
+ bss);
}
if (pRoamInfo->u.pConnectedProfile->AuthType ==
eCSR_AUTH_TYPE_FT_RSN
@@ -2833,10 +2837,6 @@ static QDF_STATUS hdd_association_completion_handler(hdd_adapter_t *pAdapter,
}
}
if (!hddDisconInProgress) {
- cfg80211_put_bss(
- pHddCtx->wiphy,
- bss);
-
/*
* Perform any WMM-related association
* processing.