summaryrefslogtreecommitdiff
path: root/kernel/bpf/arraymap.c
diff options
context:
space:
mode:
Diffstat (limited to 'kernel/bpf/arraymap.c')
-rw-r--r--kernel/bpf/arraymap.c17
1 files changed, 2 insertions, 15 deletions
diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c
index 3608fa1aec8a..56f8a8306a49 100644
--- a/kernel/bpf/arraymap.c
+++ b/kernel/bpf/arraymap.c
@@ -23,7 +23,6 @@ static struct bpf_map *array_map_alloc(union bpf_attr *attr)
u32 elem_size, array_size, index_mask, max_entries;
bool unpriv = !capable(CAP_SYS_ADMIN);
struct bpf_array *array;
- u64 mask64;
/* check sanity of attributes */
if (attr->max_entries == 0 || attr->key_size != 4 ||
@@ -39,25 +38,13 @@ static struct bpf_map *array_map_alloc(union bpf_attr *attr)
elem_size = round_up(attr->value_size, 8);
max_entries = attr->max_entries;
+ index_mask = roundup_pow_of_two(max_entries) - 1;
- /* On 32 bit archs roundup_pow_of_two() with max_entries that has
- * upper most bit set in u32 space is undefined behavior due to
- * resulting 1U << 32, so do it manually here in u64 space.
- */
- mask64 = fls_long(max_entries - 1);
- mask64 = 1ULL << mask64;
- mask64 -= 1;
-
- index_mask = mask64;
- if (unpriv) {
+ if (unpriv)
/* round up array size to nearest power of 2,
* since cpu will speculate within index_mask limits
*/
max_entries = index_mask + 1;
- /* Check for overflows. */
- if (max_entries < attr->max_entries)
- return ERR_PTR(-E2BIG);
- }
/* check round_up into zero and u32 overflow */
if (elem_size == 0 ||